Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27fa0193-e379-6471-96a0-faf2afca5f11@intel.com>
Date:   Fri, 5 May 2023 16:20:17 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [RFC PATCH 4/7] x86/resctrl: Add capability to driver
 registration to create control files
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        James Morse <james.morse@arm.com>,
        "Babu Moger" <babu.moger@amd.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230420220636.53527-1-tony.luck@intel.com>
 <20230420220636.53527-5-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230420220636.53527-5-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alVBWjc0b0RSajFleFZLeXJPSGkvWEVUbGxjcjA1ckk1cWlxdWk1Q1NNNHFI?=
 =?utf-8?B?N0dpd0RiMXFZSVZEN1p5Um8zSm1oTCtZUVNGV2Urd09RMXJmc0JicTNHb3dF?=
 =?utf-8?B?dFRSS3VxRjlwK0JWZnN2cDJRd1RxV0NPY1QzY3M4VGtkRFFmcFQ2ditmNjM0?=
 =?utf-8?B?bnFiQmFNV0s3a2JPbTN0ZHNqU2hLMjEvbll2TExUWXhyMmxKWE1iU0lucDJv?=
 =?utf-8?B?WW4vaWFDa2dQcDZjclNBM0NEdWpXandYNEVoKzJ4VEt5VEloWmFEdHRqS1pk?=
 =?utf-8?B?UEpCcFBod0VXMmFmY1ppYWo5d29BbVNOU3pZb3hBZ2QvZzhLYmNOS1liSjA2?=
 =?utf-8?B?UWRUWXBoRjE0V0x0L0t2NTIyODIxTHBNanRoemVybktsd1BmWXV3aDRzZnRP?=
 =?utf-8?B?Nm5UTG5aZlFNY0p1TjNMTmJiRWxkSnpUWURHc0FOS0lUa2dKZzBFRVhUSXVz?=
 =?utf-8?B?MGRxOFFHMTF4eFZPKzZOUlRCMUZqMWF3Q1N4blN0bUEvbzN0MDhibmFaZVd6?=
 =?utf-8?B?U2hXZFp0VkRjYWpmdWVsNTBsb1ZUVkh3emxCcVk2TGJodGdVNzQyWXBkMmx5?=
 =?utf-8?B?cmZCOWduemg0bGl5dzd0a0tTeUFCWXRCWUt4bmFWWUhoZEpnbW4zNmZKL1pq?=
 =?utf-8?B?cmdqQmFNUHIyMjZVajVsbGEyODZxK1JvTGtjZHpDOCtkd0FHbXNDdmdqek91?=
 =?utf-8?B?amtMNWlYTDR0TGFtRzJsZmI0dENkOUJVbE02bU5MZ2ZKc3N6U0ZPSFFJSXdT?=
 =?utf-8?B?QURmWkJrZjlIODZJeW5DUkZSRDhDbDhKdUVvdnBJeUxONndtWElrV1lpRGRN?=
 =?utf-8?B?OFhzdWltUktGRldpUFQzWE5MM3VxbVVzWFpnS25LQWxaZk4xRDN0LzF0bFVX?=
 =?utf-8?B?SG45WTRxbDI4YjBDbmFuYWw2QncwVVVjYXVuU2daNW5XcGlxZVoyZUxHcFlL?=
 =?utf-8?B?dzdMVC9uZ1RiSDZRaWF3U0RCMXEvVXQwUnBUM2U5eE9aMnE1bjVyV0tIQ3Fz?=
 =?utf-8?B?d0JPeHNxZWI0Wm1WdllSQnNtQU9LTXlUOTlkcVptalBkQUpHaldVRE5jbVBa?=
 =?utf-8?B?WVlMdzZNYnY1Q0h5MHNGa3F4NE1QMzZPdkdUMENteURaOHh5WDRoRlpkSHJ2?=
 =?utf-8?B?cFB5NXlMU245QmJHNDVSblRCcURqQ1l1UGlxdzZOSGdmbHJtL3Q3Z0dBRHdT?=
 =?utf-8?B?bWF5UmJaR0MweGg5bHk5OERFSzRLZHc2UkdDamNocmRwemRtSU52VkFFc3c2?=
 =?utf-8?B?MGM5aVNKRUw2S0YyYVFGeW90VnpycnJiYWh4OEVTcXhuSGxNTG1oRzJkNlRl?=
 =?utf-8?B?UjN4ZGdJaThyZlpiVGEvV2RsYU8vN2ZTUk9QaGhHQzZKNmhldTBNdVpqUFJa?=
 =?utf-8?B?RE5KQ1F6bHRXRWUyTHp0c2wwYmdReHVScU5JcTk1R2M1NSttV3NVZVo5YWc3?=
 =?utf-8?B?QStCTUZBWkRrSkQ4SW1OekVwakloZGQ3T3VHamFQNVlXaGFrYXBQcUl5Z1l4?=
 =?utf-8?B?UExmcDhUdXloRU9lVS83d1JGdXUzbVNDK2lLZC9yWHpnYTZvUFRabHFLckxP?=
 =?utf-8?B?bkZUTkYrYkVzUGhtUXl0QXFOMzBKS1hkU1V3MHppakVIeFhENkNTU3F6d1g1?=
 =?utf-8?B?M3g3cFNvcUxKNkQwWjdUaGxYYVdRS2JzZ2ttaVhTd1RhV1hYZWZsQnIvUU5D?=
 =?utf-8?B?ZUkyUGFBdG1Ya1ZjKzBVQkNDdzRLTEp2Nkw5aUxyanFaQXJiZzU3bXlqc0JT?=
 =?utf-8?B?MWFleXUrTlN5a05LNytsWE90WEVKd1RlNjlDckNmWVA3eTNYVVNnSWVqVWli?=
 =?utf-8?B?bUtIZVFJdU42b2ZnY2w1TVlWQ09Bak82R2pnR2g1aUhycmd0cDlmUEM1aDFq?=
 =?utf-8?B?TXg3N2tDNzd2Sk1IZ29JQmJydk4xbXhDNFBmVWp0RERsVGkreFRYeDFoMXhk?=
 =?utf-8?B?ODRnWkt5b01keGx6ZFBhYWMwRFZHSUYrRmZsaWtLYldSdHRRQVJzR2U1WkRC?=
 =?utf-8?B?RkVXeUwyMzFCNWJ2ckdxMHpWTGVUOVM5eUl0MW8zMHFGQzVWUlg5VElFb0tB?=
 =?utf-8?B?R1BFRXhQMkI2V0crN3VnQlZ6WFYvMTBNMTA3WEhMcVNxRmp3TVYrZU9GTkNQ?=
 =?utf-8?B?UEMrLzg4dkNFd3JYVHVOYy9MWmlLR0RaZnduWGd5ZWFWYlIrM1d1M3hxUnFj?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 549267ca-f017-4803-ddb5-08db4dbf4b15
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 23:20:19.7755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JofVOO4hT1RRfej5PBRzOwuXx6OK/DKfLdQv78gfoJn3+cXVSMI2tqyvzyTRpDnBBYeJ7zEeTqOQZJ88P0OFHiyPZCtbYxwkBIpUIDuqcbo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5953
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On 4/20/2023 3:06 PM, Tony Luck wrote:
> Add a control file to each ctrlmon directory. Hook into the mkdir()
> functions to add the control file to any new directories that are
> created.

I assume you mean CTRL_MON as defined in the docs. If this is correct
the then the implementation appears to be behave different in that it
adds files to CTRL_MON as well as MON groups. It adds the files
irrespective of the group type. Is this intended? Please do correct
me where I am wrong.

Reinette