Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14cea0fe-4e6d-daa1-7987-3d9ba7f793c7@intel.com>
Date:   Fri, 5 May 2023 16:17:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [RFC PATCH 1/7] x86/resctrl: Add register/unregister functions
 for driver to hook into resctrl
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        James Morse <james.morse@arm.com>,
        "Babu Moger" <babu.moger@amd.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230420220636.53527-1-tony.luck@intel.com>
 <20230420220636.53527-2-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230420220636.53527-2-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHNFZ2xSNWFUWk10TnN3RG5JZEp0NkJvTHVFaFNuY1BkRFdKc0gzQlpjd3FB?=
 =?utf-8?B?bUl4dTBqMzlGeHdRd1J5OVNkOG9tQjhvVDBZbHF4STR2VDRINTFFeU5oMmF1?=
 =?utf-8?B?Y0hLZmllSE1oNGN1RE9ZaE5UMUY0dmNlaTdRRnViMlJjbU45SzFqRW5xdWkw?=
 =?utf-8?B?bXB0M0krbmlJYWVyeWNWdmJLbXk5dzdwS3FESmx0V0JsK0lnTDVaS2hMS3RS?=
 =?utf-8?B?VXc2R3VoQWp3OWlUdHExTGR3eVVzdGppYlBsK0IrcXpmUmc2WGlySy9hM2lh?=
 =?utf-8?B?TkI4bkExT3B3bzRiRVZnV2plMUhEZGl5Zy9xQjVjMkU0cXljbU5XSWluMkdw?=
 =?utf-8?B?bEUrYUNtdGlPc0ZwOU5xM1RlM3hJcHlmbW9QWGRXajc3a2ZkWXhHY3FnV3Bl?=
 =?utf-8?B?RW5qMWxra0ZEMDJxUG1YS3JKOEVsOTAwNmhrakRhQmtZdWRESnRsY2doaDFM?=
 =?utf-8?B?VWZDZmpyVDNEM0ZadS9aTzF3UVIra0JFQ2I2MXJ2STJsV1Vrc3REd2NBK09R?=
 =?utf-8?B?cUV1cGQ4TzlzREtPQ3N4Q2JoQkhwQkNsekVqT3F6eG1qbGVUUnIxUHN6ckhM?=
 =?utf-8?B?SkFsWTJjQzgrUlV0OWZrK2w0ODFZUm1STVpGVFFBYWw0UElJQ0ZWRy93c250?=
 =?utf-8?B?dG1LU2R3RERKOW9NVUk2WFl5UXpLU25qTmMvSWdlWjc5KzFWWVlsakVhT3pP?=
 =?utf-8?B?d2xzbVdDQWFFRUtkUzNua1J2bGdmUExwa3B1RFp5K2lURVpFcmZLRlRNNHlw?=
 =?utf-8?B?KzVlR1ZrYWVhUjFMSjJiUytndFhJeHNDVUtOeUt5ekt3TEowZXhpaVR0K2Iw?=
 =?utf-8?B?UGNTbFFZejV3ZzQrMThYRTR0NDhsbmhXanBkWW1LK3JJeWdtVjNwSEsxNENk?=
 =?utf-8?B?V090UGtJUS9Va2d5M3hZTm5VWHdCamJxak5keXp5UXF4d1JKdUNJMUdQSnZP?=
 =?utf-8?B?MEhJUUZyS3dhc3V4WjdKQkg2TzNjZ3lmN2FGTjU5NDlTMkNWS1hwaVlhY01T?=
 =?utf-8?B?ZHF6ejVwUC9nYXVyRGFyVTdYTEVGL1hIQ2YramE2NVFjTy9kbFIwL0p4KzFO?=
 =?utf-8?B?dFVSaUhOZlQwVFZ6N1ZQWC9KMTVVQXRROTBxQ3JkenA2TkdTOC82ejVqZWpN?=
 =?utf-8?B?VFpiQ0k0UDRJaUprRkdKLzl4NkZHNnl4WnRXYkxIM1JWYnJwYWozb3ptdnov?=
 =?utf-8?B?VDNWSGtPWWRkYkhwRk9OSW00RDNJdmNUcHNiNHFnMVd5OTZhaWpsRmZZck9X?=
 =?utf-8?B?WjBqMENOTm1mWjZNRVhNb3lqZXJJWFZTMjZHcmZNRGpCc1N4REswY25CL25h?=
 =?utf-8?B?czdSWGwyaGtldUJDbFJGT0N5VzRBQ3ZNUEVZb0ErdFVEVEsxRGtKdG80YjNw?=
 =?utf-8?B?TTVlYW9YSGpYMjg4clRVR1dZUC9tUzRxVTlFa0NzQkxObjhkSjlFVW1GK0RI?=
 =?utf-8?B?Y1Q1V0h2alRXTFpwckx2clpnWElwenpKdlVNcERNZEtsSXdLQzJnS0JwS3U1?=
 =?utf-8?B?dENlVGFUbUR3WVI5WnF3VGlzS09Jd29lVEcveHVyMXFBMExiYURLdnFleUNp?=
 =?utf-8?B?RVFCejZhZkFuU0RoYjA1TzB5TWlnTGFZK01SaThuWHI0NSs5Q093cmRJbklP?=
 =?utf-8?B?UXZpVW52SEdkTmhjZU1aaEd6SVdrVmJUc2tjM3Yyc0tqQTBFaG5EUitwQTdt?=
 =?utf-8?B?M0VyRnU3b0pVQXB5cFRBTXVTNUdaS25EUlp0M1pyU3lJRXFtK0tMSkVaL1Ex?=
 =?utf-8?B?MDF6Y3FCcFdVU3NHRGwvVEtiMmlOODNZa0lkblU5M3RleEJvU29aMms3Q0Zm?=
 =?utf-8?B?cXV5cHVmZnV1c2EwdUZQRmVDWlVsRWZORHJRaHNpbFE2ejhTcDJBaUFQSXha?=
 =?utf-8?B?WWxESnpCU21taWtPUjFjWGFZZjVrZWE2L2c0aUNhMWI5SHplNlhGeEVIUCtB?=
 =?utf-8?B?eWdhcGxKVDMvVE9RMG8yV3RQZ2hlTWlqZ1ZCbDlQYW9oeHFNeGJJMmoxbnZr?=
 =?utf-8?B?UXl4dHB4cjNtSG03eWlqbjdCN2lVdkFEUThXUzhCT2Y0RXoyOHk1L1dJZEht?=
 =?utf-8?B?Y2NTc3pXOHdYZHN3TkxWTDFFL1hCb3hPS0x0R2tSOVVIaVRnSGpmY3B4cHA5?=
 =?utf-8?B?MmEydVZqTU9rZjJURVhRaUtBVzlJWHFhYjNGSjBPVXMrSlBGSWNnSWFUS1Nu?=
 =?utf-8?B?MFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 383fb0b4-6d90-474e-0d91-08db4dbef222
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 23:17:50.5435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ItauvBheVCK2ur5gZoON9KLaoHOjkKV4KajCKxB1nswnz7I4IeJSMkZl24ly5elrLC1Zur5lklthe6tdH7G+tcU2FZ4lO4BwvHWp9oK0jFI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5953
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On 4/20/2023 3:06 PM, Tony Luck wrote:
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 6ad33f355861..3e6778bde427 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -51,6 +51,9 @@ static struct kernfs_node *kn_mongrp;
>  /* Kernel fs node for "mon_data" directory under root */
>  static struct kernfs_node *kn_mondata;
>  
> +static LIST_HEAD(drivers);
> +static bool resctrl_is_mounted;
> +

fyi ...
https://lore.kernel.org/lkml/20230320172620.18254-13-james.morse@arm.com/

> +int resctrl_register_driver(struct resctrl_driver *d)
> +{
> +	mutex_lock(&rdtgroup_mutex);
> +	list_add(&d->list, &drivers);
> +
> +	if (resctrl_is_mounted)
> +		driver_up(d);
> +	mutex_unlock(&rdtgroup_mutex);
> +
> +	return 0;
> +}

Do you expect that the drivers may at any time
need to call into resctrl as opposed to relying entirely
on callbacks from resctrl? I am wondering about any potential
lock ordering issues between rdtgroup_mutex and locks
used internally by the drivers.

Reinette