Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7c9d854-66ac-4998-b2c2-43c5a26cc431@intel.com>
Date:   Fri, 5 May 2023 16:25:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v4 6/7] x86/resctrl: Display CLOSID and RMID for the
 resctrl groups
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <168177449635.1758847.13040588638888054027.stgit@bmoger-ubuntu>
 <1cec24f4-e4b1-682a-3ada-b51d2a7c83a4@intel.com>
 <88de8b87-6bcc-4794-5e20-cd7ef9891ede@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <88de8b87-6bcc-4794-5e20-cd7ef9891ede@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWw2b3JjSzJleXJDMFBDbnVMZFNpTDJmSUFPeXZzdTlQZjNFZUtHVjdSYnMr?=
 =?utf-8?B?T3FPWDZuc3lTZnRueEFYTE5pcVRsQlFoVFZuWW9hQXd2dk9JOGthLzE4cDB0?=
 =?utf-8?B?UWZDU041M0UwV2ZpOGRuZ2NPWGtWSTZUK0pnaFB5cmJpVm0zUXdEQ2ZyNFZ0?=
 =?utf-8?B?SStGR3RNRFFJN0MxeGhObENGdVJmMHdkS1lRbnYzaVllTlZpMlYvRTVvZENP?=
 =?utf-8?B?MkdOT01jenRTL0dyRUVpRTM0aTFHUUViT0tETUIwOWZ5RzJDSmQ2OE5NQVFi?=
 =?utf-8?B?VGtUVEd4YS9EeWFjLzBvclpBQ2ZNeHdWbkYzaERYbkNLMngrRmhSRFVqeXRp?=
 =?utf-8?B?QzNmcmZ3NEdEUGp3Y1JhTWVWdWd3c29uYk1YdzRJVFBjRC9RT3NocWdYelFQ?=
 =?utf-8?B?Z2VYVENodFdlN0F4QzE2MWhmUVQ4SzY5d2ZzcDFsTFIyOWJsSnFIbVo1RVov?=
 =?utf-8?B?T0h3OHdKV1dQMElxZTlOc2pORnVJa0RGMEx0aTlndGJpTENiRXlwRU9NMm52?=
 =?utf-8?B?eG1kdk1nZi9QTU1ORnMzTW5UQlFyR0M5REVlVXhQQ2FUSTRpWWQ3VzNHdVQ5?=
 =?utf-8?B?S3d4bHZySmNVb2ZZZHFjcWFPa2p3T3E4a0grNUJPM1hSbUNrYTNyODMwZ3F4?=
 =?utf-8?B?V3pwVEhVSjNxRGgyQVlNaUFmM3dxUUJNTTN4T0hwdjkxbU9nRDZ6Uk5LcVY5?=
 =?utf-8?B?VXg4SkY0YzZ3OEZya29hSjJHTDhYOFpGK0NWL1dqUzZnNW44RVRGN21IZ3l0?=
 =?utf-8?B?T3dLbUpYRWhVeDB1aFlFMkNKVHMzcUd6SHZPYnVoSlNPZlJ2Y0pBYXMwYnND?=
 =?utf-8?B?ZXF0bzZESUxxL012MmxrVjBwQUR2dUVsd2Jodi81L09DQVhMNmV6a3VaV3Ez?=
 =?utf-8?B?SGNqWHVUN2RMbFhQZlV2VkJtSU16alZmcllja2VUakJRUXR3aloweDVWVlR3?=
 =?utf-8?B?bVlvSVpHZnArczBOZnNQOVY5Z0d5S1V3TmxUVjN2T2x3clNnc3dFQ2ZYdW05?=
 =?utf-8?B?VThqUWJweWQ5M2psdXFzK0xLY3h4eGVsbzkvSWxyYXBZSE9aVkhBUFpHMyt0?=
 =?utf-8?B?RlFyNEhjR1dmRWduMzNRaGVxTnRrSnY1N0lUNmsyZ2lZaTEwV3VvYVdhT3Nv?=
 =?utf-8?B?MHpRd29RNW8vWGhPR2tWSnh1T1pZYWNxSnkrdzFFdks5ckRNWDN2ZGlUWUJG?=
 =?utf-8?B?ZitnQ2htVFU5YkpZZFV5cXBGRUl6dmUwcTNDMi9mMlhCZ1NITHZXNVdzdFF1?=
 =?utf-8?B?b0liSEZ4azFxSExRVy83bDNMbjEvNUlGSnNzN00rdlE5MzZ1M09DemtycmhP?=
 =?utf-8?B?ZVBkUFVCM1h1MU9hUW91UTBCdXhLV0RrM1Y2MVVsd1ZUS0FRTWhvWHVTS2cy?=
 =?utf-8?B?SnE0RzNzK1RNaDhlcHNTNHNuQitzV0pTVmdFb283MmZ3YjFid1doSGp6dnJ3?=
 =?utf-8?B?QWkweWhySHJGSVNvSUZXYzBLTVpzRml4anZRTi9ubHlIOWllNCtxUFhZZU96?=
 =?utf-8?B?MVJ1bDFUK1gyNmRhSE5FS1hWMCt5N2dQMnNPZnI3clVQaWNPRWZKL0M2N2h6?=
 =?utf-8?B?NWUzaHVrVXNpSzh0UU9QZ3FFTW1iNXlJRWxUMjBmem9Cc1FUejFtRkprWHZq?=
 =?utf-8?B?MWxPNXVKWHNXT2IwS1E3dGltUXdKejFTMVBCZ0hvNENpd2c5UllaQzRjSktU?=
 =?utf-8?B?cHhaVThIcVo5bFdBSzQ0TjlQWFVBSXVycE96K2RsQTN0dFRpUGZXMWtVUUc5?=
 =?utf-8?B?c05NN3huM1pycWluSXhoWlpyVktOMXlzVlI0WUlFeTJZV0ZYOHhGRk1ScnFj?=
 =?utf-8?B?dUYwRVd1bnZJYXJyd2pwbmVJZDhvY0hvSFFPRCt3SGlPS3ZvdERRUHFJNytT?=
 =?utf-8?B?dmF4M2lmMVE3VlhaMkJKOUpIbnlPbXlwQ21MVU5qTXZKbGI3OEx1WmkzWkNT?=
 =?utf-8?B?NHFQMXFuZ1hHUmoyeVNIYnJvVUExTG1VcFlNTSttSzNveVcrK1BNdXNjWDFG?=
 =?utf-8?B?d29KZWdNUmlQOUs2cHVISTlrM0E5N25QNW92QzRnckladnhoQzQvVmRWVlFX?=
 =?utf-8?B?MndjVElvZHZGRkNGbXpaS2NSaGFmR01QR2o2T29BZ2VLZFlBREd0UWNLWmFq?=
 =?utf-8?B?Yjg0eGZVakprRnY5L2lHYlJJSzJ0TnRnbWlMM2hmZmhnblY1WWJDVVZkU2lK?=
 =?utf-8?B?SXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75757a79-530e-4452-610f-08db4dbff7ac
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 23:25:09.3595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EVb+9us3qXVpGqb+semxySwX/aGxLM80OeGBkWCP8AuD2i52kJ+lOXelbbGhiFoNZaS5wjjWHDoMdWv1dGRrXb2In4fdW038BQYShIFDm5o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5953
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 5/5/2023 2:45 PM, Moger, Babu wrote:
> On 5/4/2023 2:04 PM, Reinette Chatre wrote:

Thank you for trimming the header in replies.

>> On 4/17/2023 4:34 PM, Babu Moger wrote:
>>> When a user creates a control or monitor group, the CLOSID or RMID
>>> are not visible to the user. It can help to debug the issues in some
>>> cases. There are only available with "-o debug" option.
>> Please see: Documentation/process/maintainer-tip.rst
>>
>> "It's also useful to structure the changelog into several paragraphs and not
>> lump everything together into a single one. A good structure is to explain
>> the context, the problem and the solution in separate paragraphs and this
>> order."
> ok Sure.
>>> Add CLOSID(ctrl_hw_id) and RMID(mon_hw_id) to the control/monitor groups
>> Please highlight that CLOSID and RMID are x86 concepts.
> ok Sure.
>>
>>> display in resctrl interface.
>>> $cat /sys/fs/resctrl/clos1/clos_hw_id
>>> 1
>> This example does not match what the patch does (clos_hw_id -> ctrl_hw_id).
> My bad. Will fix it.
>> I also think this change would be more palatable (to non x86 audience) if
>> the example resource group has a generic (non-x86 concept) name.
> 
> ok. In this example the clos1 name sounds x86 specific. I can change it to ctrl_grp1. Hope this is what you meant.

Yes, that is what I meant. ctrl_grp1 sounds good.

Thank you

Reinette