Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2e1d8d8-9687-4269-28d4-8291acf978a5@intel.com>
Date:   Fri, 5 May 2023 16:20:00 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [RFC PATCH 5/7] x86/resctrl: Enhance driver registration to hook
 into schemata files
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        James Morse <james.morse@arm.com>,
        "Babu Moger" <babu.moger@amd.com>
CC:     <x86@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230420220636.53527-1-tony.luck@intel.com>
 <20230420220636.53527-6-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230420220636.53527-6-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW4wSmtPaU5CK1BkSGFrZmlKS2tlelFZNGFVVG5YZHpTaUI5d2s4M252cnJC?=
 =?utf-8?B?SWtKTVprZUtTNE1QbHBIcHowcUFkeG9uaVU5eHZKZGhwV2UzbFg0Q254djI0?=
 =?utf-8?B?YkxCS0dwbGxjRzNVZlg0N0VBakpaSW12N1BmbFFvUmY0VUxyaDdkUnhZek5r?=
 =?utf-8?B?dURadDVvOUdNOGdaNVVJUWlMWVRUS1hQM2VOb2xYa2pPTHRwczBhL0FGYlRD?=
 =?utf-8?B?M01lNlk1QldkTjNjUUp1aU5VNGFMUVZCaEZXQ0ZaaW9ZQ0FFaE1zdXgvT0Fq?=
 =?utf-8?B?WTFxOUN4L0VVUmxJMEsyMFUvZ3lwMDRWUHpUVzV1M29OL3Z0ZVpEYyt4amhU?=
 =?utf-8?B?NWlWZmVNai9qTnFTc0FIQjV2UFNIcG45bHgwZHkzQVpUcXlBS0d6ZmZremhF?=
 =?utf-8?B?eFkwb1llZXBGeHc3bVRCT0hqTlMyN0lRcTNLRG40dDZmTUJkamhsNWV3d0pO?=
 =?utf-8?B?MWRldXRHYklZNFZYVGpKLzB0SEovU0g3ZkRaTHJlTTFIeVpWc2NSRzg3MmNU?=
 =?utf-8?B?QVpjRVBYMWZ3d1FmajdHVU4rTFhNMmFySXh3N0d6N1R2UFpZYmhwa2JsaFFC?=
 =?utf-8?B?TFNqWDZyRzFjWlRqSlFXMGpCL3pZbzVPaXE3cXlmQXpmZDliRTZKNGJTZTBs?=
 =?utf-8?B?UkJ6aVJVQjY2ZVRYNzJFaUZJbkNCdys2MEdjbjNDWVNLME02cXJWOXNpQzUw?=
 =?utf-8?B?N25zaHVnV2Q1TjdqeE5KckVUbnQ0TXZNZjVndmkxd3NOTGhIK1dkaGJvbXVC?=
 =?utf-8?B?dFpVbWZTMEFvNHduTisyZEVkZDNkUWdya0Z0cWk0U0J0SHVFdk9yVENjdHlP?=
 =?utf-8?B?RDJ2OUVJUmJCMURHWHFSUFArQTFCNXVrMlVCVlNRWDdiS085bU1sY2piR3Jo?=
 =?utf-8?B?c0NZU201aFN4bWxPSFZ6dEt3ZTFnTi9MS1hyK1AzZFU1dUxLeU9qS2VkSFMx?=
 =?utf-8?B?TWtxcnNlamZEUmN0Wk9ibUtPMnhFemJ2WlJoNkhaM2RiVUFTc0ZWRGZFOGUx?=
 =?utf-8?B?ajZIZ0xZL2g2UFBUQ1RvMkFSRzVWNVlVVTk1bm9iM2NPMVJZbDEzeUo3WTBT?=
 =?utf-8?B?dVBzOUFQWHZEclhkWE5PdEU0TVF5NUppTTFwcHl6KzJ0NGs3L3ROMUJLUEVE?=
 =?utf-8?B?WUVFKzl0U09oUVgvVmpKdFNjNnlkdDZ2TG1iaGthdjY2ZUdXSm5NVjFKRVhw?=
 =?utf-8?B?QkdHblhpM293TDF4OFZVVUpQclN6TzVsV2E0UGVrbnIxL2xNTHdYazRkRGVP?=
 =?utf-8?B?U1F3M2kzZGl2Z3d3bnpzTllZeXQxa1hXRi9BeG0wa1B4TC9weFZhSldWNy9I?=
 =?utf-8?B?RUlUVHZ5N0N0VjQ4MmFVeHc0MzdqRXFPanpXN0V3MW9iMWY3eFBKcWxlSHZi?=
 =?utf-8?B?WEFHVjVvbXFrWkNiQVRRdFdaeG9Sak5WYXpHV0FYTDVLMTJyWTl1UGJRWTB3?=
 =?utf-8?B?UUc0U0txbVo5OUtsKzNzb0dQTGxZYksyRWJvQ3QrN1RCWjcwam9nOGY5bmRR?=
 =?utf-8?B?bGM4RXlJTi9PSStsdGhTSjZDS3h3Zld5K2w0WWVPSmxVVGh0UlduQkpocHRy?=
 =?utf-8?B?dWIrWnFVNktNdDNvRGVlYURLZ3haNGU4VXJkY1BLNGtNRVc1SHprcEcyNlZO?=
 =?utf-8?B?NmFCYzZldjc2U3k1ZE83aVpwbVZTOFBMT2xFRm84S0xCRThRL2M5TTdTWjND?=
 =?utf-8?B?ekRxVHJvOS9CU0JaYnpTVnZUcitlbGNmcVNqL2dxbjFKRitnUGk5OHd4anpE?=
 =?utf-8?B?SmVRQXdyNFVldnpidXFJajBjVTFCalZtS1BKcDR3ODM5b3ZPMXZaYU5xUGN5?=
 =?utf-8?B?UFloRTNFRHNSYkRCQWkrVWd5L0pRZXl1TlNqczF0ZEpzTEYwUUVhdS9KVFh4?=
 =?utf-8?B?dkcrWVREVmFoVmI3SFJOUVh3a2NNMTJVODdMWTZ1cUV3RWpzRzlUUUYwazNJ?=
 =?utf-8?B?VDRxOEE0c0tXUjdrODh5WEEyQUgxdnBCSUQrYmx6N0Jtdzg2TE1UUmc5b2sw?=
 =?utf-8?B?QzBzQ1VNOTZjZkkzdEIxMUd4UzVmSFQ0eXIybnpTMC91M3RGWTQ5QzFHY1c2?=
 =?utf-8?B?RVNyb2xma3lNVWtFTkVDRVdIdEgrL3BQUVNyb1dYWkg3UVVBeWVvRjdpYXBR?=
 =?utf-8?B?TmdTbFJtVVpCbGFQZUZ4ZkJwdUZ6TzVkSURlaDkxdGI2SitlMmFhb21vKzBL?=
 =?utf-8?B?UVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b99195fc-72f0-4cf4-600b-08db4dbf40d5
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 23:20:02.5662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eWT9uGWYctQGpuqTWvWRq/aPIuH5r/5fhVtQyo8nmGEtrsLD5tU72YzAWs2ALeBGuKHq2EK+vHWQXg8OFDXUh3hciD1+uGhga0NJg33tjP8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5953
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On 4/20/2023 3:06 PM, Tony Luck wrote:
> Add a new configuration type "DRIVER" for lines in the schemata files
> with a show() and update() callback functions to the driver to maintain
> these lines.

If the goal is to have unique APIs for resource, could an alternative
be the have show() and update() callbacks associated with resources in
resctrl self?

...

> @@ -2390,6 +2392,9 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
>  	case CDP_NONE:
>  		suffix = "";
>  		break;
> +	case DRIVER:
> +		kfree(s);
> +		return -EINVAL;
>  	}
>  

(This could perhaps be simplified to not allocate the memory in the first place?)

Reinette