Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 May 2023 21:14:47 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: Fix potential out-of-bounds access in
 mas_wr_end_piv()
Message-ID: <20230506011447.2e47mf5kwwo4yz4r@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230504031422.47506-1-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230504031422.47506-1-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xnKtgghOuPHuBIX4O9IAgfsuSB2bqI5n+cK8wm9It+AH8t85ghE80tQ3wP3t?=
 =?us-ascii?Q?C+2r07DU5DOGZJX+4dhhizh4YZyuWkq7lF8/ZldwJGUGP4qI/ry5XVMz104S?=
 =?us-ascii?Q?n+XaACll5IWRi2JaiyCaOyDwY2JVnbWn3FgCAHhBRShyTVJlRBqp1UIVmfZp?=
 =?us-ascii?Q?k+BMWl58W4DNkn9iXqbOd+YbMEYOGhDTJwFp4cT+dr7sQ8N20NzRwAoEYU6M?=
 =?us-ascii?Q?Qgx7jRhU+t3ml9utuF182iofQD1YTFsUADfK8Bmsp+wlJkxT1Mwy1h7DMFo4?=
 =?us-ascii?Q?927Ayx+FjBpYNd/CGfPqvPWykXynwMktvtfgp7HtHmtTUe9eMkIEksLWq2MG?=
 =?us-ascii?Q?XXh5yRm9hRnSOt7XXxTGbyeqS13M6czocuZO3duuX1/Vdl+SEuh25dwKTtyQ?=
 =?us-ascii?Q?Smzn0T4mGN6JYRVT7PsYZxSs/erEXm8QRgj5Jz0gdkz43sc+5KDRHsHY38IY?=
 =?us-ascii?Q?RkE8qDUfNDZ33cdPSuv7l/OBgaktQKHCtJ17Wjf68UfxQzmbablDXMp4PSyJ?=
 =?us-ascii?Q?xlp59YzYPtO+dxv8kHcdbnqSfK6NvU0VMelTtZ/ZbP4iBJXu4uC8vFA5AAnD?=
 =?us-ascii?Q?ropgdrHjPCLQMxxvPnBtA9TnUpEJVBpZVE+ZXtIKpuvqwfHlXrGqpcePNjyc?=
 =?us-ascii?Q?Ddu6+cWc3dv3ge8DI0Q79TeDnDMIRfrg19gDs46pmLEMlfcTddeZWxgWgpPb?=
 =?us-ascii?Q?c2gZ8FtI3Rdjr6lVcsF1Mcr5aB/5VTCCzu79DJtRF9/FHuWlafwA64ow/KGa?=
 =?us-ascii?Q?AgVCGBlCpBzIisGQEEs5CT+OI4gt0ngVIwV13RLR+aCtiPqm1pTt5A+fFysL?=
 =?us-ascii?Q?ZM6ZalZk6GeyuKHFlV/9z+VFemITbYp86ypBsb7PIu8cin9qFHrOKrOPRPC5?=
 =?us-ascii?Q?fqeavOpcONNpoOty5JzRoA5kQcrWXeoANIXuVH1ByYDpM9niBxsida+06ILL?=
 =?us-ascii?Q?9J43fIt3MmPFZJrlVAEfc9hqsuDUqJbueMRDBkxaBgJSJ1LlXcxy5505rj+Y?=
 =?us-ascii?Q?x4gedKRTRYO/820iqrcM4ir6YsbOCbbkfNZShHsuP5dbQ5AjBT4mambFDdUb?=
 =?us-ascii?Q?rqbZZZz0dlJevwNtaivQQHgnRadck06qeRz00EqYr/qJiJAxnLuFq+OTMbKo?=
 =?us-ascii?Q?fRZtK+43k8SDjX4I+LVXEgyY/jkYY6U0wj2XPHsuFqEr4EIoOPLUaWH/0g+x?=
 =?us-ascii?Q?yj8p8ZVIvvLKDirx6zqicPlzSGvvzIhBUn6UDR+jlchOmqxyFGDuJMS2ANaK?=
 =?us-ascii?Q?+miOpGLVRfhbpPHe+wNfQS2JR/I+XkgWhYlCid96JGYaVfApVmZBqQWQEbj+?=
 =?us-ascii?Q?ViNglhS0/B/K+5PmG5F5z1yhN8VKzP4Gfqx+30QfDyvXDGTR5xyq1CkvxhQJ?=
 =?us-ascii?Q?9yOOr1OD6eF3m7Ag2LLcUQQGrB4d+zl7UkU23eohehkapFPLq7PPWost9lh6?=
 =?us-ascii?Q?jeAofntR/k4bQS7FrCCHrRW2fnn7/F9V1jrwO533wW4RDdHmM7j8Ie5nxLtX?=
 =?us-ascii?Q?mCrFLXnlMQ5AiU2gsB+Ar/TVS2n7OPC2fUAUKwgmlIhOqs/jf8tqg2fVk64q?=
 =?us-ascii?Q?WhvTZS7a7GvTx/fRpT9tTOUG+FcoK93KFRZyOhbnXsVJV6AGd+8U3vFbsq8W?=
 =?us-ascii?Q?yA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?rsXnTGTdhYyw8XVCmRJJnm5Uj5v9BS1UTvtoJdiIwM8Pb1gfFpQigoi0gF6k?=
 =?us-ascii?Q?Xsx7Kj2v6HDyh2IweJxOBLy5PxrldG+fExJZvGD7YZU+KfGzQKrp6bfiiQJ0?=
 =?us-ascii?Q?+9q6ggKnANn8IgFyYY9PNm6I9jAfvq/5U/YlxZdAB4gafv7ZQwnfn+EPpttO?=
 =?us-ascii?Q?6Izd5txKyVHR4PPERY9xcW89Q9XeHVll9DRUPgKRYSHyBDMhvpbWFEPkFh4R?=
 =?us-ascii?Q?yoBK+/z4CoQgN9376wLQ/a7/s5UYuSIR3Rl4A3QFo90avi9c6zB2XPtXD0WW?=
 =?us-ascii?Q?+e5h/P4j8Z1rLAaZAH1MXw83t3cXN6tcpnUTZ1coYnd0zMQ+dGSwxqEhxiGf?=
 =?us-ascii?Q?mRlPed7qr+NbvfQQxtOSp8c6SUJyBChjqsCyV9fQ1oBqfOeSogR0lpOAfIzF?=
 =?us-ascii?Q?IZrqdkrL3MsgWr7WhtcqHIYSgrVC4z8n+j6LncQD7hviHPVaER4AaDI47129?=
 =?us-ascii?Q?zbKGqAeNdju03ccAG9k1IYz82BwTB//DY1dWCebWCdkJjocuQLKjsrDWhIMH?=
 =?us-ascii?Q?r69N7Th+09qZ0YfwAaA8kS/PKl3ar+hac404BmJyghsJOInJkSg2RDrKbBpW?=
 =?us-ascii?Q?7VV8RE0cvGmuu8cn5hOo2VH0swGDtH9I+UX/xxHJR3nAvcKICFVbzLF4MNdd?=
 =?us-ascii?Q?lTip+JkfXxHXQ3dotPg5QCrdCsrWt5MZ4VCG1fnJ+LeIVxyfcA9hMv6xj1Zk?=
 =?us-ascii?Q?V3xtZdNZQcSZDhXhaoVpdqIwk1aP9o0YinwJe1gckUq5ZsxVvpcw7gmhBnTo?=
 =?us-ascii?Q?q1ua/q5dSw8q9p7tUup/2hMy5/x8hCLPBbEB+qTX5tgeHf35JbMATXPbxnIW?=
 =?us-ascii?Q?LD8PAsZf4+sXK/hA8UuS/hKePazK8+kJcbl4aUjN14yrq4CbqLztjT9/Mp0e?=
 =?us-ascii?Q?6e5aitH2gjsq8YC8bcOCmQenHZSWCBMh4kjwU/3ufggA4joTNCNtn3SgAArI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27db184a-062e-4994-88dd-08db4dcf4a12
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2023 01:14:50.3309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: moWGo6e2TNayCnPc5LW8l61cJwFhQvvpMtORmSsULLIU0xyycXDBSmOfvOJyvNyGTqv/vbZPK5lsxu0yWX4f6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR10MB7652
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-05_29,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305060007
X-Proofpoint-GUID: Wlll3ncvefuu9Hh25UTVm9dUwNRILEEB
X-Proofpoint-ORIG-GUID: Wlll3ncvefuu9Hh25UTVm9dUwNRILEEB
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230503 23:14]:
> Access to the pivots array may be out of bounds. Fix it by changing the
> code to ensure that the index of the pivots does not go out of bounds.
> It is difficult to assess user-visible impact.

This is indeed an issue.  There isn't any user-visible impact for
current node types, since the overflow will access the slots and be
corrected in the next if clause, but it's certainly better to fix this.

The commit message is also not as descriptive as necessary, perhaps
something like:

Check the write offset end bounds before using it as the offset into the
pivot array.  This avoids a possible out-of-bounds access on the pivot
array if the write extends to the last slot in the node, in which case
the node maximum should be used as the end pivot.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> 
> Fixes: 54a611b60590 ("Maple Tree: add new data structure")

Cc stable ?

> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  lib/maple_tree.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 110a36479dced..5a49327444d76 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4263,11 +4263,13 @@ static inline bool mas_wr_slot_store(struct ma_wr_state *wr_mas)
>  
>  static inline void mas_wr_end_piv(struct ma_wr_state *wr_mas)
>  {
> -	while ((wr_mas->mas->last > wr_mas->end_piv) &&
> -	       (wr_mas->offset_end < wr_mas->node_end))
> -		wr_mas->end_piv = wr_mas->pivots[++wr_mas->offset_end];
> +	while ((wr_mas->offset_end < wr_mas->node_end) &&
> +	       (wr_mas->mas->last > wr_mas->pivots[wr_mas->offset_end]))
> +		wr_mas->offset_end++;
>  
> -	if (wr_mas->mas->last > wr_mas->end_piv)
> +	if (wr_mas->offset_end < wr_mas->node_end)
> +		wr_mas->end_piv = wr_mas->pivots[wr_mas->offset_end];
> +	else
>  		wr_mas->end_piv = wr_mas->mas->max;
>  }
>  
> @@ -4424,7 +4426,6 @@ static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas)
>  	}
>  
>  	/* At this point, we are at the leaf node that needs to be altered. */
> -	wr_mas->end_piv = wr_mas->r_max;
>  	mas_wr_end_piv(wr_mas);
>  
>  	if (!wr_mas->entry)
> -- 
> 2.20.1
>