Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dang Huynh <danct12@riseup.net>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: Add Fxtec Pro1X (QX1050) DTS
Date:   Sat, 06 May 2023 08:42:13 +0700
Message-ID: <7894772.GXAFRqVoOG@melttower>
In-Reply-To: <abae55ef-172b-036f-40a9-b27c38e850ec@linaro.org>
References: <20230505-fxtec-pro1x-support-v2-0-0ea2378ba9ae@riseup.net>
 <20230505-fxtec-pro1x-support-v2-1-0ea2378ba9ae@riseup.net>
 <abae55ef-172b-036f-40a9-b27c38e850ec@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

> > +	qcom,board-id = <34 0>;
> 
> Does the bootloader refuse to boot without these? Some newer
> ones don't need it.
> 
> In case they are compulsory, you'll have to add the pro1x to the
> relevant allOf:if:then: block in bindings.
> 
Tested, nope.

> > +&usb_dwc3 {
> > +	maximum-speed = "high-speed";
> 
> Do you know whether the phone supports usb3? Usually if that's
> the case, you will get usb3 in fastboot.
> 
> You'll need an actual usb3 cable to check that though, many claim
> that but then don't have the necessary wires connected.
I asked around, they said yes but without anything to test on hand, I'm not 
sure.

Should I remove it or something?

Other than that, I've fixed the other issues with the series.

Best regards,
Dang