Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 6 May 2023 11:47:13 +0900
From:   Sergey Senozhatsky <senozhatsky@chromium.org>
To:     "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v2 18/36] mm: Update vma_iter_store() to use MAS_WARN_ON()
Message-ID: <20230506024713.GB3281499@google.com>
References: <20230505174204.2665599-1-Liam.Howlett@oracle.com>
 <20230505174204.2665599-19-Liam.Howlett@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230505174204.2665599-19-Liam.Howlett@oracle.com>
Precedence: bulk

On (23/05/05 13:41), Liam R. Howlett wrote:
>  #if defined(CONFIG_DEBUG_VM_MAPLE_TREE)
> -	if (WARN_ON(vmi->mas.node != MAS_START && vmi->mas.index > vma->vm_start)) {
> -		printk("%lu > %lu\n", vmi->mas.index, vma->vm_start);
> -		printk("store of vma %lu-%lu", vma->vm_start, vma->vm_end);
> -		printk("into slot    %lu-%lu", vmi->mas.index, vmi->mas.last);
> -		vma_iter_dump_tree(vmi);
> +	if (MAS_WARN_ON(&vmi->mas, vmi->mas.node != MAS_START &&
> +			vmi->mas.index > vma->vm_start)) {
> +		pr_warn("%lx > %lx\n"
> +		       "store of vma %lx-%lx\n"
> +		       "into slot    %lx-%lx\n",

A minor side note: we usually prefer to avoid breaking printk() format
strings because it makes grep-ing difficult. But in this particular case
it's fine, since all the format sub-strings end with a new line character.