Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1867294rwr; Sat, 6 May 2023 00:00:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7l8SsGXf3Z9m6ghh+FpptDozQWE4f8UlJhnXwsk8FbM0/NsREXiFM0GNcLwR+yb/x+V6cA X-Received: by 2002:a05:6a20:3cab:b0:f3:ac88:c048 with SMTP id b43-20020a056a203cab00b000f3ac88c048mr5222929pzj.7.1683356454836; Sat, 06 May 2023 00:00:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683356454; cv=none; d=google.com; s=arc-20160816; b=QUclRt1eGPJGLSvEObyXm7m0+oYcBN6KfYGHgcUkzW8FuYNehk1JUTtq/StaExBCI3 8Jiha5gdkbbJxHwqYi2iPSPAFg4TqZwJpQMBMKFzguJfZswWuSKnhdvjOxu5QWqkVuBo PVfIsrb5LQ73LYP43Sx8bEW+e4x4RYqBJfvmulj9vL6wJMejQHjVMhhPga4it6BIunhG v2FllF9sAxbVhzXB0xv++pRZ57oOK41km1+kdB+hYnQCjgtHvS+S1ODiUkmgRdn/XrVm Yo7DE6MDkb0AMEsTyGhXaAEzSf6iqVrQyIieC17n5peFvMBG2LUonC5EuEJdO4Gd2I1n pYZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=Qc6vJm3sOHy2m67M8h7mZWMWWELGSw2ctEieIrxVVkY=; b=C4EDmBf+I8K8lHCQdcqmi2MvWvxl3x+vj38/PCmI23BrWqej/Dy4xiyawNkZFsh4Sf pg/pnDHMwJGCb2JggTf68LlvBn60Mg46AykwtOPhKfMnVvV0lyNPbMiMh6XMf2F1A0OV /QpW1obXfuKEHrngJfngSPNYW8X8lX4wckayL+9IoPmOdXd1ldY0dIkgkrpUyJIzuFfk qONTrsvZDN5cxtoJ8vBz//J4YkWGE6onw7WhIEMimdCdXad5Bc6b0t7X5LX2GXSEv/yB vwXrLYRYaYbcdMf9bsZ382khZX/2ofuTPSmgtRqefXZcEx64Skt8EsRQC9is0oZO9ZnW I1gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@t-8ch.de header.s=mail header.b=oT9Ok1fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020a633f0c000000b0051b85b5a3d1si3603874pga.127.2023.05.06.00.00.37; Sat, 06 May 2023 00:00:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@t-8ch.de header.s=mail header.b=oT9Ok1fy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbjEFG55 (ORCPT + 99 others); Sat, 6 May 2023 02:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjEFG54 (ORCPT ); Sat, 6 May 2023 02:57:56 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C47CAD14; Fri, 5 May 2023 23:57:52 -0700 (PDT) Date: Sat, 6 May 2023 08:57:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=t-8ch.de; s=mail; t=1683356270; bh=qfP1uGBATJXPyIAjGfTIHMkkkfcGfotoiwlxjMWok9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oT9Ok1fy263u636kVgx+NMETMgaV0aRO9Fehf8aNE2NrvWrEdJ/Swye8PFE4puwtH LGqI+7lywvW+bBPlbQUJ3yRsOKHNzvP40hEnI0Ch5rRwOaqur63qu8lJTMscsX/8Dr drFX75pJ0md5WNadAemfyry0Nt/wTv9QvbW70DBs= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jorge Lopez Cc: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 00/13] HP BIOSCFG driver Message-ID: References: <20230505220043.39036-1-jorge.lopez2@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505220043.39036-1-jorge.lopez2@hp.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-05-05 17:00:30-0500, Jorge Lopez wrote: > Jorge Lopez (13): > HP BIOSCFG driver - Documentation > HP BIOSCFG driver - biosattr-interface > HP BIOSCFG driver - bioscfg > HP BIOSCFG driver - int-attributes > HP BIOSCFG driver - ordered-attributes > HP BIOSCFG driver - passwdobj-attributes > HP BIOSCFG driver - string-attributes > HP BIOSCFG driver - bioscfg-h > HP BIOSCFG driver - enum-attributes > HP BIOSCFG driver - spmobj-attributes > HP BIOSCFG driver - surestart-attributes > HP BIOSCFG driver - Makefile > HP BIOSCFG driver - MAINTAINERS These could be reordered a bit to be easier to read. * Documentation * bioscfg-h * bioscfg * biosattr-interface * *-attributes * Makefile * MAINTAINERS Also currently the subject spacing is currently inconsistent. Something like "hp-bioscfg: foo" would be more in line with the rest of the kernel. > > .../testing/sysfs-class-firmware-attributes | 117 ++- > MAINTAINERS | 6 + > drivers/platform/x86/hp/Kconfig | 16 + > drivers/platform/x86/hp/Makefile | 1 + > drivers/platform/x86/hp/hp-bioscfg/Makefile | 12 + > .../x86/hp/hp-bioscfg/biosattr-interface.c | 319 ++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 982 ++++++++++++++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 523 ++++++++++ > .../x86/hp/hp-bioscfg/enum-attributes.c | 482 +++++++++ > .../x86/hp/hp-bioscfg/int-attributes.c | 448 ++++++++ > .../x86/hp/hp-bioscfg/ordered-attributes.c | 443 ++++++++ > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 584 +++++++++++ > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 381 +++++++ > .../x86/hp/hp-bioscfg/string-attributes.c | 415 ++++++++ > .../x86/hp/hp-bioscfg/surestart-attributes.c | 133 +++ > 15 files changed, 4860 insertions(+), 2 deletions(-) > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c > > -- > 2.34.1 >