Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1919468rwr; Sat, 6 May 2023 01:10:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4p86Fmig2u+8scNp/KlFbJpeiukmgIPNNqrDQZWZrcJaOKvzWFLG15gmwn3bN0rWkOv93l X-Received: by 2002:a05:6a20:54a1:b0:f2:6d58:ae8e with SMTP id i33-20020a056a2054a100b000f26d58ae8emr5438897pzk.5.1683360612815; Sat, 06 May 2023 01:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683360612; cv=none; d=google.com; s=arc-20160816; b=gkW950H3peknm0J5D1dEO4NCQLpFd+ngrDGPiJvVnWr+3UHijotRY/UKaCDTYvP7oW 2jlbrl5tw2Pr4p6qJdOsIVMw92RMH66o+K2ungtTWq0RZMr7Rs0U3MceVc8eYk/JJ8QH 7dELNmEUfY5YEZxchXirP3KWYMD2oTKSVyl8iBag9oMV3OwgQJTyDBAhFKnC2+toovzN 21bZOgnihOCmSqr/x2Os05WGGqK079KmdVSzoY76HYqDFXS7JYmaNLrj9OFCWMeSLjMp eGgxpOBmAoij4b+3u2czpXFjc1TS1G/ThTWIPJyWP3LqeuO6MekgEhyYZN+RqfFmd/wn pv7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=sxqO1BhQxpx3nXvd5hztegHgGoinuRkT+BJ+F8igvMA=; b=w5P4lgoyLUJ9SzOYrhl/HGqzsa/2nN2cTLw3m+c0h/LCm1e9goMjTexx4/eK47CdYV 4iCLVSKmtLRso60oqIP1H9guBNTM6f6CALTTClFJKstceRxUXkyc/OOX7WgM9k/umeSX VaBiAMwVdnpWRmUI1ifN4OaZULeYPlIN3E4rM4W/UVk6AK5yKyLLoDeXzKPbOQTt6Qxk QdpQErBioQe5j+vm3L5uxbLtGPvlJ//94/BRf6wQAcHL+oEczqOEg8f26KXDklIN6SZg gNvAuT6bJ+qfx1GtDdXKTLFfYXr+bH/8OKaxedGhmYXDCL4Tfkko6C6s43SEjho10kUg wuPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hihonor.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b0051a6292309fsi3649788pgp.894.2023.05.06.01.09.57; Sat, 06 May 2023 01:10:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hihonor.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbjEFHuE convert rfc822-to-8bit (ORCPT + 99 others); Sat, 6 May 2023 03:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbjEFHuC (ORCPT ); Sat, 6 May 2023 03:50:02 -0400 X-Greylist: delayed 598 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 06 May 2023 00:50:00 PDT Received: from mta17.hihonor.com (mta17.hihonor.com [8.141.223.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD9B076A5 for ; Sat, 6 May 2023 00:50:00 -0700 (PDT) Received: from a003.hihonor.com (unknown [10.68.18.8]) by mta17.hihonor.com (SkyGuard) with ESMTPS id 4QCzlj45PyzCrrZ; Sat, 6 May 2023 15:32:17 +0800 (CST) Received: from a007.hihonor.com (10.68.22.31) by a003.hihonor.com (10.68.18.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Sat, 6 May 2023 15:33:34 +0800 Received: from a007.hihonor.com ([fe80::fc39:c25:3c0f:a4e7]) by a007.hihonor.com ([fe80::fc39:c25:3c0f:a4e7%10]) with mapi id 15.02.1118.021; Sat, 6 May 2023 15:33:34 +0800 From: gaoxu 00016977 To: "hch@lst.de" , "m.szyprowski@samsung.com" CC: "robin.murphy@arm.com" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "surenb@google.com" , yipengxiang 00013268 , wangbintian 00013160 , hanfeng 00012985 Subject: [PATCH] dma-remap: Use kvmalloc_array/kvfree for larger dma memory remap Thread-Topic: [PATCH] dma-remap: Use kvmalloc_array/kvfree for larger dma memory remap Thread-Index: Adl/7N1/zhRx438JTrqVRawCg6p65Q== Date: Sat, 6 May 2023 07:33:33 +0000 Message-ID: <18448ae569e24dfd84e811081ede376f@hihonor.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.164.11.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If dma_direct_alloc() alloc memory in size of 64MB, the inner function dma_common_contiguous_remap() will allocate 128KB memory by invoking the function kmalloc_array(). and the kmalloc_array seems to fail to try to allocate 128KB mem. work around by doing kvmalloc_array instead. Signed-off-by: Gao Xu --- kernel/dma/remap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c index b45266680..27596f3b4 100644 --- a/kernel/dma/remap.c +++ b/kernel/dma/remap.c @@ -43,13 +43,13 @@ void *dma_common_contiguous_remap(struct page *page, size_t size, void *vaddr; int i; - pages = kmalloc_array(count, sizeof(struct page *), GFP_KERNEL); + pages = kvmalloc_array(count, sizeof(struct page *), GFP_KERNEL); if (!pages) return NULL; for (i = 0; i < count; i++) pages[i] = nth_page(page, i); vaddr = vmap(pages, count, VM_DMA_COHERENT, prot); - kfree(pages); + kvfree(pages); return vaddr; } -- 2.17.1