Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f00f1a8-5f5a-44f2-088a-6f7d5c595d18@googlemail.com>
Date:   Sat, 6 May 2023 11:03:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: Linux 6.3.1
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net,
        jslaby@suse.cz
References: <2023050123-resubmit-silica-ac32@gregkh>
 <c2ac55a4-aaf5-2f49-be08-d326fe0c17f8@googlemail.com>
 <2023050202-slouchy-princess-e7dd@gregkh>
 <2023050225-brutishly-enlarging-c54e@gregkh>
 <2023050201-bluish-habitable-474a@gregkh>
 <c7842e46-fc41-c989-b5e7-ec504cd0c8f2@googlemail.com>
 <2023050612-failing-headset-0d9c@gregkh>
Content-Language: en-GB
From:   Chris Clayton <chris2553@googlemail.com>
In-Reply-To: <2023050612-failing-headset-0d9c@gregkh>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06/05/2023 01:52, Greg Kroah-Hartman wrote:
> On Tue, May 02, 2023 at 02:12:58PM +0100, Chris Clayton wrote:
>> Hi Greg
>>
>> On 02/05/2023 08:31, Greg Kroah-Hartman wrote:
>>> On Tue, May 02, 2023 at 08:43:47AM +0900, Greg Kroah-Hartman wrote:
>>>> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
>>>>> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
>>>>>> 6.3.1 FTBFS thusly:
>>>>>
>>>>> What is "FTBFS"?
>>>>>
>>>>>> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
>>>>>> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
>>>>>> [-Werror=format=]
>>>>>> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
>>>>>> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
>>>>>>   223 |                 func(&id, ##__VA_ARGS__);                       \
>>>>>>       |                             ^~~~~~~~~~~
>>>>>
>>>>> <snip>
>>>>>
>>>>>> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
>>>>>> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>>>>>
>>>>> Thanks for this report, we'll queue it up soon.
>>>>
>>>> Odd, that commit is in 6.2 already, so how are you applying this to
>>>> 6.3.y?
>>>
>>> And this is only a gcc13 issue, right?  So it's not a regression, it's
>>> always been there, nothing new caused it in this release from what I can
>>> tell.
>>>
>>> Actually I don't see how this is an issue in 6.3.1 anyway, as again, the
>>> proposed fix you gave is in 6.2, so what really is happening here?
>>
>> You seem not to have seen the email I sent shortly after my original report. In that email I apologised for the noise
>> because, due to a caffeine deficiency, I had reported the problem against the wrong kernel version and that it actually
>> occurs 6.1.27. gcc13 spits it out as a warning, but kernel build system is setbup to treat warnings as errors, so the
>> build fails.
> 
> Ok, but this is not a new issue, right?  6.1.26 should have had the same
> problem from what I can tell.
> 

I don't know. I haven't tried to build 6.1.26 with gcc13. The commit message for the patch in Linus' tree says that this
is a new warning in gcc13.  The kernel build system configures gcc to treat warnings as errors so, with gcc13, the build
failed and I reported the failure in the initial email of this thread. Looking at that patch submission
(https://lore.kernel.org/all/20221213225208.3343692-2-Jason@zx2c4.com/), it appears not to have been tagged for or
copied to stable.

Once I'd realised that I had reported the problem against the wrong kernel version, I sent my apologetic email and sent
a new email reporting the problem against 6.1.27. In response to that (I assume), you've queued the patch for 6.1 stable
and for 5.15 and 5.10, so everything seems to be in order.

Chris


> greg k-h