Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 6 May 2023 12:41:31 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     dario.binacchi@amarulasolutions.com, wg@grandegger.com,
        mkl@pengutronix.de, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] can: bxcan: Remove unnecessary print function dev_err()
Message-ID: <ZFYu2252kh19dMe2@corigine.com>
References: <20230506080725.68401-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230506080725.68401-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n5r6zc7xYZK9L7RvNqkrj9UjB7a/0/PaCr7EnNpY9M4NyagBzM+VYMg1mxIU?=
 =?us-ascii?Q?h/TxJv1684A8G0sOUDBXaC3Hc/nb2j3JDTi1Wt8Z7Cy/06vQTzkcPtY9SsS7?=
 =?us-ascii?Q?N9+RdqI1SjvqVy5bUMuwPw6HnLGZQebpJRwgU+BZNITFWeY6bPBQZTCLQZU9?=
 =?us-ascii?Q?ybPkrX5z8vEWvI6ztJqfrD7pcVXZ7rdqQ5Lg+4FtxEM+Qrr6Z7a0K8QTFjkm?=
 =?us-ascii?Q?qBAbdn0tDT+2gFUQimGzR1CvZayejEO9/agZlYIuaKj2juqVcmReTgH50ivl?=
 =?us-ascii?Q?+fYa26XmMQ5sdqOLd6DYxtMwL2sppvXnv1O85E6J4FdL74rH/koDyeL+WS6C?=
 =?us-ascii?Q?+IEpeRlFjMAF2v4R1A5CJnqUrdLwT8/NY65MQbXVwpygFroV+M5NKB4wY+Qc?=
 =?us-ascii?Q?mZQypLaiVxfEHpN8Z0xZcmReqJNXMeq9VQQjlhS7ntJP4pEkFynEHDggA2sn?=
 =?us-ascii?Q?ibiH9Q1b+sesqftlnITrAOVLkxrSIIG83h3J7ct7WoZv4zp38iYFCoiTXVt6?=
 =?us-ascii?Q?6oywrhVrl31E16nAfN8kkSHkT/xFzl6skjN1GeB3HD/Z1kLvqf8xdlMFa3CZ?=
 =?us-ascii?Q?yogYvRTyHUQM/502RJybeXBxko8rgx3EXVk5+h7EB4EYkEKSxQCiE7YURwlD?=
 =?us-ascii?Q?wiI5xV+AkN/Jd56t88fITZcu/Mq6af99N29GfMmwN3gZiLQV8udXOHyesvpa?=
 =?us-ascii?Q?/qqySl+d/AzoJb0a8lbR8JwT8H1DRsvQuG987mMznlGPzveCxDglujX6AJ5Z?=
 =?us-ascii?Q?GJMSlgUpLFyLjcvTlAySu9dAPDYijby7wx2BZG8FGSVmfEIsbKfsf8OMXPVo?=
 =?us-ascii?Q?HjJF2Nl9TWW/BN9wp2Rm1t7xvQwf0vlWVwRVwwiUNgDPFPkKzPm182lzp03I?=
 =?us-ascii?Q?o9nlHqT0WMrEpP48/t8zH8P7p9j4r3SUsDX7v4vXIPSAKX3fi9cdsC+jD44g?=
 =?us-ascii?Q?w49WbgSIKBabsqBeduEUCuvvvcLuwLfLRMp0qO/1LArHdfN+7AgM9o2p5n3i?=
 =?us-ascii?Q?A+rLDdzPNghUfj6EJ1Szi1i24cYbvq4KSASQrre2L9DC5l1EUQGSIht4C5yY?=
 =?us-ascii?Q?pnaE+3L3I+cT/+qg+5CdjbtOTkI50haKbaqkMpMbNSPOeJAgHSX5RpSYMaGE?=
 =?us-ascii?Q?S159xpX4ctMdN/YpZygFqaNfu4l0Im5S9p37LtfiF+WsAR/GCLP2TAE09R8K?=
 =?us-ascii?Q?LPmTA8H/nT6h9RhjNe8L/pKfKYsFwZEwWfE/o3r2UbnHPMhIf8GJSrgLajEM?=
 =?us-ascii?Q?3AztMerz6cjTpnlKmBNdlpv30olsxDwW1ikIUVlJyt7pMH0jc5fWzk+sXywF?=
 =?us-ascii?Q?46CG3Fc+knghp76ZCP3QvupyOIMovPa2lKalhFJ6xW5Y0bQwurAVc7+sgc8U?=
 =?us-ascii?Q?WGSMmWR4mqnVxhBGy6vWROR8LKX0frCU1F1MJMnaxxfOwtkI0G8T9JfQTRYY?=
 =?us-ascii?Q?RQfwddaZAHFs9fmQhUfl3hcRxuJbGlczhUI9iGLbcZ6jj0VvXhdonNtrRd+C?=
 =?us-ascii?Q?EgYXGfnk4BelRW8T8yidhEKq4g3HiRIMr36O2OcCMxGTQtYYYUVon1fl2YJx?=
 =?us-ascii?Q?0ZZY/iKmRcYL7j4pOPRCDbg5PONeTThDqEoSHdrOX1tMxhNHM82/LLQl8iDd?=
 =?us-ascii?Q?U5D7jME1MJaOWlv+C9apAT/n+zk7eOBtVutVSqYbq2sFUKNw11kkZ/D/dYK7?=
 =?us-ascii?Q?YuKq1A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aff87510-9f9b-4ee9-a058-08db4e1e7a03
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2023 10:41:41.0391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mBK1kxkS4BNJLTAvfSCDhCeGgmVtrcYKaV3cy8lf2KZCwTxqop2EJaykuGD/AsLuEvJXvjDBv/AU4KsPcQEWrDcadHVhvAma0/HZzJw+R4w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3793
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 06, 2023 at 04:07:25PM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> ./drivers/net/can/bxcan.c:970:2-9: line 970 is redundant because platform_get_irq() already prints an error.
> ./drivers/net/can/bxcan.c:964:2-9: line 964 is redundant because platform_get_irq() already prints an error.
> ./drivers/net/can/bxcan.c:958:2-9: line 958 is redundant because platform_get_irq() already prints an error.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4878
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>