Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 06 May 2023 17:30:31 +0000
To:     Dylan Van Assche <me@dylanvanassche.be>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] misc: fastrpc: use coherent pool for untranslated Compute Banks
Message-ID: <b5b3f7b4-3b08-d5cf-b1b9-795e9491166f@connolly.tech>
In-Reply-To: <20230327184204.498032-3-me@dylanvanassche.be>
References: <20230327184204.498032-1-me@dylanvanassche.be> <20230327184204.498032-3-me@dylanvanassche.be>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 27/03/2023 19:42, Dylan Van Assche wrote:
> Use fastrpc_remote_heap_alloc to allocate from the FastRPC device
> instead of the Compute Bank when the session ID is 0. This ensures
> that the allocation is inside the coherent DMA pool which is already
> accessible to the DSP. This is necessary to support FastRPC devices
> which do not have dedicated Compute Banks such as the SLPI on the SDM845.
> The latter uses an allocated CMA region instead of FastRPC Compute Banks.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  drivers/misc/fastrpc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index caf2ae556956..b7ddf6b90022 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -939,7 +939,10 @@ static int fastrpc_get_args(u32 kernel, struct fastr=
pc_invoke_ctx *ctx)
>
>  =09ctx->msg_sz =3D pkt_size;
>
> -=09err =3D fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +=09if (ctx->fl->sctx->sid)
> +=09=09err =3D fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf);
> +=09else
> +=09=09err =3D fastrpc_remote_heap_alloc(ctx->fl, dev, pkt_size, &ctx->bu=
f);
>  =09if (err)
>  =09=09return err;
>
> --
> 2.39.2
>

--
Kind Regards,
Caleb