Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3338ca49-61e7-b20e-f4f8-61b1531c3e81@amperemail.onmicrosoft.com>
Date:   Sun, 7 May 2023 15:31:22 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: [PATCH 4/4] ARM: dts: aspeed: mtmitchell: Add MCTP
Content-Language: en-US
To:     Andrew Jeffery <andrew@aj.id.au>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Joel Stanley <joel@jms.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20230425065715.21871-1-chanh@os.amperecomputing.com>
 <20230425065715.21871-5-chanh@os.amperecomputing.com>
 <f5c261ff-7901-434a-aa2f-3b2f684cb4a7@app.fastmail.com>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <f5c261ff-7901-434a-aa2f-3b2f684cb4a7@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkIzbmtLWllSV2ZxMUhsR1ZqYjBUOUZWd1QyZ3VVTEh2c2IxdnZUbjNicTdY?=
 =?utf-8?B?T0VnRlRmb0o1SkJXUW1aTDE2N2RleUNBWDhsS1NOb2JjckkzNzRjL09MSE10?=
 =?utf-8?B?WHpUU3RIaWN6NHFkY2ZrLzNKbUFwZHE3OHdaMHpFK0tkeEZVMW9JaHJpeGl0?=
 =?utf-8?B?d0JSYzN6dnNhOFZHSWhiTXpKSVBCTCtKSlJJL3B4TlJnQ0R6ZUU4dDlQMWkx?=
 =?utf-8?B?R25PME5qRGRpMzJ6eWFvL0F1SEp2MDAxMUJKVHkweWI5SHJCZWJkSzIzVXk5?=
 =?utf-8?B?WHpCeDU3OWRxMTNYa0U0WFlYY1VRV0ZyWXp2U1hBUWN5dTdMWTFxTjZaK1JD?=
 =?utf-8?B?bkNQUUxwR1hLUUpwNGpQZkhvUXJqeXhYZ3hvNDQ4MEpkSE4rMlpuSW02c1FR?=
 =?utf-8?B?NkhIellrQkdEbXp6a3REdHo3TzFtbjVtTStlczMrMnVLWmwxQ2FBbnNJNkVX?=
 =?utf-8?B?R2VFbmNIYWRlQlZPcTBJcmVmNGIzT2hPWVR6SFYvSVNaY0hQbHc1Q3FGbGpN?=
 =?utf-8?B?QVh4cDFhSnJHQ0FCQWd6QUxnRjRzQnpVKzFaRDdQS1ppMnZrN1NVNUZudjU1?=
 =?utf-8?B?YmtGR3FDYjcvZ0dMWUtUVnNJSkIzY1RvbDVmODl1N1J0K3dVVXgvQ3kyZDFk?=
 =?utf-8?B?aGhueGVjV2hhV2liTUFOalVESitNMGpjRnIzYmt1U01FZ1ZOVnBuZTRxT0Uv?=
 =?utf-8?B?SFR6WmlmUFlwRVdDd0JmOVBScEY2NDIxVUxPRVBsWmJwTGQ3YXUyZ3R0Vjh4?=
 =?utf-8?B?YjY2S1VhYjVTdEx0TmtHcjVRL2FMeFg4dmd6cjhEMHJac1IxVFI4Vko3MFIz?=
 =?utf-8?B?cDhhRWZON3dsSFJ1U1E1bkNyUHhlSEdQeHlrQ3ljUGNvOVFJeTFvdjhWZDNv?=
 =?utf-8?B?aEJwKzZrVlZ1aTIvRnNDZGpHNXNrbHZpZ2pYNk1BY0o2a3MyaGp5anVTU1J1?=
 =?utf-8?B?MFNLK0VXMC9BclpvUU9YQWhralVMU0dSMmpkNmN2MUJxenRtY3diUDlhb3lT?=
 =?utf-8?B?QkdYUTNwNnlEZFhMTnpvbXpqelVhNUxnN2tGN09ma2tpODFJdXBmVERveW9u?=
 =?utf-8?B?NU84Z0dRNDJYU2Npam5mbThXT2hYd2I3ZXdlNlVlRlNPV0ZzZ0pJc3RtWklJ?=
 =?utf-8?B?M0lNVHIrRHg2Tjljc0ZnZVBnZ0tNdzZuRTJNK1dvcXBjcDYyekFZVHBvaDVL?=
 =?utf-8?B?MkZKQmZtcEFCWU02aTZpck1JdGlHcEZ3ZmphcnpMMnJicVo1cGxVMTMyU3Jw?=
 =?utf-8?B?U3pzak1NbDJHL1F2ajJHaGgvSWdQeHZ5MHJrQm5jRUNPYkFCVnhXNXJCdGZi?=
 =?utf-8?B?Um5VMjZmUVlkUDE1UHVVZU1IQWhMVm96c1NvbSsvSTFodVUwSEVBN1NEUFRM?=
 =?utf-8?B?b2pUZExnaHVMazN3dVBuUUZvMllpR282amZxZnUwa0wzM2pTUUpMUnU0Q1da?=
 =?utf-8?B?aytvOWhpZFR1akxOSG5HWEZHbHBzZEZUbjVtOWVFR1lNbmk3eUVDV0tjL3Bt?=
 =?utf-8?B?cXg0dGlsUVdKMmQ3WUxUN2JRNHc2WUo3bUNlUnZWQjNYeC9Pazd4VVFrTGhO?=
 =?utf-8?B?TG1nSCtlTHEzZTU4dDNERDFCVDVIbHNZa1hkZ1h2NEZpZURneXdrSTJndzhm?=
 =?utf-8?B?MVVKZkNEVm1vSk5hS1BIOXFyRllmdGN5TnV4M3ljV3FBdmZGMTZIbEVCWjBY?=
 =?utf-8?B?c1ljL0NsQzdKVlMwbDdQaFhjT0FjUVRuSU9MTUNBbEhZTERiTXJsMEttazNP?=
 =?utf-8?B?K0hjaHY4YUFVcmtRQlU1dDh6c1ovTGx4aWo0Z041REZuSXBTYnJVaVJmam1u?=
 =?utf-8?B?TDJoTEtGZUpzeDhvUzNuT0JWODd6V2srK3hzdGxmSzNTV3FXTXorSjJqY1JI?=
 =?utf-8?B?R09NazVtRUt0Wk9NaXJVODZ2MFNnMTl3UU9aNTdhNEJxSjl2T2ZzNzF1UnhE?=
 =?utf-8?B?eDJYM1RVSGRVOFpUOGlUdHJhRHR5V3kwNzhHTnlqVlB0RHlES0N4RDBrbXoy?=
 =?utf-8?B?UE1GMExaTUNselFzK0NaTG55NzRYbWNnbXlwTXhpOVpsOWMwb3pWc05VbWpS?=
 =?utf-8?B?VDM2OTNiY2l1SzMvTmxZOHNpeFJSTFFPRWhQRERMVEMyaStGSkFpOFRLOUgy?=
 =?utf-8?B?MlRUbFY4ZVZ2YjBGRDVENVZJOWlNeG8zck5LZHdmRjhoenFKNE5Ic3pReVhy?=
 =?utf-8?Q?PVPb/xHqTnN+W1HL+8hQ8Dc=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33c06409-df8e-49b8-d35f-08db4ed5753e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2023 08:31:31.2470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gz2lVkC6SFC39V1gu7uKe+zAGATPG73nuE6D0NF608J16NrBVhuYeI2veKTQ6BzmCIU0rJBO/iwxOfcTiWVvXyROMTz7fUULTMf2Q7IGVVIX8MNNVSpmiKdyWDy0/Wr3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR01MB5758
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 27/04/2023 08:04, Andrew Jeffery wrote:
> 
> 
> On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote:
>> Enable MCTP driver on I2C3 bus for MCTP transaction
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> index 0b5ea8620063..33e06eafed31 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -366,6 +366,13 @@
>>
>>   &i2c3 {
>>   	status = "okay";
>> +	bus-frequency = <1000000>;
>> +	multi-master;
>> +	mctp-controller;
>> +	mctp@10 {
>> +		compatible = "mctp-i2c-controller";
>> +		reg = <0x10>;
> 
> This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;`
> 
> Andrew

Thank Andrew, I will update that in PATCH v2.