Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d230c413-fab0-50e7-20df-ff84e951f68b@amperemail.onmicrosoft.com>
Date:   Sun, 7 May 2023 16:39:01 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20230425065715.21871-1-chanh@os.amperecomputing.com>
 <20230425065715.21871-3-chanh@os.amperecomputing.com>
 <7ee3eec8-b5b4-2591-adcd-1831bf7de02b@linaro.org>
 <5d1cc7d5-2d73-c1a2-f95d-5810757640d2@amperemail.onmicrosoft.com>
 <969bfca0-9fff-0b22-6db1-113a7e998bc8@linaro.org>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <969bfca0-9fff-0b22-6db1-113a7e998bc8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3pCSGVYc1VvaEZHSTBvdHQ2V256aEh4bjhEc3AzTkthVkFZZGYweC9DdDhr?=
 =?utf-8?B?NWpXaCtwbHc4cUdsVGRuSHZYMVNCQ0tLU0xodHVZN3JCelNUdjcvSWtrR1dz?=
 =?utf-8?B?ZW1lVzF4aXpweVhkN3JIazJkakpmdE1BVER4V3lhZlphVXNXQ2dOQ0h5cHJs?=
 =?utf-8?B?cjlhc1VaMXRSOHprZlFpZkI3RmlVTGwwbm5xejhhSW01TXAxM1hnSGxIblVt?=
 =?utf-8?B?ZDNrWjQwb3Rhb1FBZ1NEZSs5WnBVV2VJcS9PbVYzVEc0eEpEUXVJWGpzNW05?=
 =?utf-8?B?aEpwMFBrNHV4WGR1QXZGbUlua3VWZ0w5bnNHN2VDZGg4ZWFDL0NYbXBNZlVs?=
 =?utf-8?B?di9DOVp3ejlqYjNxbmdMSWF2WlJYTFBGK2xPOEhLN3h0aEcvSWdwVDMwbjBW?=
 =?utf-8?B?WkZxQ1VoRGN0aFZ1Sk92dW5KWk1neU5qOVFDcHFOaWI5Z2pXR1Uva1hYUU45?=
 =?utf-8?B?bUlESlZRZkpJbmw0Q09NRzFHc1VlbGpmbnJmam10ZXJCZXUzN3pzUUVTU01S?=
 =?utf-8?B?SnZVdDV5TXFyTHFZWEUxbnZNYjFrUmEwMGRSby9ZemZkL0VudzgyUlJNODY2?=
 =?utf-8?B?SVFhTjZhL2l0cjV0a2tmckxGcmwxSUdRSGFsRldVdHliY2JiK0dJTlpTWXNJ?=
 =?utf-8?B?ZENGbHErVVdGQTRTSjV1T1lMemp3QVZWWEdaY3g4NUlNQWEvd0M0eEdjQ0hr?=
 =?utf-8?B?eUs1OXV5S0JUenZPenA3VlZERG83aml4WjIySGU4alRrL2RPZTMwajRZMENx?=
 =?utf-8?B?MnpjbXdsRFVZOXQrMjc4WmRzL01HTTVqY2NmQkI0dnNDTjd6ZTFpWHMrczlH?=
 =?utf-8?B?TkpkN093anNzWEVVbk0wSUZhcWpxbHk4QnFaazVnc0lzazRGMmpPZmRxUjBF?=
 =?utf-8?B?Qnc4a0R6OEZTZ1NkS3pGc0creC9MV2FIWGNBd3RhTXVZYUgrMGpWM0hEZ3ly?=
 =?utf-8?B?b3RKSkFrMEZ5Q1ZPTnZSMktWK2RIRWFKY2sreURlOEVnci9Kbm11aXo4Z3FU?=
 =?utf-8?B?cFRVQUdpRVpxd1YrOWpmZEF4Q0UxbDljQklnd0Yvd2F1VS9JdGx1QldTNVhs?=
 =?utf-8?B?MTRhSU41RjZrNjA3UnBPbjBIc3NyVmJndmorN1hKanB4ak1BSjZpS3pSOTZh?=
 =?utf-8?B?d21EYnVZTHpHN05QWUZRQy9NYUtGaE1CUWRkbHZvS0lNUmttbzRSSmJzYlNy?=
 =?utf-8?B?YWk4SDhQNUJyZUxpZTZXeGNOaFlJK0hFSFhGWUJsc3JIZlg0SjllMnh3M2tT?=
 =?utf-8?B?QUNqa1p4Wk0xOXFpMmY5OEJPR3FUWDdaN0s5dDFFclFWaFNGUUI0VW1RaGFw?=
 =?utf-8?B?NHpVSTlVVU9aeDBueTJCRzNBVUJLcmE2QzFyRDFMS24zbTg4NlJTVGk3bTlj?=
 =?utf-8?B?TThqZXN2VWNENy8yQ0JHYmhWZ09xZFhDU0IxRzFqN3lYUXBob0p6L1NkTk94?=
 =?utf-8?B?WHA3RFBHRmVTcnlSQ3Q5R21VNTRESEhsd1NGVjd1V3FtTERBL0ZuRG42V2JR?=
 =?utf-8?B?VVZaMEhYSEdtR1RWM0xjVFp0WG1BNU44THY4Zzc2YzFjcktrOHlDTm9aS0d5?=
 =?utf-8?B?SkZEb0h4MHJjK2RKZWQzdzBGTDUxZnE1d1NUaDNyWW81czJleEpHSHFPWXdi?=
 =?utf-8?B?cXE5QXNNRUp5UURNTzFSTmk1NmV2bnN1WGZLWWM2blp1MURMUWtnWE1zQkRC?=
 =?utf-8?B?L2d5ZDgrTVlrVmJ2OUx3bXBUcXZUZ0p2aU9xbHE5UXJGdVJHb1RTQ2IvNGxn?=
 =?utf-8?B?YVJBOFcvT1FMWEFxb09wdWM0WTFVNGc2YnBaVnQ0c3ZNellwZU5FcU9sRVVQ?=
 =?utf-8?B?dzE4UVIzM0ZIajRJV0xKK2RnaXJQRWJncjNYb0RYUTdycEZwMW54VFBxQ0ln?=
 =?utf-8?B?VG11amowMzZFR3N1RFJPYTNvd01wVkI0ZFJKQlVUWmJoNjN6c3NWRDdDV1ov?=
 =?utf-8?B?M0RGUHFuR09ZTTVyMitqdlpyUXBPeU1ndjVkSUdaRjZtNE96VDYzWG11Q0Nz?=
 =?utf-8?B?U1p0eFo3UUNUUWFYdElNMHVhM1cwS3VUL1VXUk8vZXhRS3RPaTNGbTg4R3Nv?=
 =?utf-8?B?Yjd3UjhmOU5DSmJndit5eEM4NjQ5OTRLWi8vbEk3RnUzQ1pNaWU2d3gxRG4w?=
 =?utf-8?B?c2VqZjRLa25XMFNtdDlVc0I3RlUwelIrSkQ4OWZYVUFWU2pCb0xFUGtqZnF6?=
 =?utf-8?Q?RNx6wxbbArojm7qIAD5wazY=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90216730-a736-4da7-3533-08db4edee914
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2023 09:39:10.6468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cvR4mJksRoGUKq57oXRBtatlZ/vQEBkOaGuMVDgedyMcvsICz7+xBZ9CMOaWpsp0kNI2qMI+O38qWTRnJxiQ8TejRj24/npo5Ook4ihu6HK5XsNsu21WzoDp3j26eNf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR01MB3988
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 07/05/2023 15:23, Krzysztof Kozlowski wrote:
> On 07/05/2023 10:20, Chanh Nguyen wrote:
>>
>> On 25/04/2023 20:15, Krzysztof Kozlowski wrote:
>>> On 25/04/2023 08:57, Chanh Nguyen wrote:
>>>> Add the MAX31790 node as a Fan I2C controller. It controls the
>>>> TACH and PWM for Fan Mt.Mitchell system.
>>>>
>>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>>> ---
>>>>    arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 12 ++++++++++++
>>>>    1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>>>> index e79f56208b89..6455cf80da0e 100644
>>>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>>>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>>>> @@ -477,6 +477,18 @@
>>>>    			line-name = "bmc-ocp0-en-n";
>>>>    		};
>>>>    	};
>>>> +
>>>> +	max31790@20 {
>>>
>>> Node names should be generic.
>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> Thank Krzysztof,
>>
>> I think these node names should be "fan-i2c-0" and "fan-i2c-1". Do you
>> have any other idea ?
> 
> i2c-0 is not generic. This should be either fan or fan-controller,
> depending what this is.

Thank Krzysztof! I will update node name is "fan-controller" in PATCH v2.

>>
>>>
>>>> +		compatible = "maxim,max31790";
>>>
>>> Unfortunately the compatible is undocumented.
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Yes Krzysztof,
>>
>> This compatible has not yes documented.
>>
>> Should I push a document for max31790 to
>> ./Documentation/devicetree/bindings/ or ask to maintainer (Guenter Roeck
>> <linux@roeck-us.net> or Jean Delvare <jdelvare@suse.com>) ?
> 
> Check on lore.kernel.org if there is ongoing work. If there is no, then
> please submit new the bindings (in DT schema). Maintainers are not for
> writing your code, so it's you or some other developer who should do it.
> 
> Best regards,
> Krzysztof
> 

Thank Krzysztof!

I checked on lore.kernel.org but no submit is in-progress for that. I'll 
submit new the binding document for max31790.

Now, Do I need to remove the "[PATCH 2/4] ARM: dts: aspeed: mtmitchell: 
Add I2C Fan" from PATCH v2?

And will push again "ARM: dts: aspeed: mtmitchell: Add I2C Fan" commit 
once max31790 binding document was available upstream.