Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202305061711417142802@zte.com.cn>
In-Reply-To: <202305061711417142802@zte.com.cn>
From:   Anup Patel <anup@brainfault.org>
Date:   Sun, 7 May 2023 21:09:57 +0530
Message-ID: <CAAhSdy0xBiyXz903xmK4e4n4tknjW4aBTjuGe4-v1xat5hqFmA@mail.gmail.com>
Subject: Re: [PATCH] riscv: mm: use bitmap_zero() API
To:     ye.xingchen@zte.com.cn
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, guoren@kernel.org,
        sergey.matyukevich@syntacore.com, dylan@andestech.com,
        ajones@ventanamicro.com, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, May 6, 2023 at 2:42=E2=80=AFPM <ye.xingchen@zte.com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> bitmap_zero() is faster than bitmap_clear(), so use bitmap_zero()
> instead of bitmap_clear().
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>

Looks good to me.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  arch/riscv/mm/context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c
> index 12e22e7330e7..217fd4de6134 100644
> --- a/arch/riscv/mm/context.c
> +++ b/arch/riscv/mm/context.c
> @@ -67,7 +67,7 @@ static void __flush_context(void)
>         lockdep_assert_held(&context_lock);
>
>         /* Update the list of reserved ASIDs and the ASID bitmap. */
> -       bitmap_clear(context_asid_map, 0, num_asids);
> +       bitmap_zero(context_asid_map, num_asids);
>
>         /* Mark already active ASIDs as used */
>         for_each_possible_cpu(i) {
> --
> 2.25.1