Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Inki Dae'" <inki.dae@samsung.com>,
        "'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
        "'Kyungmin Park'" <kyungmin.park@samsung.com>,
        "'David Airlie'" <airlied@gmail.com>,
        "'Daniel Vetter'" <daniel@ffwll.ch>,
        "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
        <dri-devel@lists.freedesktop.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20230507144753.192959-1-krzysztof.kozlowski@linaro.org>
Subject: RE: [PATCH] drm/exynos: g2d: staticize stubs in header
Date:   Sun, 7 May 2023 22:05:45 +0530
Message-ID: <004001d98101$fa5ed690$ef1c83b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHMQF+KV7mnVACdrNHe1vibu+C8KwKtLaCmr1QYABA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20230507144800epcas5p219717e5bf06b91772ee877c8dcee0940@epcas5p2.samsung.com>
        <20230507144753.192959-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: Sunday, May 7, 2023 8:18 PM
> To: Inki Dae <inki.dae=40samsung.com>; Seung-Woo Kim
> <sw0312.kim=40samsung.com>; Kyungmin Park
> <kyungmin.park=40samsung.com>; David Airlie <airlied=40gmail.com>; Daniel
> Vetter <daniel=40ffwll.ch>; Krzysztof Kozlowski
> <krzysztof.kozlowski=40linaro.org>; Alim Akhtar <alim.akhtar=40samsung.co=
m>;
> Marek Szyprowski <m.szyprowski=40samsung.com>; dri-
> devel=40lists.freedesktop.org; linux-arm-kernel=40lists.infradead.org; li=
nux-
> samsung-soc=40vger.kernel.org; linux-kernel=40vger.kernel.org
> Subject: =5BPATCH=5D drm/exynos: g2d: staticize stubs in header
>=20
> Stubs for =21CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:
>=20
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous
> prototype for =E2=80=98g2d_open=E2=80=99=20=5B-Wmissing-prototypes=5D=0D=
=0A>=20=20=20drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6:=20warning:=20no=
=20previous=0D=0A>=20prototype=20for=20=E2=80=98g2d_close=E2=80=99=20=5B-Wm=
issing-prototypes=5D=0D=0A>=20=0D=0A>=20Fixes:=20eb4d9796fa34=20(=22drm/exy=
nos:=20g2d:=20Convert=20to=20driver=20component=20API=22)=0D=0A>=20Signed-o=
ff-by:=20Krzysztof=20Kozlowski=20<krzysztof.kozlowski=40linaro.org>=0D=0A>=
=20---=0D=0A=0D=0AReviewed-by:=20Alim=20Akhtar=20<alim.akhtar=40samsung.com=
>=0D=0A=0D=0A=0D=0A>=20=20drivers/gpu/drm/exynos/exynos_drm_g2d.h=20=7C=204=
=20++--=0D=0A>=20=201=20file=20changed,=202=20insertions(+),=202=20deletion=
s(-)=0D=0A>=20=0D=0A>=20diff=20--git=20a/drivers/gpu/drm/exynos/exynos_drm_=
g2d.h=0D=0A>=20b/drivers/gpu/drm/exynos/exynos_drm_g2d.h=0D=0A>=20index=207=
4ea3c26dead..1a5ae781b56c=20100644=0D=0A>=20---=20a/drivers/gpu/drm/exynos/=
exynos_drm_g2d.h=0D=0A>=20+++=20b/drivers/gpu/drm/exynos/exynos_drm_g2d.h=
=0D=0A>=20=40=40=20-34,11=20+34,11=20=40=40=20static=20inline=20int=20exyno=
s_g2d_exec_ioctl(struct=0D=0A>=20drm_device=20*dev,=20void=20*data,=0D=0A>=
=20=20=09return=20-ENODEV;=0D=0A>=20=20=7D=0D=0A>=20=0D=0A>=20-int=20g2d_op=
en(struct=20drm_device=20*drm_dev,=20struct=20drm_file=20*file)=0D=0A>=20+s=
tatic=20inline=20int=20g2d_open(struct=20drm_device=20*drm_dev,=20struct=20=
drm_file=20*file)=0D=0A>=20=20=7B=0D=0A>=20=20=09return=200;=0D=0A>=20=20=
=7D=0D=0A>=20=0D=0A>=20-void=20g2d_close(struct=20drm_device=20*drm_dev,=20=
struct=20drm_file=20*file)=0D=0A>=20+static=20inline=20void=20g2d_close(str=
uct=20drm_device=20*drm_dev,=20struct=20drm_file=20*file)=0D=0A>=20=20=7B=
=20=7D=0D=0A>=20=20=23endif=0D=0A>=20--=0D=0A>=202.34.1=0D=0A=0D=0A=0D=0A