Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size
 requirement
Thread-Topic: [PATCH blktests v3 08/12] nvme/rc: Add minimal test image size
 requirement
Thread-Index: AQHZgTpeCZWoBgP2s0yv5rZuYXq2bw==
Date:   Sun, 7 May 2023 23:19:28 +0000
Message-ID: <oxvbdtehbmna3uiz5lifjrzekohdjw4wsrh3ydn4yhtleqbpa4@xxvgmggzq25y>
References: <20230503080258.14525-1-dwagner@suse.de>
 <20230503080258.14525-9-dwagner@suse.de>
In-Reply-To: <20230503080258.14525-9-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bdWVeM/rw0Wl9TRKjG4gBGkzM55fMHJTYEjRpuIEiA1B/+tBr7UMhB3Cp0Tz?=
 =?us-ascii?Q?1b3CgYXRPcJ/rgr3s2d9CC4y+a8PUDs3saQY3bHDaTR8Nf+9Dcrq6LBmetXH?=
 =?us-ascii?Q?RC5zE1pISt1T09jF111iMcwIiqV86/nEYSBih2yJLJv8lt9rdE1BFB6unST8?=
 =?us-ascii?Q?CVLnKiNYO9k5u5RjNq6XCrB2xqgq8M/JXvYyPhwDo7QMyE0nZnFus11TManl?=
 =?us-ascii?Q?EESFOgjr5vfdHhbOrfOLeJKdzz+wHyZCdJh+8wZFw+oxsMV4KX5iOJRB+/Dz?=
 =?us-ascii?Q?/Zlo+YGwDFVVpyDfgLlz8fu09khlBKcwagc/TNTqdt+KrL2JagOoDJ/9j3cG?=
 =?us-ascii?Q?AEPFJO3Z87JWSrRnbl1tmqzkMTKG8u9NmAKp4szpcBoET+VxpSn+cGIrVHjc?=
 =?us-ascii?Q?UqFysg+UJHAWlt9nQccxkMKenhomVdlJSPgk6T9jrFQI3Q3qhuaOmWE04zbC?=
 =?us-ascii?Q?fJy9nRQ+iCPMuFDNoZqCi+141GONT6a1whJQcs5i9eXBSJ5uzSC67fMOpIxB?=
 =?us-ascii?Q?EyBy9bP0prwY3zgJUMJVh0H/MDQiIT9aOu9AaRRMAr0MXdSCIC8tXPf0KvRs?=
 =?us-ascii?Q?3oQTDwPAbl2veoiJKswo+h9b9saD3jll6N33ODWjY5CEcOiZ38miiuWqd1Hv?=
 =?us-ascii?Q?nUiC/Dd0g7YPv862cfoGLZZEBeut9EJ1LTu3h5QBFkrHRvIbdh3a18mSZcL7?=
 =?us-ascii?Q?5q0c6+hoVJK7LvAuGjCz6Z9R4RD21eIEjKvTj9LuR0mi7xSCYsQ0F2U1H9um?=
 =?us-ascii?Q?6PWHGzw1zedBnxVbXbwGqjrDezjb8bqmWzPVyX8AKogP7OK6l0dgm6sS3KsJ?=
 =?us-ascii?Q?Wh+aLw7p/bi8rHPEhTLL8+dnh+aDX9aa/suAe4aA4b2EMoO8o0JdBZvCi769?=
 =?us-ascii?Q?2CBl76iZzW6RqqGMJ8691XEetEa7+kzQ+E92hXc6EMm9NI5VQCCU5KQuHCYU?=
 =?us-ascii?Q?jYYwGL0rhJeMOcX45R/ZqYY8IlZhyWthi14TdsmnMqCrthloh0szz5WOGTSt?=
 =?us-ascii?Q?G9vsV/PWeFoXpnaQ81WDroR6pLnFwjnDRJgz6R7GOD3FZDUEiJ5Bkp8ojlP7?=
 =?us-ascii?Q?z1h7KR1nfj2ynfPOcSGmMboBY7sA+ZS8kQcKGjsEP3xt7UwO9eztSiA8tDv/?=
 =?us-ascii?Q?EAEKxtTbV05qvAyDyKnNEGnc9r8fjDCoO7nuwCFbF6sT6RzH1uJmVh/QK8ZB?=
 =?us-ascii?Q?ZhpJWcvTOP8MbaZH5GPp3OHuUsQ1OLTqSHKbVRLTT3myABzHgS3QL627F9sZ?=
 =?us-ascii?Q?L+QUv785Rv6SFKYCbGWoy7G8LNV2Y1MSUpfqooG/Q+bcKr18/LMV1JQzMgbg?=
 =?us-ascii?Q?vWrMuLhhTlYaMpxj9sgSn0kS64IBPL1uhuCWFTHV+pSmBybbs6y9x1w0W5LD?=
 =?us-ascii?Q?9dkLdlFbQn+2C4RBDkV8S0HCE7yozWJxzasmShWJXxY5g1f4k7RtF6dHyeoP?=
 =?us-ascii?Q?4uCtRmPsMV1+P6WANbEjTQLyptwXsE0LjV04MRljsuS+6l3TAjccwmwpTz3f?=
 =?us-ascii?Q?CqJ4+cphNz2CMht5jCECQCgGrMOteGpK4xGEhkJB8ta+FGP5pBEPWUw9RThX?=
 =?us-ascii?Q?YSYX6c9qOfsjMEljd7ZjtYXc6VmnYfRe1tlLIEAtZH8+XeeWHNrOYQ9T4kH4?=
 =?us-ascii?Q?alVmh9YKPIoWBIxRRu4gFq8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4D62B1E459CDA649921C5D41C9577D3F@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uuOT0su9iftja+LYNcvy1PN7twUWa9uN8RIGLbjmCYOcGFCMkzOPJkfFOuWjhnAvLt9RIg0Wrm2sK4hFkDo2dwiHa+ffm0MQU0vUxSMWSuTg9of4+QTvtu/j3iTOmmD2c7pwPMsKCtvbpcFSKeekd7gPB/+TA/HvXH9ftiDhlqAazImtgN4OPR4UkUVfUqnncW7QWP3P/Qdqq6LyISJ4dSQI25fh7DspkRgPLeBdXOr74Gj8r1zQgvcd+pWv+YrFx1a3CTlYXqMxVHVDacM17oHJMszx/dsYRHOne/JXc8YY0UKSINhyCM8IeUpvB+SEAjUYm2WezCDck8LHNIRnwMevrW53iQf8YMNsIpKwkHdaMRri0sRn0UMIIkNVHKOiT+rBoXXk6N87NgfgnELbJKYRn5qBPGCIU9tHFLYakfcMrn9OmxxzQekTfi4V8DRH7VUsVFIicLlafN9C6aQpEUw222jSv9SiV8ENQmrZtVzJDq1VW9Dj3XSarlI71b1R0vq8d+QKstdovA3mVPcIL5xyVw97uckHzwMESWXoVCSLR9b/d9G0OSjoDbSKvaVyAzPKEaoJ7P3+V4PKRCENOJcb7FWWrzNbndLhExUy4ie4CO8Yy6KcfKfEUSdA7DUk47PttAEGu4b7XatnUN6vSMcbc5eQm4gUVNAMRLThvPUD2J5AUCIiLsWHJgUmNX6Furovu6RaIbSHUxyEcfWtm4d2bVYfgBOcx5PaSlmK4w7OLkx9U05aBQZzlznhApcS7vYLShwE4WeBzYH3Xpw5KL4oRgCGby0VXQjXMyHgKy5292kLgw2rlHnTS8juKWgAe2vhVikQcI0oAVCfzR3OlE4ykyL+++0pI9om7wjwDeiR4Gb4/9UjJYm1r9iNbggA5t18+RAaIiv8hlmb0tRs8HE9mhPl8UITJz2vn5+bnwU=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2844185f-dfc1-47ea-cec0-08db4f518170
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 23:19:28.5267
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H6VSC3GxWztUU7CyRhgCCiEUEObsqRC493SikwIrrwMiT9upmwRLfuqC7daKE1E0lOCsQFaChJTQ5IkhJw43QWFKlDSV0C7+uSdwf4+URaw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6703
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Nit: the commit title subject can be "nvme: " since it touches both nvme/rc=
 and
nvme test cases.

On May 03, 2023 / 10:02, Daniel Wagner wrote:
> Some tests need a minimal test image size to work correctly. Thus add a
> helper to check the size and update these tests accordingly.
>=20
> The image minimum is 4M because some of the test have hard coded values.
> All tests which use the xfs fio verification job have a minimum
> requirement of 350M impossed by the xfs filesystem.
>=20
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  tests/nvme/012 |  1 +
>  tests/nvme/013 |  1 +
>  tests/nvme/029 |  1 -
>  tests/nvme/045 |  2 +-
>  tests/nvme/rc  | 15 +++++++++++++++
>  5 files changed, 18 insertions(+), 2 deletions(-)
>=20
> diff --git a/tests/nvme/012 b/tests/nvme/012
> index ecf44fcb5a51..efe227538c57 100755
> --- a/tests/nvme/012
> +++ b/tests/nvme/012
> @@ -16,6 +16,7 @@ requires() {
>  	_have_fio
>  	_have_loop
>  	_require_nvme_trtype_is_fabrics
> +	_require_nvme_test_img_size 350m
>  }
> =20
>  test() {
> diff --git a/tests/nvme/013 b/tests/nvme/013
> index e249add46295..14e646a19c47 100755
> --- a/tests/nvme/013
> +++ b/tests/nvme/013
> @@ -15,6 +15,7 @@ requires() {
>  	_have_xfs
>  	_have_fio
>  	_require_nvme_trtype_is_fabrics
> +	_require_nvme_test_img_size 350m
>  }
> =20
>  test() {
> diff --git a/tests/nvme/029 b/tests/nvme/029
> index 1808b7b0edf1..c6d38b42af70 100755
> --- a/tests/nvme/029
> +++ b/tests/nvme/029
> @@ -14,7 +14,6 @@ requires() {
>  	_nvme_requires
>  	_have_loop
>  	_require_nvme_trtype_is_fabrics
> -	_require_test_dev_size 1M

As I mentioned for the previous patch, this line was added and removed.

>  }
> =20
>  test_user_io()
> diff --git a/tests/nvme/045 b/tests/nvme/045
> index 7c51da27b5f1..99012f6bed8f 100755
> --- a/tests/nvme/045
> +++ b/tests/nvme/045
> @@ -120,7 +120,7 @@ test() {
> =20
>  	nvmedev=3D$(_find_nvme_dev "${subsys_name}")
> =20
> -	_run_fio_rand_io --size=3D8m --filename=3D"/dev/${nvmedev}n1"
> +	_run_fio_rand_io --size=3D4m --filename=3D"/dev/${nvmedev}n1"
> =20
>  	_nvme_disconnect_subsys "${subsys_name}"
> =20
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 51dde39c2966..0b4d5f6570d6 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -21,6 +21,7 @@ nvme_img_size=3D${nvme_img_size:-"1G"}
> =20
>  _nvme_requires() {
>  	_have_program nvme
> +	_require_nvme_test_img_size 4m
>  	case ${nvme_trtype} in
>  	loop)
>  		_have_driver nvme-loop
> @@ -94,6 +95,20 @@ _require_test_dev_is_nvme() {
>  	return 0
>  }
> =20
> +_require_nvme_test_img_size() {
> +	local require_sz_mb
> +	local nvme_img_size_mb
> +
> +	require_sz_mb=3D"$(convert_to_mb "$1")"
> +	nvme_img_size_mb=3D"$(convert_to_mb "${nvme_img_size}")"
> +
> +	if (( "${nvme_img_size_mb}" < "$require_sz_mb" )); then

FYI, in bash arithmetic operation (( )), we don't need to add "${}" for
variables. Code below should work.

	if ((nvme_img_size_mb < require_sz_mb)); then

> +		SKIP_REASONS+=3D("nvme_img_size must be at least ${require_sz_mb}m")
> +		return 1
> +	fi
> +	return 0
> +}
> +
>  _require_nvme_trtype() {
>  	local trtype
>  	for trtype in "$@"; do
> --=20
> 2.40.0
> =