Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs
Thread-Topic: [PATCH blktests v3 05/12] nvme: Use runtime fio background jobs
Thread-Index: AQHZgTcpBaWOIz93fkSAayVQIvsI1A==
Date:   Sun, 7 May 2023 22:56:31 +0000
Message-ID: <ka6mem7j3psreez3ey3auyupelicekyaxj3mttofdjf43o34oq@fzqe3arzbbl2>
References: <20230503080258.14525-1-dwagner@suse.de>
 <20230503080258.14525-6-dwagner@suse.de>
In-Reply-To: <20230503080258.14525-6-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9eYi1SvVGzMnyryUCPGa4HvtfW6K4KRDQWY1ACJdhJAABJqSBbogCqvgWkXR?=
 =?us-ascii?Q?ui1hRIqC970kXQrCmkpqbZ+T9XH2juDK2gC8W6loiw6MBu03FJbTJGnI2Nfb?=
 =?us-ascii?Q?Cu+sNb2k3J5vmiYPk1noUgqWbhWiTnwhF4YyfjO+K2YHykIYA89FEG8EEt64?=
 =?us-ascii?Q?9Ae/wTPiOABKGMYuo/u8Lofg7S4f+9pnnR3LOEtZeGv81JN4yvItCw9EhAmO?=
 =?us-ascii?Q?0zXLjmfOAGbaaGuBBwxaW/9wg7E4r2tjBSqEj9gZDYqfIyHm1jw2n742Y6UN?=
 =?us-ascii?Q?Wa4izWXvKER1QWgXkItotbJwY3ao9PpnhRGiig7cpno5Qb1Ixp+CpdlqrpMz?=
 =?us-ascii?Q?3ro0dPTkfKG3vsyUaaVH9fi0LdcmHn7adhcdfUZSP71sL6UgE36it2vn8mjC?=
 =?us-ascii?Q?Prmi/QyJB5Z+wqpD8or6fDh+vHih2GTBUT6NbJSxM0S9AAD1ybXhXv28eadK?=
 =?us-ascii?Q?AEOIoviVYwoylH8WuD9xkQworO5v5GmPq6H8Cc0bfMPhdmaFpYY4u6FrcTyw?=
 =?us-ascii?Q?6RSJChpmXypyne0U6xRdlFbZjXT9tZZKu0HBBKZ6sHCYgf/bXXf97Zn0MgbW?=
 =?us-ascii?Q?0MwnXozEMLAsahjhLSs9bomylRSTXlMS3hDHGAB/b+iCdanK8BPne9CzHIRf?=
 =?us-ascii?Q?ig62GQlIrWNLBLKhlpCVQXIBH6HAfe2LqArvjCNiQSchsDHG9OizwNNwG0Eu?=
 =?us-ascii?Q?RGxZC2uVesr9HMuoMC0x8IdXt4hMxYfN3CN/eZlVZOrFCbnmsLegOV1hj9KE?=
 =?us-ascii?Q?aNu8fW0Vk4jX0RLxWaTu8jySs8P74wYvK/uMBEsGGN+4Aks70E05f4iDTgQt?=
 =?us-ascii?Q?N0rICquFGzXN+6bL4HFo7ZA+xb6OMUUV8V4GDX7yoaCmkXbZ6PuNnCZnn7Xj?=
 =?us-ascii?Q?eYqjfvxjmPLI6EwKPdifr8wMtfFG3wTAMr93nfTXYytZjUeukpJhAh8K6TIU?=
 =?us-ascii?Q?FmMgmL1tuGkQr3/1rAXpNpfBemO6qIP/hd/5JPW7oExJh6UuzetnTtZDfjZK?=
 =?us-ascii?Q?kBKwNTveGyd8zFABRZ2RTUC2/uBpc0AgHutygI7prH4hQMXsNdRb6yGjaaib?=
 =?us-ascii?Q?2h+AX990vOHy/pz3ZQ96pH4INCiJ/wvj2i+BurCh3c3n9d5qwIflmvg16hES?=
 =?us-ascii?Q?b5LkA5bBOcBbeJCuu569ll3VSetnW+JR0NhAruqgKD3/N3TH+OSM0cRMKV1t?=
 =?us-ascii?Q?7DxparVqAzpxWTyvmbGrRptDWWLv620OZRhYJ+vZ7uQfVX/aphhMc3KDBZEL?=
 =?us-ascii?Q?jO0yF5P7E3zSsXbXjgPqA8zVvu5+Bbyn4FyyT3GOU9CwTUagJkCIG3mT8QOy?=
 =?us-ascii?Q?d9DeFIDcP91leaBdUCCF5jmlavOj0fI68An3GQS2Dmc2TBPV8+FaCKuqbpLw?=
 =?us-ascii?Q?ubJSRmhgiJcghVa5kfsfEiiuwKSg1YY4OzgVoP+pi9ze8nE0n9UjTC4IlFzV?=
 =?us-ascii?Q?rW4mDGuKGinfTVbsSR585d+rTC4vi/wneDp1EeUqVMligcTdw7SyvBGyr9PA?=
 =?us-ascii?Q?nMqh54r5g44o7ZfitPt6xV/KSmaL81q00OITIcAfk3F9VICk5XyaTIk5ZJZJ?=
 =?us-ascii?Q?13It0xHLspOjhlDfWHSJDzaH7E/S14ws1TUOBTxgzDDtPrF22R4WGuJhG35K?=
 =?us-ascii?Q?gsKT4KuK6XkV1vEGMsnDmps=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F00702BCDEC4DB438CD6B18107D3DBCE@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4lELx83hLV61hWacirL4kvolkh+EVOGw2NZOdlohX4ygmQGHWOqcES63Ia69B6cdqQwAE2mmlnIGpdoWyCgvdPRgnxTVBl3jfq0pJoRJZ4dO7sHWi0o+bm38pXX+UPN9vpSKpoHdHRCUaJsrvYyXJJb1fLeA0EiDJt+eynyYjkALu5Kj8QaB4ySVJWV8cJTeWeMDOR9KmirfjkTRgI69dA78cCYEacuDukdzNY4cz3hXNd21GjUbXxovcMeQwJTW77JWAWJrzy71r9y6cRBA4rPAsvhd0Y5iCteURbUDPxUNgkkl/q/zF/du2A2jD3WXLlZ0dAClGjT3DQY0/jhWusT59W0YWQzmNaInU5ZduBtjJnssoayfn+K988YQ8B7zXGVSbm5x+LXohkEw9eLprPc24pFloYL8dsWOAmLGavWGb/nYscwYGDdLlqOlvD16c3LuDgRQuL1w0dMOM4AkrvM5zcsL8c4W+VCRmYCTPwAOHtWM1Gr6WJEUTMsR/k+PdLcrr2tSxlqF1MnZ6p+C4t9l5uAogixV/5+ABVHaIvpK1QYK4/9VzsP2ReeVnGCnrXRAi1Qs9AX2D+c13ULhWfq+xOFcx7AQyiKiovRDDHCTx7MTnDK17SOYYmUNsNyh1v1cG2gBwankXH6tNM/HmtNDBLQOSVayc3Puq+AhFovwOYd/jz8Z/QR1kiT7A+dCiSzWgSKf3USDQsNBg3vkhCB5Amc0wwXtknWOZow2wOnDxM3j6ZO9tUsJeBAr1eMooEAliz6TglsuuEcQpJ+R/9tsnZDnvyeAnbVFuUjulq6MTBDTdbwLsG6khLACaICXCgTb25my8+yZUqaOXhpXja/IhAlPxKalnoTDvj+I9ZJ7sUKhdAX9wxx64A7W2tvjq1YI9bV62kLE4PsMAiZeizanME7SV775qw02spKCGYA=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb83be37-0399-4bcc-dd23-08db4f4e4c88
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2023 22:56:31.2700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j3UnrR9AiJIQdL/C9UgZc9NFJgYf/gMeD8Sp4q3k79bt3qtUHAfMCMUgY0XnGgtnpVPSzriT9OP9D5X2ggHYkeJ/sPSNMWHBlInAPztj4gk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB7068
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 03, 2023 / 10:02, Daniel Wagner wrote:
> The fio jobs are supposed to run long in background during the test.
> Instead relying on a job size use explicit runtime for this.
>=20
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>  tests/nvme/032 | 4 ++--
>  tests/nvme/040 | 9 +++++++--

Nit: I suggest "nvme/{032,040}" as the commit title prefix.

>  2 files changed, 9 insertions(+), 4 deletions(-)
>=20
> diff --git a/tests/nvme/032 b/tests/nvme/032
> index 017d4a339971..2e4b7f0760c7 100755
> --- a/tests/nvme/032
> +++ b/tests/nvme/032
> @@ -38,8 +38,8 @@ test_device() {
>  	sysfs=3D"/sys/bus/pci/devices/${pdev}"
> =20
>  	# start fio job
> -	_run_fio_rand_io --filename=3D"$TEST_DEV" --size=3D1g \
> -		--group_reporting  &> /dev/null &
> +	_run_fio_rand_io --filename=3D"$TEST_DEV" \
> +		--group_reporting --time_based --runtime=3D-1 &> /dev/null &

Nit: I checked fio man page, and did not find meaning of negative value for=
 the
--runtime option. I also checked fio code, it looks that -1 is handled as
ULONG_MAX by type cast from singed long long to unsigned long long. Assumin=
g
such negative values for the options are not well defined, --runtime=3D1d o=
r
--runtime=3D365d would be the better to mean 'infinite runtime'.

> =20
>  	sleep 5
> =20
> diff --git a/tests/nvme/040 b/tests/nvme/040
> index 04bd726cd309..05b4f5472ef5 100755
> --- a/tests/nvme/040
> +++ b/tests/nvme/040
> @@ -21,6 +21,7 @@ test() {
>  	local port
>  	local loop_dev
>  	local nvmedev
> +	local fio_pid
> =20
>  	echo "Running ${TEST_NAME}"
> =20
> @@ -37,8 +38,10 @@ test() {
> =20
>  	# start fio job
>  	echo "starting background fio"
> -	_run_fio_rand_io --filename=3D"/dev/${nvmedev}n1" --size=3D1g \
> -		--group_reporting --ramp_time=3D5  &> /dev/null &
> +	_run_fio_rand_io --filename=3D"/dev/${nvmedev}n1" \
> +		--group_reporting --ramp_time=3D5 \
> +		--time_based --runtime=3D-1 &> /dev/null &

Same as above.

> +	fio_pid=3D$!
>  	sleep 5
> =20
>  	# do reset/remove operation
> @@ -48,6 +51,8 @@ test() {
>  	echo "deleting controller"
>  	_nvme_delete_ctrl "${nvmedev}"
> =20
> +	{ kill "${fio_pid}"; wait; } &> /dev/null
> +
>  	_remove_nvmet_subsystem_from_port "${port}" "${subsys}"
>  	_remove_nvmet_subsystem "${subsys}"
>  	_remove_nvmet_port "${port}"
> --=20
> 2.40.0
> =