Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp3845621rwr; Sun, 7 May 2023 21:43:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6SC97zgUmO0UbuCDtO/nJdUPC1qeL3uOoKBBnkRpvujru3JrWEf1evwzYuEczr3gHM8Jem X-Received: by 2002:a17:90b:4c4f:b0:246:85ec:d816 with SMTP id np15-20020a17090b4c4f00b0024685ecd816mr9503445pjb.3.1683521014410; Sun, 07 May 2023 21:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683521014; cv=none; d=google.com; s=arc-20160816; b=UsZkVxNfJe6iZmA52UfFq1tAAFDmcNB6WJ5H8B0vIA7SQCpnS6sWH3P+t4nZw5EcUq oPvwTrH+PRjlDZpPeXwQF7d8XgY9ye50NjR6WNQkM5bhVdVpY8vuhIaqsfTwpGXndVrU mvqbnWPvLiqSr/EmjWIN9RHdwHYpS6QTQ++W0vzsL2CXUkHkAZ+ojb4GZ2cUFhlcOpBk emcw5ycFC0hh3NlfraxXB22mx9/YIbR8k/Bv0slslc4UM1499bRZfd9/jL7DEW/AbdFh B/cHkCdiV8XPlD0lcPmcACwI/5YnqfcEI9IKfvLp3kcRBoq7oDIYD4etwX1cXNv+r24t v9Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xM9aJ3QMYI2jjSHFnPeXdxLTxmpqEH4m6OdKBd6a4jw=; b=cytXxCvyJFBW+5hAj76BQ7AJaNRwzvBkQv5Ze+l991dlBWZlPFKDtWC7Q7TY7g1Tin YTi4CsSQIcYffJIB8yokUc+sIPyaw6TBfItgSL7TOsuZBuGzmEjinSfwpnFJy+lzW7qP dQ49PQPHwxt1SKfogLR05m0j8lK4gT63koQoWxIaQkYW+r0KEfUa/2+Nyu6jRbCuEz9H Z2ttVxMFEgSxz48tkbqCOra2zVT7WjUeilsnIvdpbJxRULAYVnK8NmTYClfbeP/PR51U ioPYGbERBDQLu9BOSzeVuGeWUkHl+zp/+VXVlx3vSeCRMX68KWMr7ONdnPii2/E5TFmy ZjZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z53fIors; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jx4-20020a17090b46c400b0024bf50a83e7si11125350pjb.174.2023.05.07.21.43.20; Sun, 07 May 2023 21:43:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Z53fIors; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232185AbjEHE0G (ORCPT + 99 others); Mon, 8 May 2023 00:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbjEHE0E (ORCPT ); Mon, 8 May 2023 00:26:04 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 765BE72BE; Sun, 7 May 2023 21:26:01 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3483tkhV010768; Mon, 8 May 2023 04:25:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=xM9aJ3QMYI2jjSHFnPeXdxLTxmpqEH4m6OdKBd6a4jw=; b=Z53fIorsfOd/a5CfYh4YR40eH4/zl/8i43oFqmhz8TA3IcgjNqTxlyPwN1b5u+B5d9S/ H2A1S+pHvVQqUXYCjqdXk+rMYusZyT+/zuUacZsIN5O9fdpT04NIOz67D9kQ4ep34/VS y/CogXYhe2KP+RAEMnePBTVYfHKUdJYnSKAxRbXOiNSb5TkVQCwmRFKWZJsnn83X/aFP EbJ7/0kBfPQQtvq19l4tRdMSB2DGpVgBOBJSC1Ju67Zc0/r4kgnmnn4H2fwtFzgJ7tJQ xvRjAUIoNDmX4ClfZUXDfK5uNHRmjWmArfiOMf9parl4SM0xMl1OvbvMuRgTMhq+biRd zw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qddv0as7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 May 2023 04:25:22 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3484PLaF024967 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 May 2023 04:25:21 GMT Received: from [10.110.53.190] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 7 May 2023 21:25:20 -0700 Message-ID: Date: Sun, 7 May 2023 21:25:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay" Content-Language: en-US To: Bjorn Andersson , Leonard Lausen CC: , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Stephen Boyd , "Kuogee Hsieh" , Johan Hovold , Sankeerth Billakanti , Sean Paul , David Airlie , Daniel Vetter , , , , , Nikita Travkin References: <20230508021536.txtamifw2vkfncnx@ripper> From: Abhinav Kumar In-Reply-To: <20230508021536.txtamifw2vkfncnx@ripper> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: CPo0I43eNuQT6fj1KBtBGXpp7wBGxqkl X-Proofpoint-ORIG-GUID: CPo0I43eNuQT6fj1KBtBGXpp7wBGxqkl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-08_02,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1011 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305080029 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/2023 7:15 PM, Bjorn Andersson wrote: > On Mon, May 08, 2023 at 01:06:13AM +0000, Leonard Lausen wrote: >> This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. >> >> Removing the delay of 100 units broke hot plug detection for USB-C displays on >> qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares >> dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not >> affected by the regression, as they do not rely on mdss and dp_hot_plug_det for >> hot plug detection. >> >> Signed-off-by: Leonard Lausen >> Tested-by: Leonard Lausen # Trogdor (sc7180) >> Suggested-by: Dmitry Baryshkov >> >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index bde1a7ce442f..db9783ffd5cf 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -1506,7 +1506,7 @@ void msm_dp_irq_postinstall(struct msm_dp *dp_display) >> dp = container_of(dp_display, struct dp_display_private, dp_display); >> >> if (!dp_display->is_edp) >> - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0); >> + dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100); > > When booting with the cable connected on my X13s, 100 is long enough for > my display to time out and require me to disconnect and reconnect the > cable again. > > Do we have any idea of why the reduction to 0 is causing an issue when > using the internal HPD? > > Regards, > Bjorn Yes, we do know why this is causing an issue. The cleaner patch for this will be posted this week. There is no need to add the 100ms delay back yet. thanks for posting this but NAK on this patch till we post the fix this week. Appreciate a bit of patience till then. > >> } >> >> bool msm_dp_wide_bus_available(const struct msm_dp *dp_display) >> -- >> 2.30.2