Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Huang, Ying" <ying.huang@intel.com>
To:     Mika =?utf-8?Q?Penttil=C3=A4?= <mpenttil@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com
Subject: Re: [PATCH] mm/migrate_device: Try to handle swapcache pages.
References: <20230507061726.13422-1-mpenttil@redhat.com>
        <87wn1ja793.fsf@yhuang6-desk2.ccr.corp.intel.com>
        <f93c14f6-024d-4abc-7598-fa82cc3ea1a5@redhat.com>
Date:   Mon, 08 May 2023 13:14:47 +0800
In-Reply-To: <f93c14f6-024d-4abc-7598-fa82cc3ea1a5@redhat.com> ("Mika
        =?utf-8?Q?Penttil=C3=A4=22's?= message of "Mon, 8 May 2023 05:59:46 +0300")
Message-ID: <87sfc79zg8.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Mika Penttil=C3=A4 <mpenttil@redhat.com> writes:

> H,
>
>
> On 8.5.2023 5.26, Huang, Ying wrote:
>> mpenttil@redhat.com writes:
>>=20
>>> From: Mika Penttil <mpenttil@redhat.com>
>>>
>>> Migrating file pages and swapcache pages into device memory is not supp=
orted.
>>> The decision is done based on page_mapping(). For now, swapcache pages =
are not migrated.
>>>
>>> Things can however be improved, for swapcache pages. Try to get rid of =
the swap cache,
>>> and if successful, go ahead as with other anonymous pages.
>>>
>>> As a detail, do not mess with shmem pages, as they handle swap internal=
ly.
>>>
>>> Cc: Alistair Popple <apopple@nvidia.com>
>>> Cc: John Hubbard <jhubbard@nvidia.com>
>>> Cc: Ralph Campbell <rcampbell@nvidia.com>
>>> Signed-off-by: Mika Penttil <mpenttil@redhat.com>
>>> ---
>>>   mm/migrate_device.c | 12 ++++++++++--
>>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
>>> index d30c9de60b0d..e8169c58c341 100644
>>> --- a/mm/migrate_device.c
>>> +++ b/mm/migrate_device.c
>>> @@ -12,6 +12,7 @@
>>>   #include <linux/mmu_notifier.h>
>>>   #include <linux/oom.h>
>>>   #include <linux/pagewalk.h>
>>> +#include <linux/shmem_fs.h>
>>>   #include <linux/rmap.h>
>>>   #include <linux/swapops.h>
>>>   #include <asm/tlbflush.h>
>>> @@ -750,10 +751,17 @@ static void __migrate_device_pages(unsigned long =
*src_pfns,
>>>   			/*
>>>   			 * For now only support anonymous memory migrating to
>>>   			 * device private or coherent memory.
>>> +			 *
>>> +			 * Try to get rid of swap cache if possible.
>>> +			 * Leave shmem pages alone, they handle swap internally
>>> +			 *
>>>   			 */
>>>   			if (mapping) {
>>> -				src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE;
>>> -				continue;
>>> +				if (shmem_mapping(mapping) ||
>>> +				    !folio_free_swap(page_folio(page))) {
>> Should we filter out file pages firstly?
>
> folio_free_swap() checks first and returns false if not swapcache page
> (ie including normal file pages) so think that is enough,

You are right.  folio_free_swap() will call folio_test_swapcache(), and
which will check folio_test_swapbacked().

And, IIUC, we don't need to check shmem too.  Because folio_free_swap()
will not return true for shmem pages.

> but maybe for clarity and not depending on it, could be good
> explicitly check for swapcache before calling folio_free_swap().

Yes.  That will be more clear.  I suggest to use folio_test_anon(), that
will filter out shmem pages too.

>>=20
>>> +					src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE;
>>> +					continue;
>>> +				}
>>>   			}
>>>   		} else if (is_zone_device_page(newpage)) {
>>>   			/*

Best Regards,
Huang, Ying