Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     shawnguo@kernel.org, s.hauer@pengutronix.de,
        linux-arm-kernel@lists.infradead.org
Cc:     kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Peng Fan <peng.fan@nxp.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Subject: Re: [PATCH] arm64: dts: imx93: add wdog3 node
Date:   Mon, 08 May 2023 08:34:31 +0200
Message-ID: <2682988.mvXUDI8C0e@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20230505093130.1834861-1-peng.fan@oss.nxp.com>
References: <20230505093130.1834861-1-peng.fan@oss.nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hello,

thanks for the patch.

Am Freitag, 5. Mai 2023, 11:31:30 CEST schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@nxp.com>
>=20
> Add wdog3 node, then watchdog could be used.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index e8d49660ac85..73ecd953ec=
8d
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -344,6 +344,14 @@ mu2: mailbox@42440000 {
>  				status =3D "disabled";
>  			};
>=20
> +			wdog3: wdog@42490000 {

I think this should be called 'watchdog@42490000'

> +				compatible =3D "fsl,imx93-wdt";
> +				reg =3D <0x42490000 0x10000>;
> +				interrupts =3D <GIC_SPI 79=20
IRQ_TYPE_LEVEL_HIGH>;
> +				clocks =3D <&clk IMX93_CLK_WDOG3_GATE>;
> +				timeout-sec =3D <40>;

Should it be disabled it by default?

> +			};
> +
>  			tpm3: pwm@424e0000 {
>  				compatible =3D "fsl,imx7ulp-pwm";
>  				reg =3D <0x424e0000 0x1000>;

Is there a reason you just add watchdog3? There are 5 in total.

Best regards,
Alexander
=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/