Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 08 May 2023 09:37:56 +0200
Message-ID: <87y1lze0iz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     jack1989s@gmail.com
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Sound:last.c: fix code syle trailing white space - modify printk()->netdev_dbg() - Possible unnecessary KERN_INFO removed
In-Reply-To: <20230507130021.48112-1-jack1989s@gmail.com>
References: <20230507130021.48112-1-jack1989s@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 07 May 2023 15:00:21 +0200,
jack1989s@gmail.com wrote:
> 
> From: Federico Di Lembo <jack1989s@gmail.com>
> 
> Fixing coding style.
> 
> Signed-off-by: Federico Di Lembo <jack1989s@gmail.com>

In general, we don't take a patch just for white space without any
real need.  Please do a cleanup together with other real fix or
enhancement patches.

Also, the use of netdev_dbg() doesn't make sense here at all; the code
has nothing to do with the network.

Last but not least, you change the printk level by the conversion
silently.  It's really bad, please don't.  If you have to change the
printk level, give the convincing explanation.


thanks,

Takashi


> ---
>  sound/last.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/last.c b/sound/last.c
> index f0bb98780e70..b8cfd6ded95d 100644
> --- a/sound/last.c
> +++ b/sound/last.c
> @@ -11,18 +11,18 @@ static int __init alsa_sound_last_init(void)
>  {
>  	struct snd_card *card;
>  	int idx, ok = 0;
> -	
> -	printk(KERN_INFO "ALSA device list:\n");
> +
> +	netdev_dbg("ALSA device list:\n");
>  	for (idx = 0; idx < SNDRV_CARDS; idx++) {
>  		card = snd_card_ref(idx);
>  		if (card) {
> -			printk(KERN_INFO "  #%i: %s\n", idx, card->longname);
> +			netdev_dbg("  #%i: %s\n", idx, card->longname);
>  			snd_card_unref(card);
>  			ok++;
>  		}
>  	}
>  	if (ok == 0)
> -		printk(KERN_INFO "  No soundcards found.\n");
> +		netdev_dbg("  No soundcards found.\n");
>  	return 0;
>  }
>  
> -- 
> 2.34.1
>