Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <734023dc-3001-3653-399f-aa66b99ba27e@zhaoxin.com>
Date:   Tue, 9 May 2023 01:33:54 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 1/4] xhci: Add some quirks for zhaoxin xhci to fix
 issues
Content-Language: en-US
To:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <tonywwang@zhaoxin.com>, <weitaowang@zhaoxin.com>,
        <stable@vger.kernel.org>
References: <20230506201536.7362-1-WeitaoWang-oc@zhaoxin.com>
 <20230506201536.7362-2-WeitaoWang-oc@zhaoxin.com>
 <71834813-4f59-a453-5d17-1a44010047ad@linux.intel.com>
From:   "WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>
In-Reply-To: <71834813-4f59-a453-5d17-1a44010047ad@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/5/8 17:01, Mathias Nyman wrote:
> On 6.5.2023 23.15, Weitao Wang wrote:
>> Add a quirk XHCI_ZHAOXIN_HOST for zhaoxin xhci to fix issues,
>> there are two cases will be used.
>> - add u1/u2 support.
>> - fix xHCI root hub speed show issue in zhaoxin platform.
>>
>> Add a quirk XHCI_ZHAOXIN_TRB_FETCH to fix TRB prefetch issue.
>>
>> On Zhaoxin ZX-100 project, xHCI can't work normally after resume
>> from system Sx state. To fix this issue, when resume from system
>> Sx state, reinitialize xHCI instead of restore.
>> So, Add XHCI_RESET_ON_RESUME quirk for ZX-100 to fix issue of
>> resuming from system Sx state.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
> 
> 
> I'd split this series into different logical parts:
> 
> patch 1/4
>    Set XHCI_RESET_ON_RESUME quirk to ZHAOXIN host to fix resume issue.
>    cc: stable
> 
> patch 2/4
>    Add XHCI_ZHAOXIN_TRB_FETCH quirk flag together with code that allocates double pages
>    cc: stable
> 
> patch 3/4
>    Add XHCI_ZHAOXIN_HOST quirk flag together with code that corrects USB3 roothub minor 
> version
>    cc: stable
> 
> patch 4/4
>    Set XHCI_LPM_SUPPORT quirk together with code that sets tier policy and u1/u2 timeouts,
>    Don't add stable as this is about adding feature support.
> 
Okay,no problem, I'll modify this patch series according to
above solution and order in the next version.

Best Regards,
Weitao
> (Accidentally replied to older v2 series with the above comments)
> 
> Thanks
> -Mathias
> 
> .