Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp4098173rwr; Mon, 8 May 2023 02:54:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TlidprGej6prZmuLyVy0/b8AqDtEsHgyJmndT+isRnOYOhAWB/YGMGw3JvRreo7AGw4ZM X-Received: by 2002:a17:903:2292:b0:1aa:ed72:5c2e with SMTP id b18-20020a170903229200b001aaed725c2emr13533094plh.61.1683539654775; Mon, 08 May 2023 02:54:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683539654; cv=none; d=google.com; s=arc-20160816; b=I87DMLaXF6mW5twmy+9j/tOmrWqO1iqNROKQOiebqaX9menf3jWtirtlvIwVko8a6Z jsiz/ow79bnKEnbGHR6tKwXNZGDpbsl3euzevB615SVGTI2IUyTGS0Nl7tDfyUyqVS5h rO/AQhf9egA1ejbFufRq4FU7RayZSPCwQDQH2GFw7JgdOayWY29zFLkhCzn4tm4WzZWg KBbeAq8X4BjpH1SOl4p7F2hEIQC4PfIIrNtkfbwaoD+AYfvLKVocoIDFYHpTyJWq+t6p N2uW8hlsgvCOeJBUoEBkb4O4O8E3vbgWD4msB8ulBOxl7Tob2GU5ZX7u4JA1zf46PEhG CbXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Mqn1KEnwyqGdeTv677y/SImyCACSQbNkaaVgC/3IO8U=; b=Ngam0wOMPJWXGXTbygFHhx6++9PoyCdnhc0dBZ/lT5DAoiPWH8w1OaAtb9EA+WXJmx zXARJhcJDeD0fcutTwLnjyax6IpB0Dp4JRPTixqo6Hx+mLGwF4p25JcsxEJVAapCBczo GgjGlMXqBFUv9iJUHHysjGN3qhMv4f4wWGL7c0uhc5mbXy4OfmI9fKqU+0QFJ6tjYlmR VTjf3jGSCwsPUIulBK3jYvV39G+kWYO2w/tI5WzazCEGvj7HXf86o88w3VVm+XYmOv/w MP1bF0imm8OfEjdsbYdkuDQmQV4FiXAO+pRTKfeEdG61YfJYqSPzzyOTm/y4nJtrsGtt HPaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b=I3L+5FeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k93-20020a17090a3ee600b0024de28ed3eesi12460739pjc.33.2023.05.08.02.54.02; Mon, 08 May 2023 02:54:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20221208.gappssmtp.com header.s=20221208 header.b=I3L+5FeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbjEHJOk (ORCPT + 99 others); Mon, 8 May 2023 05:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232894AbjEHJOj (ORCPT ); Mon, 8 May 2023 05:14:39 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751749ECF for ; Mon, 8 May 2023 02:14:37 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f415a90215so23401375e9.0 for ; Mon, 08 May 2023 02:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1683537276; x=1686129276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Mqn1KEnwyqGdeTv677y/SImyCACSQbNkaaVgC/3IO8U=; b=I3L+5FeYMvJvQuU7Qu76mdUd1ATQsaT9+QYqpPqVQCMhlS/mcRnqixhHa683tVS/4N YQOWLHE85n94zlIOvHipGq05bHg0SvQaQ18qsTZ6xtHTrsAawJjB9fRDkmQMpMopgfKh RXbVV6hTqiY28pLZJKjxgL1UV50T/rXjFX/DAcHhczTQQ9l1FspCaz165MJpGnIBdGxL Efs9wVDZ6Qsghu2p/lelXDhn4FoxqKDDwINEbHU7hNtBNW/eMuE0h6VVPMntkaVPUBNF Flo3MPGYfD9+v7IIF6O8g3HA3V1wWT1RndHZVqUjRHRTEDX1FYelWwn9mptOQVzo7HSr szYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683537276; x=1686129276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mqn1KEnwyqGdeTv677y/SImyCACSQbNkaaVgC/3IO8U=; b=GjN5cBRasEiRdfnwzed+tvykW6QTXtDS7aF2erznZKIHqZpawdiFa8o5AvM1TeAbJB EBRSf9S/dDHDjcDnTEvZuJB8jq2NKO5h8UQixG0mjZ6cx4s39Fmq1wBGN7XSy3meut8g X8KEBWKf57g57ioz8LAvdCWvyv2PDbE4mzOmLoumoNrlQSN67P7XIEYBt4Axy/kFacIh Gtvx1mV+zWXJ9rDKBVnX/+BqENlDatOaUXmn5FW5+tM+6xZFKZKeUZvvvN5z1UqY+9vn jxa17SxXKNJFDijaZlqhYH+wwyBeiSx0ItVBG5mDJbDMzYW+Y4i8PpuJMt+U8MsOxq2V TShg== X-Gm-Message-State: AC+VfDz2fY0tkB6EaGIqrNOdgJtarB2iMbkzpV1LfF9mxQNt4sPmVdDA MtruwkwD7R6CD3Uquh6la7BIxg== X-Received: by 2002:adf:f4c3:0:b0:2ef:bc0b:e70 with SMTP id h3-20020adff4c3000000b002efbc0b0e70mr6656855wrp.54.1683537275955; Mon, 08 May 2023 02:14:35 -0700 (PDT) Received: from blmsp ([2001:4090:a246:80f3:ef71:25ff:df82:9cc9]) by smtp.gmail.com with ESMTPSA id n2-20020a5d4c42000000b003063db8f45bsm10662309wrt.23.2023.05.08.02.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 02:14:35 -0700 (PDT) Date: Mon, 8 May 2023 11:14:34 +0200 From: Markus Schneider-Pargmann To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org, chun-jie.chen@mediatek.com, mandyjh.liu@mediatek.com, miles.chen@mediatek.com, zhaojh329@gmail.com, daniel@makrotopia.org, nfraprado@collabora.com, rex-bc.chen@mediatek.com, Garmin.Chang@mediatek.com, yangyingliang@huawei.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 1/2] clk: mediatek: mux: Stop forcing CLK_SET_RATE_PARENT flag Message-ID: <20230508091434.ww2o2nsavpineko3@blmsp> References: <20230505093733.221922-1-angelogioacchino.delregno@collabora.com> <20230505093733.221922-2-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230505093733.221922-2-angelogioacchino.delregno@collabora.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angelo, On Fri, May 05, 2023 at 11:37:32AM +0200, AngeloGioacchino Del Regno wrote: > The clk-mux driver was forcing the CLK_SET_RATE_PARENT flag even for > the GATE_CLK_SET_UPD_FLAGS() macro, as in mtk_clk_register_mux() the > flag was unconditionally added. > > In preparation for a change on MSDC clock muxes, stop forcing this > flag and, where necessary, update clock drivers to add it so that > with this commit we introduce no functional changes for the currently > supported SoCs. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/clk/mediatek/clk-mt6765.c | 8 +++--- > drivers/clk/mediatek/clk-mt6779.c | 6 ++--- > drivers/clk/mediatek/clk-mt8183.c | 6 +++-- > drivers/clk/mediatek/clk-mt8186-topckgen.c | 12 ++++----- > drivers/clk/mediatek/clk-mt8188-topckgen.c | 24 +++++++++++------ > drivers/clk/mediatek/clk-mt8192.c | 6 ++--- > drivers/clk/mediatek/clk-mt8195-topckgen.c | 30 ++++++++++++++-------- > drivers/clk/mediatek/clk-mux.c | 2 +- After grepping through the files, I think you missed drivers/clk/mediatek/clk-mt8365.c. After adding that file to this patch: Reviewed-by: Markus Schneider-Pargmann Best, Markus