Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 May 2023 14:34:13 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Tariq Toukan <tariqt@nvidia.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Paolo Abeni" <pabeni@redhat.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Gal Pressman <gal@nvidia.com>, Tal Gilboa <talgi@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Roy Novich <royno@nvidia.com>, Aya Levin <ayal@nvidia.com>
Subject: Re: [PATCH net] linux/dim: Do nothing if no time delta between
 samples
Message-ID: <ZFjsRZzWIozLEgDW@localhost.localdomain>
References: <20230507135743.138993-1-tariqt@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230507135743.138993-1-tariqt@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sjK+VTl1Nlv6veUN87z/xAN3MgH8CrwCeXUHl06Yf/L6uEZLNwV/g2hiBOMR?=
 =?us-ascii?Q?QFdxTIxQa2Qldb4GQaOPUS7JclidmCLz22aTO5AMhgTdPyIgYQ/wBdKswS7c?=
 =?us-ascii?Q?cHruaq5SaWv4e7YN5pViCl6UJMnb6AO1LoeC0lzZ+V0f446NJ+R00GgYkPch?=
 =?us-ascii?Q?0LQJMHPqIojP/YUnk16U0lv1VHTZy2MWU7ReNrxnw7eFvKaiQu9ROveYDTi2?=
 =?us-ascii?Q?NF6++3YLENPQwQPjgkr8IJcMGVB+iAXzl6GzW+CZPNwCuXxmhTobYS2FISWp?=
 =?us-ascii?Q?Y/iQE16txVgyQ0WxRySyJFgqmlr1rtuFK+zxbuIhH+WhMSlh92U9HZt3b7Jq?=
 =?us-ascii?Q?4V1/hSIYnv1MtS5HKQ20BmEIZcSNJmH4b+H/mf2aDIS6Bi9A0s7DQH3wqe9Y?=
 =?us-ascii?Q?2eLDml8eHed6zvGOgpFU6xU30FwR3fsq+7dBo0LQN3wt/4bc5didRqx9bx6t?=
 =?us-ascii?Q?NFD3brCXvYRdg+Qto4ezfBxyQk2qXPAxPIkBnwll1RyV/dw6rHYdepYkl3h1?=
 =?us-ascii?Q?uWCx1Lny98pQGoZ2bhcVub5DkqCbpx1ZY3YDDe7fqZZiPNDacDBVjR+Pf+t0?=
 =?us-ascii?Q?sZEqFtYF8I67sYkmUAFZde1AU9ngPyB466DMUNPdJKVMSbKtmPui5euDgD7K?=
 =?us-ascii?Q?wl1YnYEtSr3pqZ8EsIpu/zzSymFfyuEqgFaD2UdY1vyCDVTjbvkqdTLAND7h?=
 =?us-ascii?Q?LSZwV9cAgqgMJY2rhefHAAnUfMkCpgfnfJMcL8zTpTpbFLanGRUWl8F1K22+?=
 =?us-ascii?Q?pyeOxjxUevl3o1EZFPSMUstJryM7lfrBA3TKDaMrSLRT8/2/fYcKrYirKTsR?=
 =?us-ascii?Q?qkC7eUOrF9e36i/DhNziIWP2I7e3jTlU3ow4w5uQv3OZpi4fqiO4MPeQRevB?=
 =?us-ascii?Q?qJzcRXZMy64cEBjan/WeS3OfFqqB5jXKSL6OnPTsJXW6nrPIiZmlompGJWCg?=
 =?us-ascii?Q?2DGE4ZlWzGg2gCDjCpOWYmwLtmmBDfHOAADLR+c2rjtfd1X6Vgj41d6p/RLN?=
 =?us-ascii?Q?xGpEfCNqhrt5YeZrybUqkjBGUVEnmJb8iz0qiTrDMpGP1FFvHNoC4dxWq6xA?=
 =?us-ascii?Q?xCUsdXeR39Z5wnGxiex+kKwhq2F8NolyQjNWBRwzf0m2KPOdFNTKvRQ0V8G2?=
 =?us-ascii?Q?K+HzfRbck1N7edtE36xMy/2UrUz/avwoC2uE00vlfUvqlPm0vH4xbmz/EieL?=
 =?us-ascii?Q?rOXNo3hx6sk/Hsd5ViyngXKx/Bk+S5UxJobq/Nw52vXP8q/ezgxOEYtE/hAH?=
 =?us-ascii?Q?StrneZsaj81fGvZxD5C1L+VJZBvG/wqXCxdMJFmkClii7PgD4OkaTYUv/iNh?=
 =?us-ascii?Q?UeaZEGvLsns2sxwnMY8WRxGiK0xlFeqmY3V3XY4nGw6OgqaGg2mWkgJQa8N8?=
 =?us-ascii?Q?G27u3ox8TKSIJGBYD/z5oXWDeMEu0+SEJcPJncObAbpPr3ZcGQORP+kjR34h?=
 =?us-ascii?Q?zm+rP35rYLVFNyvxhjH4dRP9rnJXeBCBo8xW/12Polf5maMdPxh6OihvZW7e?=
 =?us-ascii?Q?gp38SAJlScSDmNwby2KDbxgsxwjXuEaTuhFH0Y9JeFnYHy6JF8MXA22F08e8?=
 =?us-ascii?Q?jfXN7+AlR5xiOgCzyG52+G1O2gaof43/T5sTvKLRL6c4quPIssyEXFfQiI+4?=
 =?us-ascii?Q?Lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 820b5dfc-a8a9-408a-3e47-08db4fc08c86
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 12:34:21.4674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6INh/r/r1z7iwhMGgnfThFyIGufg98iFbWcMAwItKMo+2r+czbi4H9G5ZS/zqihcpsMugb+DBjUI48FzAQzT8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8212
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 07, 2023 at 04:57:43PM +0300, Tariq Toukan wrote:
> From: Roy Novich <royno@nvidia.com>
> 
> Add return value for dim_calc_stats. This is an indication for the
> caller if curr_stats was assigned by the function. Avoid using
> curr_stats uninitialized over {rdma/net}_dim, when no time delta between
> samples. Coverity reported this potential use of an uninitialized
> variable.
> 
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
> Fixes: cb3c7fd4f839 ("net/mlx5e: Support adaptive RX coalescing")
> Signed-off-by: Roy Novich <royno@nvidia.com>
> Reviewed-by: Aya Levin <ayal@nvidia.com>
> Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---

Looks good to me.

Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>