Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 May 2023 22:16:50 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Joy Chakraborty <joychakr@google.com>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        manugautam@google.com, rohitner@google.com
Subject: Re: [PATCH v9 4/5] spi: dw: Add DMA address widths capability check
Message-ID: <ZFj2QraXvNqBRwqM@finisterre.sirena.org.uk>
References: <20230427123314.1997152-1-joychakr@google.com>
 <20230427123314.1997152-5-joychakr@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="srztywi96yxDAX5Z"
Content-Disposition: inline
In-Reply-To: <20230427123314.1997152-5-joychakr@google.com>
Precedence: bulk


--srztywi96yxDAX5Z
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 27, 2023 at 12:33:13PM +0000, Joy Chakraborty wrote:
> Store address width capabilities of DMA controller during init and check
> the same per transfer to make sure the bits/word requirement can be met.
>=20
> Current DW DMA driver requires both tx and rx channel to be configured
> and functional hence a subset of both tx and rx channel address width
> capability is checked with the width requirement(n_bytes) for a
> transfer.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/spi/spi-dw-dma.c: In function =E2=80=98dw_spi_dm=
a_caps_init=E2=80=99:
/build/stage/linux/drivers/spi/spi-dw-dma.c:100:1: error: control reaches e=
nd of non-void function [-Werror=3Dreturn-type]
  100 | }
      | ^
cc1: some warnings being treated as errors

--srztywi96yxDAX5Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRY9j8ACgkQJNaLcl1U
h9CmgAf/Y1S/7Ur9OhwH8FO3pfxB5IWmD7SfXUW738hjNQGzCWtM7wCPUI0lOpL9
5QDQR/HDwjHuJfsM+6dZPr/CIqAT8PQKe3DU9tDzcfIbZX2UOGcpO/HJkCDdI4y5
F0uJRNPIZpgjhb/MVa0pBT59Jbud5UDzfXpiSm3lij0LuKDUpW2gxlJ5N+cbDKdP
genA3UeLi9szDRIAxfytoA/8lwYqi42uUiaFGlGAYzoLKrql/TyvuGov3EzJLVuk
cjLHSfcuqEUeW87VMGX6GtMqVRpIPwSB5QJBx+OgoAvKQ4gm4z7CWzPjro+tEuFI
nVOhaIn08Iz+WQWRbfHiLpYfCfUJVg==
=xyvi
-----END PGP SIGNATURE-----

--srztywi96yxDAX5Z--