Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 May 2023 22:20:04 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Yinbo Zhu <zhuyinbo@loongson.cn>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
        wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v9 2/2] spi: loongson: add bus driver for the loongson
 spi controller
Message-ID: <ZFj3BEHCDc/XLBZB@finisterre.sirena.org.uk>
References: <20230426071045.20753-1-zhuyinbo@loongson.cn>
 <20230426071045.20753-3-zhuyinbo@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="XLm4P5IUAz3phiU9"
Content-Disposition: inline
In-Reply-To: <20230426071045.20753-3-zhuyinbo@loongson.cn>
Precedence: bulk


--XLm4P5IUAz3phiU9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 26, 2023 at 03:10:45PM +0800, Yinbo Zhu wrote:
> This bus driver supports the Loongson spi hardware controller in the
> Loongson platforms and supports to use DTS and PCI framework to
> register spi device resources.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/spi/spi-loongson-core.c: In function =E2=80=98lo=
ongson_spi_init_master=E2=80=99:
/build/stage/linux/drivers/spi/spi-loongson-core.c:222:31: error: implicit =
declaration of function =E2=80=98of_node_get=E2=80=99 [-Werror=3Dimplicit-f=
unction-declaration]
  222 |         master->dev.of_node =3D of_node_get(dev->of_node);
      |                               ^~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-loongson-core.c:222:29: error: assignmen=
t to =E2=80=98struct device_node *=E2=80=99 from =E2=80=98int=E2=80=99 make=
s pointer from integer without a cast [-Werror=3Dint-conversion]
  222 |         master->dev.of_node =3D of_node_get(dev->of_node);
      |                             ^
/build/stage/linux/drivers/spi/spi-loongson-core.c:242:13: error: implicit =
declaration of function =E2=80=98of_get_property=E2=80=99 [-Werror=3Dimplic=
it-function-declaration]
  242 |         if (of_get_property(dev->of_node, "spi-nocs", NULL))
      |             ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

--XLm4P5IUAz3phiU9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRY9wMACgkQJNaLcl1U
h9DhnAf/Rhh0Q9tyOwxp7DdPW2Ys4Rcuq4CES/hgxOKXyxUqTn1HsF0H9VL2/P1w
KqLKoqzD1+Y24twdKcTh100SonViZqf6xMJSAB0U+RfyLcErUwafjmckjQe0pmEH
Yigc7BExtn4GY7hK+IeSE3XbUX17Tk6WLcn0t7khwOcpo2KfaeCrea/ZJtlMt1eR
/PAv/6QL64kBj6j23F/EtzvCTx9yXGPi3oa1sh9D/c/EkkwQhbdDJv1zMW6pRN9T
A6nyb+wUq+vwN03XnyqWu8cjHd6Y9ExhDjnELm9jbxXr5kARlfK/8rihNL+PDjzT
xuTS6cmhMfWsXisDtixgKfRf4UBFeQ==
=z8qJ
-----END PGP SIGNATURE-----

--XLm4P5IUAz3phiU9--