Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-386-g2404815117-fm-20230425.001-g24048151
Mime-Version: 1.0
Message-Id: <eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com>
In-Reply-To: <4143448b-fb4f-860d-da67-b864e5b33020@infradead.org>
References: <20230429044506.24843-1-rdunlap@infradead.org>
 <CAJhGHyBjTykZ3d-D-M_1eD5J8QgNcPZcCsCMnqbBcvRoEceSuQ@mail.gmail.com>
 <4143448b-fb4f-860d-da67-b864e5b33020@infradead.org>
Date:   Mon, 08 May 2023 15:41:15 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Randy Dunlap" <rdunlap@infradead.org>,
        "Lai Jiangshan" <jiangshanlai@gmail.com>
Cc:     linux-kernel@vger.kernel.org, "Tejun Heo" <tj@kernel.org>
Subject: Re: [RFC PATCH] workqueue: fix cast warnings on i386
Content-Type: text/plain
Precedence: bulk

On Mon, May 1, 2023, at 06:42, Randy Dunlap wrote:
> On 4/30/23 21:37, Lai Jiangshan wrote:
>> Both the type of the "data" and WORK_STRUCT_WQ_DATA_MASK are
>> "unsigned long", so I don't think "(data & WORK_STRUCT_WQ_DATA_MASK)"
>> needs to be converted to "unsigned long".
>> 
>>         WORK_STRUCT_FLAG_MASK   = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
>>         WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
>> 
>> This simple fix might hide the real problem.
>
> Thanks for replying.
>
> Do you have any suggestions for how to eliminate these warnings on i386
> and ARCH=um SUBARCH=i386?

I'm pretty sure the patch I posted earlier is the correct one, see
https://lore.kernel.org/all/20230117164041.1207412-1-arnd@kernel.org/

Sorry I never followed up on this after the initial post, I have
a backlog of patches that I sent out as build fixes but that for
some reason have not made it in.

     Arnd