Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58261cfa-7cba-5cc6-92ac-de155a813df7@mojatatu.com>
Date:   Mon, 8 May 2023 11:11:53 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH net 5/6] net/sched: Refactor qdisc_graft() for ingress and
 clsact Qdiscs
To:     Peilin Ye <yepeilin.cs@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>
Cc:     Peilin Ye <peilin.ye@bytedance.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.r.fastabend@intel.com>,
        Vlad Buslov <vladbu@mellanox.com>,
        Hillf Danton <hdanton@sina.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>
References: <cover.1683326865.git.peilin.ye@bytedance.com>
 <1cd15c879d51e38f6b189d41553e67a8a1de0250.1683326865.git.peilin.ye@bytedance.com>
Content-Language: en-US
From:   Pedro Tammela <pctammela@mojatatu.com>
In-Reply-To: <1cd15c879d51e38f6b189d41553e67a8a1de0250.1683326865.git.peilin.ye@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/05/2023 21:15, Peilin Ye wrote:
> Grafting ingress and clsact Qdiscs does not need a for-loop in
> qdisc_graft().  Refactor it.  No functional changes intended.
> 
> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>

Just a FYI:
If you decide to keep this refactoring, it will need to be back ported
together with the subsequent fix.
I would personally leave it to net-next.

Thanks for chasing this!

Tested-by: Pedro Tammela <pctammela@mojatatu.com>

> ---
>   net/sched/sch_api.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
> index 49b9c1bbfdd9..f72a581666a2 100644
> --- a/net/sched/sch_api.c
> +++ b/net/sched/sch_api.c
> @@ -1073,12 +1073,12 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent,
>   
>   	if (parent == NULL) {
>   		unsigned int i, num_q, ingress;
> +		struct netdev_queue *dev_queue;
>   
>   		ingress = 0;
>   		num_q = dev->num_tx_queues;
>   		if ((q && q->flags & TCQ_F_INGRESS) ||
>   		    (new && new->flags & TCQ_F_INGRESS)) {
> -			num_q = 1;
>   			ingress = 1;
>   			if (!dev_ingress_queue(dev)) {
>   				NL_SET_ERR_MSG(extack, "Device does not have an ingress queue");
> @@ -1094,18 +1094,18 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent,
>   		if (new && new->ops->attach && !ingress)
>   			goto skip;
>   
> -		for (i = 0; i < num_q; i++) {
> -			struct netdev_queue *dev_queue = dev_ingress_queue(dev);
> -
> -			if (!ingress)
> +		if (!ingress) {
> +			for (i = 0; i < num_q; i++) {
>   				dev_queue = netdev_get_tx_queue(dev, i);
> +				old = dev_graft_qdisc(dev_queue, new);
>   
> -			old = dev_graft_qdisc(dev_queue, new);
> -			if (new && i > 0)
> -				qdisc_refcount_inc(new);
> -
> -			if (!ingress)
> +				if (new && i > 0)
> +					qdisc_refcount_inc(new);
>   				qdisc_put(old);
> +			}
> +		} else {
> +			dev_queue = dev_ingress_queue(dev);
> +			old = dev_graft_qdisc(dev_queue, new);
>   		}
>   
>   skip: