Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230506093243.540406-1-yangcong5@huaqin.corp-partner.google.com>
In-Reply-To: <20230506093243.540406-1-yangcong5@huaqin.corp-partner.google.com>
From:   Doug Anderson <dianders@google.com>
Date:   Mon, 8 May 2023 07:28:37 -0700
Message-ID: <CAD=FV=WG9L-Fsq6wkmjk19bCPqVJgu41_hmQz0g6kLPvDrt_XQ@mail.gmail.com>
Subject: Re: [PATCH] drm/panel: Modify innolux hj110iz panel inital code
To:     Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Cc:     thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
        daniel@ffwll.ch, hsinyi@google.com,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Sat, May 6, 2023 at 2:32=E2=80=AFAM Cong Yang
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> Optimize flickering problem and power off sequence GOP timing at sleep in=
 mode.
> When display sleep in raise the potential of all GOP signals to VGHO and =
then
> lower to GND.
>
> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> ---
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 397 +++++++++++-------
>  1 file changed, 235 insertions(+), 162 deletions(-)

You sent two different patches with the exact same subject and the
same description but completely different contents. I can't land that.

Options:

1. Send a two-patch series where each patch has a different subject /
description.

2. Since these both touch the same file and (presumably) are trying to
address the same issue, just combine them into one patch and send
that.

Please make sure you document everything the patch is doing. I don't
think anything in the description explains why you need to change the
clock rate / blanking periods.

-Doug