Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 May 2023 14:22:13 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: remove unneeded include of
 linux/leds.h
Message-ID: <20230508122213.2fj4kinuxr2ntoob@mercury.elektranox.org>
References: <20230212-include-power_supply-leds-v2-0-e9910a3f5837@weissschuh.net>
 <20230212-include-power_supply-leds-v2-2-e9910a3f5837@weissschuh.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="exsjkieiclz3e4to"
Content-Disposition: inline
In-Reply-To: <20230212-include-power_supply-leds-v2-2-e9910a3f5837@weissschuh.net>
Precedence: bulk


--exsjkieiclz3e4to
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, May 02, 2023 at 06:28:45AM +0200, Thomas Wei=DFschuh wrote:
> Instead of including the full linux/leds.h header file a single
> forward-declaration is enough.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  include/linux/power_supply.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index a427f13c757f..dc5e17e8c919 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -14,10 +14,11 @@
> =20
>  #include <linux/device.h>
>  #include <linux/workqueue.h>
> -#include <linux/leds.h>
>  #include <linux/spinlock.h>
>  #include <linux/notifier.h>
> =20
> +struct led_trigger;
> +
>  /*
>   * All voltages, currents, charges, energies, time and temperatures in u=
V,
>   * =B5A, =B5Ah, =B5Wh, seconds and tenths of degree Celsius unless other=
wise
>=20
> --=20
> 2.40.1
>=20

--exsjkieiclz3e4to
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmRY6XQACgkQ2O7X88g7
+prQDA/9EVN7uHo6O4SftuS1Iddi+3AFTrCvpQTI4/91dMKsMFsVdXcJfWZu5Qcy
sIiGosUUym6S58Or+WakBLA8CRE1KiK42ZUm9KNviHQhwyYHTiIFdJCfLf3mzUqQ
X+emDKJu1XaY5xeTCkcNJ0bGEiZ0W1PnWji8IHWu+lD5VDI5FyTP3gtBltSE9PXA
tbrUyuZ8jOcJ/2oJ7mYeU7ULshkbfTuQCUMocx7b7Q+wvimn0KHsdJaxKkTDT4HO
LW1YfYN/yAXmhbslB2yly/N5tKkHxd+PQ6SMMHqMRb0zbHEv0jFIi6h2BuZfyOmc
fQgsmSLVewfi9XaPbIMjRUlVlY3+JXK1oxKLHd5cMaaH1jQ1DKqooocve4y+LPft
xvgwvNEipNGu6m2S6OnqW/WU66R9cjRf7o1kCeKDFYAIQRZ+DVLm78/JU21QqDa5
CrioDehsd4DoizLNDWMJO69TCdmuHNTL4ys7j+irWSBietFpMdWG3GQ0EWqjrTGP
MRyKclO1aQaQ6CnPCQ4tALa1RuGRWcO1wK5+xg9H3D5wguzw7mwDl/N2njGc/pFD
xMxi20SRVAjO6Q/Gh/O+eqtmpGAEcVT2+PlfDtLShOLtlNjoIjnU+PsfwN0+MU3W
YmfI+QRu9rjdLZYi+kgCKlg4RgAHLYOj32Jfi9E2BCD0gu0Vrig=
=NG8+
-----END PGP SIGNATURE-----

--exsjkieiclz3e4to--