Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230504181827.130532-1-mizhang@google.com> <c9090d80-46da-ed88-bad9-5a2e6d33d77b@intel.com>
In-Reply-To: <c9090d80-46da-ed88-bad9-5a2e6d33d77b@intel.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Mon, 8 May 2023 10:28:15 -0700
Message-ID: <CALMp9eS7KuGkMiZ-RQoYqTQ7TyzLct3OVUCuJUorkg3WBVJ3zQ@mail.gmail.com>
Subject: Re: [PATCH v2] KVM: VMX: add MSR_IA32_TSX_CTRL into msrs_to_save
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     Mingwei Zhang <mizhang@google.com>,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 7, 2023 at 6:54=E2=80=AFPM Xiaoyao Li <xiaoyao.li@intel.com> wr=
ote:
>
> On 5/5/2023 2:18 AM, Mingwei Zhang wrote:
> > Add MSR_IA32_TSX_CTRL into msrs_to_save[] to explicitly tell userspace =
to
> > save/restore the register value during migration. Missing this may caus=
e
> > userspace that relies on KVM ioctl(KVM_GET_MSR_INDEX_LIST) fail to port=
 the
> > value to the target VM.
> >
> > In addition, there is no need to add MSR_IA32_TSX_CTRL when
> > ARCH_CAP_TSX_CTRL_MSR is not supported in guest. So add the checking in
> > kvm_probe_msr_to_save().
> >
> > Fixes: b07a5c53d42a ("KVM: vmx: use MSR_IA32_TSX_CTRL to hard-disable T=
SX on guest that lack it")
>
> I wonder it's the fix for this commit.
>
> Apart from this,
>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

I concur.

How about:

Fixes: ea732b38b341 ("KVM: vmx: implement MSR_IA32_TSX_CTRL disable
RTM functionality")

Reviewed-by: Jim Mattson <jmattson@google.com>