Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0df23fc9-fcfe-cb53-3ee6-ced88751451e@kernel.dk>
Date:   Mon, 8 May 2023 12:10:35 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] io_uring: add dummy io_uring_sqe_cmd() helper
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>,
        Arnd Bergmann <arnd@kernel.org>
Cc:     Keith Busch <kbusch@kernel.org>, Breno Leitao <leitao@debian.org>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Kanchan Joshi <joshi.k@samsung.com>,
        Anuj Gupta <anuj20.g@samsung.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230508070825.3659621-1-arnd@kernel.org>
 <ZFkJ2x+XCMmDzOR4@infradead.org>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <ZFkJ2x+XCMmDzOR4@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/8/23 8:40 AM, Christoph Hellwig wrote:
> On Mon, May 08, 2023 at 09:08:18AM +0200, Arnd Bergmann wrote:
>> Add a dummy function like the other interfaces for this configuration.
> 
> Why do we need a separate dummy? The structure is unconditionally
> defined, so we can just unconditionally define the helper.

Yeah, no reason for a special one. I'll send one out.

-- 
Jens Axboe