Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c1124dc-c4fd-62d1-f1ea-b0a3d0b36fbb@infradead.org>
Date:   Mon, 8 May 2023 12:06:26 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [RFC PATCH] workqueue: fix cast warnings on i386
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        Lai Jiangshan <jiangshanlai@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
References: <20230429044506.24843-1-rdunlap@infradead.org>
 <CAJhGHyBjTykZ3d-D-M_1eD5J8QgNcPZcCsCMnqbBcvRoEceSuQ@mail.gmail.com>
 <4143448b-fb4f-860d-da67-b864e5b33020@infradead.org>
 <eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <eabf596d-8e19-484d-87b6-11222a5832eb@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/8/23 06:41, Arnd Bergmann wrote:
> On Mon, May 1, 2023, at 06:42, Randy Dunlap wrote:
>> On 4/30/23 21:37, Lai Jiangshan wrote:
>>> Both the type of the "data" and WORK_STRUCT_WQ_DATA_MASK are
>>> "unsigned long", so I don't think "(data & WORK_STRUCT_WQ_DATA_MASK)"
>>> needs to be converted to "unsigned long".
>>>
>>>         WORK_STRUCT_FLAG_MASK   = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
>>>         WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
>>>
>>> This simple fix might hide the real problem.
>>
>> Thanks for replying.
>>
>> Do you have any suggestions for how to eliminate these warnings on i386
>> and ARCH=um SUBARCH=i386?
> 
> I'm pretty sure the patch I posted earlier is the correct one, see
> https://lore.kernel.org/all/20230117164041.1207412-1-arnd@kernel.org/
> 

Thanks for the reply. Your patch looks good. I appreciate the
explanation.

> Sorry I never followed up on this after the initial post, I have
> a backlog of patches that I sent out as build fixes but that for
> some reason have not made it in.

I know how that goes. I have quite a few as well.

-- 
~Randy