Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4c99e915-b067-367d-bdbe-095b7f244aa4@rocketmail.com>
Date:   Mon, 8 May 2023 22:27:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v4 5/8] power: supply: rt5033_charger: Add RT5033 charger
 device driver
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Beomho Seo <beomho.seo@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Raymond Hackley <raymondhackley@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Grimler <henrik@grimler.se>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
References: <20230506155435.3005-1-jahau@rocketmail.com>
 <20230506155435.3005-6-jahau@rocketmail.com>
 <20230508065014.xfftu6vorxgqdh7h@mercury.elektranox.org>
Content-Language: en-US
From:   Jakob Hauser <jahau@rocketmail.com>
In-Reply-To: <20230508065014.xfftu6vorxgqdh7h@mercury.elektranox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sebastian,

On 08.05.23 08:50, Sebastian Reichel wrote:
> Hi,
> 
> On Sat, May 06, 2023 at 05:54:32PM +0200, Jakob Hauser wrote:
>> This patch adds device driver of Richtek RT5033 PMIC. The driver supports
>> switching charger. rt5033 charger provides three charging modes. The charging
>> modes are pre-charge mode, fast charge mode and constant voltage mode. They
>> vary in charge rate, the charge parameters can be controlled by i2c interface.
>>
>> Cc: Beomho Seo <beomho.seo@samsung.com>
>> Cc: Chanwoo Choi <cw00.choi@samsung.com>
>> Tested-by: Raymond Hackley <raymondhackley@protonmail.com>
>> Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
> 
> Driver looks mostly good. I still found a couple of small things
> though. Please find them inline.

...

The change requests look reasonable. Thanks for additional hints. I'll 
implement them in v5.

Kind regards,
Jakob