Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c76035f3-3b7d-4a28-b218-8ed9e3f11014@rocketmail.com>
Date:   Mon, 8 May 2023 22:36:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v4 6/8] power: supply: rt5033_charger: Add cable detection
 and USB OTG supply
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Beomho Seo <beomho.seo@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Raymond Hackley <raymondhackley@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>, Axel Lin <axel.lin@ingics.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Grimler <henrik@grimler.se>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
References: <20230506155435.3005-1-jahau@rocketmail.com>
 <20230506155435.3005-7-jahau@rocketmail.com>
 <20230508114323.rzqbp2isvczzg3wx@mercury.elektranox.org>
Content-Language: en-US
From:   Jakob Hauser <jahau@rocketmail.com>
In-Reply-To: <20230508114323.rzqbp2isvczzg3wx@mercury.elektranox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sebastian,

On 08.05.23 13:43, Sebastian Reichel wrote:
> On Sat, May 06, 2023 at 05:54:33PM +0200, Jakob Hauser wrote:

...

>> diff --git a/include/linux/mfd/rt5033.h b/include/linux/mfd/rt5033.h
>> index e99e2ab0c1c1..d2c613764756 100644
>> --- a/include/linux/mfd/rt5033.h
>> +++ b/include/linux/mfd/rt5033.h
>> @@ -53,6 +53,14 @@ struct rt5033_charger {
>>   	struct rt5033_dev		*rt5033;
>>   	struct power_supply		*psy;
>>   	struct rt5033_charger_data	*chg;
>> +	struct extcon_dev		*edev;
>> +	struct notifier_block		extcon_nb;
>> +	struct work_struct		extcon_work;
>> +	struct mutex			lock;
>> +	bool online;
>> +	bool otg;
>> +	bool mivr_enabled;
>> +	u8 cv_regval;
>>   };
> 
> Please move 'struct rt5033_charger' and 'struct rt5033_charger_data'
> to drivers/power/supply/rt5033_charger.c; they are not supposed to
> be used directly by others. Making it private helps to avoid
> cross-subsystem series for future maintanence patches.

Makes sense, I'll change that.

For completeness, I'll add an additional patch to move the 'struct 
rt5033_battery' [1] to drivers/power/supply/rt5033_battery.c.

[1] 
https://github.com/torvalds/linux/blob/v6.4-rc1/include/linux/mfd/rt5033.h#L35-L40

Kind regards,
Jakob