Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp4884241rwr; Mon, 8 May 2023 14:17:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ66BABZdq8D970Ws2/fpWqyQYZmIV3e2Ih501sXtyMwp4BcnimwyIX0l5LLMDvqCiwsZIaX X-Received: by 2002:a17:903:2804:b0:1a6:d2af:5a3f with SMTP id kp4-20020a170903280400b001a6d2af5a3fmr10193846plb.3.1683580653607; Mon, 08 May 2023 14:17:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683580653; cv=none; d=google.com; s=arc-20160816; b=V7osavGCAbywzcSpSJbHvduNfj75BhUp0EfA4OKlmO6M4aO1XGYPC4HgXEwM0wTwrJ jTeaCwO+k5BWGgjPQz75zG0xvZgZPf4/0iade9LlhCwk2rLED2RdfLgaAWyKoFlkDOsl jpCGlSqO8PyY3hL8EAcf71VDZWsqRnkqJ+yc5tIaqsckcc+F6hvIb0AK5ReAS6QybGCi kkjG0wzzfkwCa5dS9iXMZUAYghKx8jgOMIFhIubM5QMmOPWpB20YyZ0K8rQeUwdAv5A6 MxyiR1YBXkXwoCd4KMT4p5TpJ7CyBGxbHSwsdoNG5a9SAeqlqXtdUM0lp06mDEdx1Muf DDEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=nwRH/Eci0fUlob74jM/8L/iMFTK4B+fFw1Sy70Vann4=; b=Ry86iGwPs4KhYwItioq4dQZjmGms+RCMLEeLPATkGIAIHbyu9dkooFZSdDR9YWBJIr 6+9Nbm6BYZshpQkfTkH001F8TVGe1RtPrBXC19h/nYWhuJh5FqPqiv8+mQ2cegcZCYU7 xhZDJGbkoVrGwFgfT/sE/ARHMnWP13Im/AQp1B2GnkBFmMpCMZYkOj0k/DQhZJrCYJ60 npMcn67Pd7Evg/q7UbX95mvzH91EA1LBEe52k4qpg4aWUbWpEo1FFJB1XCPvGsETSVdR UjNLIwni3nvd+FGn7ecb9uyqp/blqEurb3KEkVZ/cuwArwY1o50cLo263nbicAEksF8X SWOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@t-8ch.de header.s=mail header.b=VoeV7Tci; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mh5-20020a17090b4ac500b0024666c4e8d8si4945225pjb.187.2023.05.08.14.17.20; Mon, 08 May 2023 14:17:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@t-8ch.de header.s=mail header.b=VoeV7Tci; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233053AbjEHU5s (ORCPT + 99 others); Mon, 8 May 2023 16:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjEHU5r (ORCPT ); Mon, 8 May 2023 16:57:47 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FA38171C; Mon, 8 May 2023 13:57:46 -0700 (PDT) Date: Mon, 8 May 2023 22:57:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=t-8ch.de; s=mail; t=1683579464; bh=kqExthNR9GzxjMGAmc95qMqSGSf6hPUVTZc/Qo9LbYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VoeV7TciRKwlK+YAnRCqSzBWRs3uD6YcBWhTEL5OWw9ro3+rakQuZlHtXAae518AD jNQ2GdW+go4tBrVVRQAYx8vvD8xB/mQvN0yp2QQWI1IGXXP73gmBKP32z4r0noHhYJ 7LPiEYFtu6l9F3hU1Kbp2c5jit/stzPw7xxsW2ds= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jorge Lopez Cc: hdegoede@redhat.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 00/13] HP BIOSCFG driver Message-ID: <3bff7eeb-72ef-42c0-b569-cd93355ab7ed@t-8ch.de> References: <20230505220043.39036-1-jorge.lopez2@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505220043.39036-1-jorge.lopez2@hp.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jorge, On 2023-05-05 17:00:30-0500, Jorge Lopez wrote: > .../testing/sysfs-class-firmware-attributes | 117 ++- > MAINTAINERS | 6 + > drivers/platform/x86/hp/Kconfig | 16 + > drivers/platform/x86/hp/Makefile | 1 + > drivers/platform/x86/hp/hp-bioscfg/Makefile | 12 + > .../x86/hp/hp-bioscfg/biosattr-interface.c | 319 ++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 982 ++++++++++++++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 523 ++++++++++ > .../x86/hp/hp-bioscfg/enum-attributes.c | 482 +++++++++ > .../x86/hp/hp-bioscfg/int-attributes.c | 448 ++++++++ > .../x86/hp/hp-bioscfg/ordered-attributes.c | 443 ++++++++ > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 584 +++++++++++ > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 381 +++++++ > .../x86/hp/hp-bioscfg/string-attributes.c | 415 ++++++++ > .../x86/hp/hp-bioscfg/surestart-attributes.c | 133 +++ > 15 files changed, 4860 insertions(+), 2 deletions(-) > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c Unfortunately I'm not sure I'll find enough time this week for a full review of this revision. I'll review bit by bit as time permits. Thomas