Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e931004a-e8e3-5c27-cee7-ec3bba23fb3e@amd.com>
Date:   Mon, 8 May 2023 17:24:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
From:   Harry Wentland <harry.wentland@amd.com>
Subject: Re: [RFC PATCH 07/40] drm/amd/display: add CRTC gamma TF to
 driver-private props
To:     Melissa Wen <mwen@igalia.com>, amd-gfx@lists.freedesktop.org,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        sunpeng.li@amd.com, Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch
Cc:     Joshua Ashton <joshua@froggi.es>,
        Sebastian Wick <sebastian.wick@redhat.com>,
        Xaver Hugl <xaver.hugl@gmail.com>,
        Shashank Sharma <Shashank.Sharma@amd.com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        sungjoon.kim@amd.com, Alex Hung <alex.hung@amd.com>,
        linux-kernel@vger.kernel.org
References: <20230423141051.702990-1-mwen@igalia.com>
 <20230423141051.702990-8-mwen@igalia.com>
Content-Language: en-US
In-Reply-To: <20230423141051.702990-8-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUlvYmE0Y0ZTZGxaMHlidFRpVU0xYTVDQkF1cHI0THhWc1Mxa3RCQUN3bGt5?=
 =?utf-8?B?ZHlQRkdPckJkSExRcU1SNTRaUldJajM5bTZpcm9LVWI3ZVhBc3lpVDY3V2RG?=
 =?utf-8?B?MjV0Y1pySjY1Nm8yeGZYMG5PcDZWTU5LZFhJMGpTbU9Ya0c3NVlaY3hWWDRr?=
 =?utf-8?B?clZBU0VsdVV0ZkhOa2xoR2d4VjZLRWlKNjliYVFBeVV5Z0drL280ZHhvU1lW?=
 =?utf-8?B?N0xacUJOTW11VU1OWk5pVjF0ZytpRHJYejgrWVJDZ0hJVWdjZU8yb0F6aTNo?=
 =?utf-8?B?M3d5R01OVW9jRzdlL1p2WWdPMGhoWXU1Z21NWmFnanpEV3dnMSs0K1FrMWVu?=
 =?utf-8?B?TEx6SVA0aFdTbk5iZFlIWkRYN0xFdlExZWd6ZlVFVytvOXJwZUtWZFhkaFFt?=
 =?utf-8?B?cFJuZjI5bGgva0lZdjV3UE9YWkg0SCtQa2xJL3FSNjY1c2hBYUR0S2xDMDV0?=
 =?utf-8?B?dlB6V0w2b1JmVVZKQmFSSHJKRXB1YjdEL2s2NDMxdzh0OEFLODFaS1R3bHQ0?=
 =?utf-8?B?RUtDb2FzOVQvTCs1T1pLaUtBNDc1Ym5xWUQvMUhndHVZRWkreWVBQUtEUmYz?=
 =?utf-8?B?cGlmL0JvM0lPSEp2cXVlbW9aSnE5aWZRRUY2S2ZuSFBia1JicFBVeUVhQnAx?=
 =?utf-8?B?SnhCN3pMT2RldFI5Y0d6NHNvdk8zak1xTXd0UjVOU2FKelREK2xVeDF2QnJT?=
 =?utf-8?B?RGN0VHFqRGRCS01mSlQ0dStzOWgxbWQ1c3REWU9NVGNnUlhlZ3VKcWhNaXVD?=
 =?utf-8?B?cURZcE1YZS9sdGZwZFllT3Z4VTF5eEdqRERTNGcrOGYrUUk5VmRxRGJyWitZ?=
 =?utf-8?B?NHZIZnhHRjExaGRTYkx0QzE5TkhLVUFuelNhQUlSM3JlbTRWSlBoRVhlQU5o?=
 =?utf-8?B?bzlzcHhMTWJ0d0tLNDc0OHJZOElpZWw4YlJYK0h1UHRwQUUzYlpwUlk2VkE2?=
 =?utf-8?B?U3BOZjlDeERpUjh0WGZJbk1YOVdTL05YdDJIenN1UlUrc2p3RW1lcUIrbENL?=
 =?utf-8?B?dVl3Tk1NMUZuZEpHL3E4ZHNISElBT3N2ZHhWL0E3OU13ckVadGtRRWpEdk5E?=
 =?utf-8?B?SVhxZ3VQUE9tYlp5VG1GOTFORi9EZXkxNTNrRHdDMnpINjc3bXBFQ25ldGZS?=
 =?utf-8?B?Y21KM0U4enAvRWZOVnVmY2RXRE9oZGpxRVlqa1RNTGtNbG5idlIrdW1mS2NH?=
 =?utf-8?B?aXZGaCtVWmdLMGtJdFozcVluK1YvYm1DNzVjZTJEK2xldGRKTDhFbFRuamo0?=
 =?utf-8?B?b1llY0N1OUt0NWo4VVd5bmxQd3N5MmJ2QTVYOG10VW1aNWVxdTVVK0ZNZk1T?=
 =?utf-8?B?cG9HdzNUcGozbGpIMk1qaVdwbGlkeHFUNk9TTGR4SVU5Z1ZKb3Z2bFluWldL?=
 =?utf-8?B?TUs1YjJTaUZjLzlBNUVmRkM4V0M3cXlsTE9qUFhBb0s3Q1VHZVBSVDREZnpn?=
 =?utf-8?B?b1I0K1gwL1JtS1gwVXRVTmNwRGFFaWxtbG91WlYzMUc3cDR6ZHI0ZEFEY0Vq?=
 =?utf-8?B?NUdwWG51MlBMZi8vTnpPcTdKTWdYaTJaMDZCT05Qc2RkMTJPSUxtTkZKY2wv?=
 =?utf-8?B?bEwxV2xNMnhjWm80eGhhdlovKzhyTFRIZGdRRzVmV0RyWG4vSWp4a0h1MEpT?=
 =?utf-8?B?K2JiK0o0L0pYdUFaaVlmcVlWTHdZUGRKZmJ0WGVDckpuUXFhV0hxUHJubHkw?=
 =?utf-8?B?Y1pCRVQyK2w5NVBwcE1valR5d2pVM3VRQ2hTSjJDaEQyd1RYOUw4Mmc2eTh6?=
 =?utf-8?B?UDdYelZLVkdrVnUwMVNkNGczVE9TK1d3aU9vZUY0Y0xoZGxZRGJZVUR4a0pz?=
 =?utf-8?B?d1ZtS3dibXZrV0pqU1IwbVcvMDZrOUp1dE1DczQ1OGo4bHR5YVpRMk9jNXhN?=
 =?utf-8?B?MFRjV1hNWko1Rk8ydEtzQlZCY2dnWG85aGMraE10dlAreVZkaTRyUUk2WFBD?=
 =?utf-8?B?blcwVzE1dXpDZ1dCUjZzQWhlRUJiVzk1UzUxa1FOWmNlMlFMNVRYNkl1RmlY?=
 =?utf-8?B?SG1IbUJxVFlWUnNMa3RwUWdHSHpiNkRxd1B4QXBTTE1GN1lQMitaRWpDZjRX?=
 =?utf-8?B?OXQ1T3hzM0ZackhNdzhCMHZtMU5ieDNDcnpJTjN5M3pKVmFkQzRIeUs4NWtM?=
 =?utf-8?Q?yjZZFpGgj07qsWy1Nz2J8OcQ+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12cb1249-add6-4d1c-d23d-08db500aa7ef
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 21:24:50.2895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7WVsOc4SehJCpi1RnYLwEx35NFTz1ditXpkDVzHMAauxZNtqcaNEKxZVJz3ofaV46XwskHO01dJIWJv0ZMBGVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6676
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/23/23 10:10, Melissa Wen wrote:
> From: Joshua Ashton <joshua@froggi.es>
> 
> Add predefined transfer function property to DRM CRTC gamma to convert
> to wire encoding with or without gamma LUT.
> 

Are all these new CRTC properties used by gamescope? I would be reluctant
to merge them if they're currently not needed.

> Co-developed-by: Melissa Wen <mwen@igalia.com>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> Signed-off-by: Joshua Ashton <joshua@froggi.es>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   | 22 ++++++++++++++++++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |  4 ++++
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 23 +++++++++++++++++++
>  .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c    | 13 +++++++++++
>  4 files changed, 62 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 2abe5fe87c10..1913903cab88 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1248,6 +1248,19 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
>  }
>  
>  #ifdef CONFIG_STEAM_DECK
> +static const struct drm_prop_enum_list drm_transfer_function_enum_list[] = {
> +	{ DRM_TRANSFER_FUNCTION_DEFAULT, "Default" },
> +	{ DRM_TRANSFER_FUNCTION_SRGB, "sRGB" },
> +	{ DRM_TRANSFER_FUNCTION_BT709, "BT.709" },
> +	{ DRM_TRANSFER_FUNCTION_PQ, "PQ (Perceptual Quantizer)" },
> +	{ DRM_TRANSFER_FUNCTION_LINEAR, "Linear" },
> +	{ DRM_TRANSFER_FUNCTION_UNITY, "Unity" },
> +	{ DRM_TRANSFER_FUNCTION_HLG, "HLG (Hybrid Log Gamma)" },
> +	{ DRM_TRANSFER_FUNCTION_GAMMA22, "Gamma 2.2" },
> +	{ DRM_TRANSFER_FUNCTION_GAMMA24, "Gamma 2.4" },
> +	{ DRM_TRANSFER_FUNCTION_GAMMA26, "Gamma 2.6" },
> +};
> +

Would it be better to prefix things with AMD_/amd_ to avoid confusion? On the other
hand, these will likely just move into DRM core once we get the generic color uAPI.

Harry

>  static int
>  amdgpu_display_create_color_properties(struct amdgpu_device *adev)
>  {
> @@ -1281,6 +1294,15 @@ amdgpu_display_create_color_properties(struct amdgpu_device *adev)
>  		return -ENOMEM;
>  	adev->mode_info.lut3d_size_property = prop;
>  
> +	prop = drm_property_create_enum(adev_to_drm(adev),
> +					DRM_MODE_PROP_ENUM,
> +					"GAMMA_TF",
> +					drm_transfer_function_enum_list,
> +					ARRAY_SIZE(drm_transfer_function_enum_list));
> +	if (!prop)
> +		return -ENOMEM;
> +	adev->mode_info.gamma_tf_property = prop;
> +
>  	return 0;
>  }
>  #endif
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> index 205fa4f5bea7..76337e18c728 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
> @@ -368,6 +368,10 @@ struct amdgpu_mode_info {
>  	 * LUT as supported by the driver (read-only).
>  	 */
>  	struct drm_property *lut3d_size_property;
> +	/**
> +	 * @gamma_tf_property: Transfer function for CRTC regamma.
> +	 */
> +	struct drm_property *gamma_tf_property;
>  #endif
>  };
>  
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index 09c3e1858b56..1e90a2dd445e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -699,6 +699,23 @@ static inline void amdgpu_dm_set_mst_status(uint8_t *status,
>  
>  extern const struct amdgpu_ip_block_version dm_ip_block;
>  
> +#ifdef CONFIG_STEAM_DECK
> +enum drm_transfer_function {
> +	DRM_TRANSFER_FUNCTION_DEFAULT,
> +
> +	DRM_TRANSFER_FUNCTION_SRGB,
> +	DRM_TRANSFER_FUNCTION_BT709,
> +	DRM_TRANSFER_FUNCTION_PQ,
> +	DRM_TRANSFER_FUNCTION_LINEAR,
> +	DRM_TRANSFER_FUNCTION_UNITY,
> +	DRM_TRANSFER_FUNCTION_HLG,
> +	DRM_TRANSFER_FUNCTION_GAMMA22,
> +	DRM_TRANSFER_FUNCTION_GAMMA24,
> +	DRM_TRANSFER_FUNCTION_GAMMA26,
> +	DRM_TRANSFER_FUNCTION_MAX,
> +};
> +#endif
> +
>  struct dm_plane_state {
>  	struct drm_plane_state base;
>  	struct dc_plane_state *dc_state;
> @@ -751,6 +768,12 @@ struct dm_crtc_state {
>  	 * &struct drm_color_lut.
>  	 */
>  	struct drm_property_blob *lut3d;
> +        /**
> +	 * @gamma_tf:
> +	 *
> +	 * Pre-defined transfer function for converting internal FB -> wire encoding.
> +	 */
> +	enum drm_transfer_function gamma_tf;
>  #endif
>  };
>  
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> index 0e1280228e6e..79324fbab1f1 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> @@ -272,6 +272,7 @@ static struct drm_crtc_state *dm_crtc_duplicate_state(struct drm_crtc *crtc)
>  #ifdef CONFIG_STEAM_DECK
>  	state->shaper_lut = cur->shaper_lut;
>  	state->lut3d = cur->lut3d;
> +	state->gamma_tf = cur->gamma_tf;
>  
>  	if (state->shaper_lut)
>  		drm_property_blob_get(state->shaper_lut);
> @@ -336,6 +337,11 @@ dm_crtc_additional_color_mgmt(struct drm_crtc *crtc)
>  					   adev->mode_info.lut3d_size_property,
>  					   MAX_COLOR_3DLUT_ENTRIES);
>  	}
> +
> +	if(adev->dm.dc->caps.color.mpc.ogam_ram)
> +		drm_object_attach_property(&crtc->base,
> +					   adev->mode_info.gamma_tf_property,
> +					   DRM_TRANSFER_FUNCTION_DEFAULT);
>  }
>  
>  static int
> @@ -398,6 +404,11 @@ amdgpu_dm_atomic_crtc_set_property(struct drm_crtc *crtc,
>  					&replaced);
>  		acrtc_state->base.color_mgmt_changed |= replaced;
>  		return ret;
> +	} else if (property == adev->mode_info.gamma_tf_property) {
> +		if (acrtc_state->gamma_tf != val) {
> +			acrtc_state->gamma_tf = val;
> +			acrtc_state->base.color_mgmt_changed |= 1;
> +		}
>  	} else {
>  		drm_dbg_atomic(crtc->dev,
>  			       "[CRTC:%d:%s] unknown property [PROP:%d:%s]]\n",
> @@ -424,6 +435,8 @@ amdgpu_dm_atomic_crtc_get_property(struct drm_crtc *crtc,
>  	else if (property == adev->mode_info.lut3d_property)
>  		*val = (acrtc_state->lut3d) ?
>  			acrtc_state->lut3d->base.id : 0;
> +	else if (property == adev->mode_info.gamma_tf_property)
> +		*val = acrtc_state->gamma_tf;
>  	else
>  		return -EINVAL;
>