Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5122882rwr; Mon, 8 May 2023 18:51:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xS2R31FshwqmdvmmSIrw0c9EFgiVacrwL7ARrrJlSljRFN9Oi+QCUJPNXSUOkJ4Z1V2w5 X-Received: by 2002:a17:902:da8b:b0:1ac:7e95:74bf with SMTP id j11-20020a170902da8b00b001ac7e9574bfmr5221347plx.6.1683597095596; Mon, 08 May 2023 18:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683597095; cv=none; d=google.com; s=arc-20160816; b=MyzQkvwl/++MBHn+XBfqdztsW/IHLm1qpp37WlbgX60oEfi/FCCm5T3l381Volqj4m enlZTDSLNFHf9y2G+LXWHOUSMedsrQBqzVS1yEOTOOi7NPwAFxLdZaB7bYVNl8cynZfQ srnWSaL6GcgayjkKMIoVQvufxkI8go57j3SCk8yKKOkh1KKnyLn3AL55K22StH23+65s LTHxzu2hn4wHccqjA7Mzta2z+u/bITNA0WN91eqSyiVRRfY+Sq052vJdWbzj/vk2Ey2b BAFszP0CVF+yAFg+Vg7nCTdFDs5xRluAvwfZlLzc4HF28DP1Ui/lBquQXuXjCOnEJjJI 0+aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=qIV611p1+ZTTw9B8i6IsdKi+QxTKsNunG5msgD2y2NY=; b=c9EJ2UB6L164PtRu0F81d4D0hY6zx6bUs9AZDAjvodEGC0NCoV61dCBaLFfnibS+rR Gu3XX8ZnSyyOHzrD8RJctpr2uRS3NTejni98dSQkrIigrsOTUVlWADZjMelk/hDxJ9sR VM48nEv6bsQPaJC2TcFPMzvAWKwyae4neKFYCoL/UokKG75aVkkloAXYdjvaRaRh7wwr dqyoAsIwams4ziXOdAQTk6Z5/XkLWcnD0m/6riPDWM3R8dDfjznvgOW5OgqOlzZtb4/W U3idotOOlGw0xyBrIgFCkouILvpnCn111+bOdP1xBRmmAH9XcdkqVxLDZAKuS05v+tZc 0Alg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppo75Es8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k3-20020a170902760300b0019f3c9d839dsi289439pll.576.2023.05.08.18.51.21; Mon, 08 May 2023 18:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppo75Es8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232223AbjEIBqN (ORCPT + 99 others); Mon, 8 May 2023 21:46:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbjEIBqM (ORCPT ); Mon, 8 May 2023 21:46:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41C395B83 for ; Mon, 8 May 2023 18:46:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C86A46433F for ; Tue, 9 May 2023 01:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780DDC433EF; Tue, 9 May 2023 01:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683596770; bh=LMdyy4IWImsK1SA4AwNEk1jXTLpVOax2pWupABnOyyE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ppo75Es8pZDmR2UJFCljfloHMxHGWgtxDW2pQAfDljVapDchuX6aM8fMgcXKQCi1G 7eIoD9NBJ63bpTqPyHoqICqWlezZNenHATl6ATLsvkqEckVxZOa2dhJmu3vXN3lHTe 3ik9h2LZUz067Dy9nMHnLSHCJhQBsRC4TL3GhZ8ph8TiuBtoVpqpooQEliBW2gdc+A A8jTE3ubntK545W76Lh3jgVjXSxWLPrXEKY9LzFd5riajDWI4QA+x5FrF1nr7HOVjX vvaNbfbtvEVVMGnM/IDGHmQMYplUWGrMbi3tgNH4xN+2FtRRAqI9IdwEUiGrA2e5AG tEmXfM7drYI3Q== Date: Mon, 8 May 2023 18:46:08 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Clark Wang , NXP Linux Team , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Gagandeep Singh Subject: Re: [RESEND PATCH v4 net 1/1] net: fec: correct the counting of XDP sent frames Message-ID: <20230508184608.43376a10@kernel.org> In-Reply-To: <20230508143831.980668-1-shenwei.wang@nxp.com> References: <20230508143831.980668-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 May 2023 09:38:31 -0500 Shenwei Wang wrote: > In the current xdp_xmit implementation, if any single frame fails to > transmit due to insufficient buffer descriptors, the function nevertheless > reports success in sending all frames. This results in erroneously > indicating that frames were transmitted when in fact they were dropped. > > This patch fixes the issue by ensureing the return value properly > indicates the actual number of frames successfully transmitted, rather than > potentially reporting success for all frames when some could not transmit. > > Fixes: 6d6b39f180b8 ("net: fec: add initial XDP support") > Signed-off-by: Gagandeep Singh > Signed-off-by: Shenwei Wang Unfortunately the previous version was silently applied, it seems: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=26312c685ae0bca61e06ac75ee158b1e69546415 Could you send an incremental fix, on top of that patch? -- pw-bot: cr