Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 04:39:46 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     James Seo <james@equiv.tech>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: device.h: add some missing kerneldocs
Message-ID: <2023050929-referable-exponent-d4a1@gregkh>
References: <20230508154849.1946589-1-james@equiv.tech>
 <ZFkftcxqQRblDgzX@equiv.tech>
 <0a75a41e-6458-8f7a-67cd-89eb05eb822f@infradead.org>
 <ZFmnGGzcTPdrvJrn@equiv.tech>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZFmnGGzcTPdrvJrn@equiv.tech>
Precedence: bulk

On Mon, May 08, 2023 at 06:51:20PM -0700, James Seo wrote:
> On Mon, May 08, 2023 at 11:55:47AM -0700, Randy Dunlap wrote:
> > On 5/8/23 09:13, James Seo wrote:
> >> On Mon, May 08, 2023 at 08:48:50AM -0700, James Seo wrote:
> >>> Add the missing kerneldocs (except for DEVICE_ATTR_IGNORE_LOCKDEP(),
> >>> which is only meaningful on debug builds with CONFIG_DEBUG_LOCK_ALLOC
> >>> not #defined, and is aliased to DEVICE_ATTR() otherwise).
> >>>
> >>> Signed-off-by: James Seo <james@equiv.tech>
> >>> ---
> >> 
> >> I just noticed that there shouldn't be a "not" before "#defined" in the
> >> last line of the commit message. Apologies.
> >> 
> > 
> > Other than that (above), LGTM.
> > 
> > Tested-by: Randy Dunlap <rdunlap@infradead.org>
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> > -- 
> > ~Randy
> 
> Thanks for the review!
> 
> Just to be clear, that line should read "defined, and is aliased to..."
> as commit messages can't have lines that begin with '#'.

Please fix that up and send a new version please.

thanks,

greg k-h