Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62539831-1f8c-d908-bd7c-2a926702fa7f@infradead.org>
Date:   Mon, 8 May 2023 21:18:32 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH AUTOSEL 6.3 6/7] powerpc/fsl_uli1575: Allow to disable
 FSL_ULI1575 support
Content-Language: en-US
To:     Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Cc:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
        arnd@arndb.de, linuxppc-dev@lists.ozlabs.org
References: <20230509035455.59524-1-sashal@kernel.org>
 <20230509035455.59524-6-sashal@kernel.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230509035455.59524-6-sashal@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi--

Just a heads up. This patch can cause build errors.
I sent a patch for these on 2023-APR-28:
  https://lore.kernel.org/linuxppc-dev/20230429043519.19807-1-rdunlap@infradead.org/

Michael, I think this is your area if I'm not mistaken.


On 5/8/23 20:54, Sasha Levin wrote:
> From: Pali Rohár <pali@kernel.org>
> 
> [ Upstream commit 22fdf79171e8509db54599fd2c05ef0022ee83f5 ]
> 
> ULI1575 PCIe south bridge exists only on some Freescale boards. Allow to
> disable CONFIG_FSL_ULI1575 symbol when it is not explicitly selected and
> only implied. This is achieved by marking symbol as visible by providing
> short description. Also adds dependency for this symbol to prevent enabling
> it on platforms on which driver does not compile.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Link: https://msgid.link/20230409000812.18904-7-pali@kernel.org
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  arch/powerpc/platforms/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
> index d41dad227de84..608ac0290e3aa 100644
> --- a/arch/powerpc/platforms/Kconfig
> +++ b/arch/powerpc/platforms/Kconfig
> @@ -261,7 +261,9 @@ config CPM2
>  	  on it (826x, 827x, 8560).
>  
>  config FSL_ULI1575
> -	bool
> +	bool "ULI1575 PCIe south bridge support"
> +	depends on FSL_SOC_BOOKE || PPC_86xx
> +	select FSL_PCI
>  	select GENERIC_ISA_DMA
>  	help
>  	  Supports for the ULI1575 PCIe south bridge that exists on some

-- 
~Randy