Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 15:46:28 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Ravulapati Vishnu Vardhan Rao <quic_visr@quicinc.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "moderated list:QCOM AUDIO (ASoC) DRIVERS" 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC:codecs: lpass: Fix for KASAN use_after_free out of
 bounds
Message-ID: <ZFnsRJXEbajKxj3h@finisterre.sirena.org.uk>
References: <20230509061321.10218-1-quic_visr@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="POkgUCpmy5u6zSNw"
Content-Disposition: inline
In-Reply-To: <20230509061321.10218-1-quic_visr@quicinc.com>
Precedence: bulk


--POkgUCpmy5u6zSNw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 09, 2023 at 11:43:21AM +0530, Ravulapati Vishnu Vardhan Rao wrote:

>  	val = ucontrol->value.enumerated.item[0];
> +	if (val < 0 && val > 15) {
> +		dev_err(component->dev, "Wrong value for DMIC configuration");
> +		return -EINVAL;
> +	}

This allows userspace to spam the system logs, no error should be
printed for something like this which can be trivially triggered from
userspace.

--POkgUCpmy5u6zSNw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRZ7EQACgkQJNaLcl1U
h9DGcwf/cfo6G4f8hDzAGovnhM81PX6MSVusLCjspfaSjJvji4mpziG1QYfILtfZ
vX6/VfNu7+S1899tLmMyvV3nvbho8qQ6NbuV1JXtpgcRtZn4sr8BDkS1oECDGXUc
Ene58kkNvOOMHjwHR4Mm4MQJ/TY2mdoxBxesgj2qs6b8xvjbAVE+7In6FqzA8BuX
mOuKyde/h/Hitgld6a45RHIlP/sOatN/+e5Zmu3xuDFS6YAqgS2vOtP4Y5gm5SGN
ayZ+JNjsgQ7kYXEq6xB0fqSGhq6Cvja73Pq9FfNX2EqIATM/MIXBo6vTx5TAVHBb
t5cW6F8Wo+zoKe1BGoVt0h6d54mWOQ==
=ktQ6
-----END PGP SIGNATURE-----

--POkgUCpmy5u6zSNw--