Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5367936rwr; Mon, 8 May 2023 23:53:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7FenkhMzKvjW8tKPhTiVenACTR5csx0q7f18a6KlpGrFe8jChC6P3k/ANx+5XzXt2em5e1 X-Received: by 2002:a05:6a21:6d9e:b0:ed:1d7a:3339 with SMTP id wl30-20020a056a216d9e00b000ed1d7a3339mr17312793pzb.57.1683615235084; Mon, 08 May 2023 23:53:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683615235; cv=none; d=google.com; s=arc-20160816; b=ilhHOqZBVakxHVgAeo2NRGBKJG4OQXRc3GD6N2XaL2rbGh8+QToybWfIBmoc7W0cLO fvch+X6glXhBciXZb+edH8HB5FhHRoRDeg8BjjHwsTnxquzpCadThs81pkHAX0N/IeAs 8Cuwg/yq5IRRCHYeXtFAVkzfrEHItV3K+/R0KzUULxfJpe8nVcRYEjpxD0R3CDql7V/y Gj0jEqB/ffUGpjC2BCPnc+Php6ipq5O0cR3e7ibgVEzmdH9D7SPwWrMcm/jmxLqhlwU8 TXCvlZhwwnGk8dQxrCJcjUTzqCfZ/cXUXvcEtEzQWhhHmU/0Yj+bXcSkRSPFoi4jkBsv LopA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7XnYWiSDCD8npZgRcmZFhFf2e8eQq0KgcqWljx3Kh40=; b=fPiHfbm5D/LyznwABjJdTQtdWaHdoVnx243W4LfqcmNy4WRN7jk+UfNnm1Ev7+CnWU Q55NG6l2P0cazAnYk2WfvGJaBXYcIt86qfLnXvnSCDONB1Y6Y0mDnTedskYL1dzlMcc7 v1Jt6wnQbE/omFN9OA6DeY+eTc1AMB/o8pcW/COBVSM6L9axUlZLcDHqxs6qIb3rABnV x0X+MP/HANWFYb9856JQJbdHxntbzUpiYuGokW0vk/LrupAeIEQSwDNczh0DU8x36hh+ hAsYOD7pHkp45FxLl8VMhxmfGeNe9BGakniX3sU2e4Q6M+OHJuvH8O2GbuZctA+6R1DZ NWHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="G/dD+U3i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v71-20020a63894a000000b00524f08d75f5si846715pgd.567.2023.05.08.23.53.40; Mon, 08 May 2023 23:53:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="G/dD+U3i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234939AbjEIGla (ORCPT + 99 others); Tue, 9 May 2023 02:41:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234916AbjEIGl3 (ORCPT ); Tue, 9 May 2023 02:41:29 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3115DAD35; Mon, 8 May 2023 23:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683614471; x=1715150471; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9PGhDpF0Ehm92gwScDb0cpgrpvmpX0MTZeTBVtGjmEI=; b=G/dD+U3iatmwcqSIvgNJsyrdH3S0SmZDRJMPfy1J7b2qT0jWotFwztXK PQuJaWzUgu6InMrsaOjlGWY0+Wui/oWDl3DRQM1JWlIUpPsO5yoG7HSSI bR7g+8GUhKu6Mvmuz5gnv2LV5A6BUgQWhAlH6ujxxsZZ9y5GjNtdYB5OX 6ZmZVTAId8K8hKRcC1CzfTvFCiVnZR44zMGmHF5yXeVo1WfNmeR8hAN4m 4hempkVw14XWXIhbNVgDMbKmpt4pvNya7MzxVB7m6vCPMKCzyj155fGWv JGfGoFWDVNU/bJ+QMserEVxOuaGKW4RK1eJlqV1Aw4LSPrgIS2mmzW0Rc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="329443412" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="329443412" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 23:41:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="873049819" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="873049819" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 08 May 2023 23:41:07 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 7EE9923E; Tue, 9 May 2023 09:41:16 +0300 (EEST) Date: Tue, 9 May 2023 09:41:16 +0300 From: Mika Westerberg To: Mario Limonciello Cc: Andreas Noever , Michael Jamet , Yehezkel Bernat , S Sanath , richard.gong@amd.com, Sanju.Mehta@amd.com, Takashi Iwai , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] thunderbolt: Clear registers properly when auto clear isn't in use Message-ID: <20230509064116.GM66750@black.fi.intel.com> References: <20230424195556.2233-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230424195556.2233-1-mario.limonciello@amd.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mario, On Mon, Apr 24, 2023 at 02:55:54PM -0500, Mario Limonciello wrote: > When `QUIRK_AUTO_CLEAR_INT` isn't set, interrupt masking should be > cleared by writing to Interrupt Mask Clear (IMR) and interrupt > status should be cleared properly at shutdown/init. > > This fixes an error where interrupts are left enabled during resume > from hibernation with `CONFIG_USB4=y`. > > Fixes: 468c49f44759 ("thunderbolt: Disable interrupt auto clear for rings") > Reported-by: Takashi Iwai > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217343 > Signed-off-by: Mario Limonciello Applied to fixes, thanks!