Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57453f01-ac47-b683-7296-2e6b7275edd1@intel.com>
Date:   Tue, 9 May 2023 14:56:57 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [linus:master] [mm/mmap] 28c5609fb2: aim9.page_test.ops_per_sec
 -10.8% regression
Content-Language: en-US
To:     kernel test robot <yujie.liu@intel.com>,
        Liam Howlett <liam.howlett@oracle.com>
CC:     <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
        <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yu Zhao <yuzhao@google.com>, <linux-mm@kvack.org>,
        <ying.huang@intel.com>, <feng.tang@intel.com>
References: <202305061457.ac15990c-yujie.liu@intel.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <202305061457.ac15990c-yujie.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2o5SWhpbFZaSG9aQU9VRllDNjIxcXpmK1gzZVY1NGtDMlBmNkNVQk1lWWtT?=
 =?utf-8?B?dzNXVGpmZ0QrSGRSc0lqUkIySXBQZkVHL0RZTHloL29Ub0gxMEw1Rmd6Nkt2?=
 =?utf-8?B?aWd0cnRJYzQ3NEttM2RuZG1LVDZ6ZENOL1cwOFZ3VDdhM2FjWDZEenZSYU95?=
 =?utf-8?B?V2lVUHNYcmRpK202aml4UWwwbkxwUkxBK2ZldTdWdEFMcTJkVXErZ2gwNjFh?=
 =?utf-8?B?bTdhanhMazNBRXhCa3BqUFVPdDZuUlR1ZjRsSTl1WXZiYUtnRnBkbnc0WEhw?=
 =?utf-8?B?eTVGZmd4M1V6M1VFMTdnR3h5TEJ1ZmxlTlZxb0RjdTNoek1WeXFoeFJOUHJv?=
 =?utf-8?B?YjFLM08wUGZMbXdQL1ZLYUpBVzQ3SG5iK2pKSndKZDFFeEZjdVhERC9OUFhl?=
 =?utf-8?B?WDk3a0UzZ1hsVFZmSDEzbEwyaUUyVjVndEFpY2RYeXdZQ1haU1RlSVdORkox?=
 =?utf-8?B?UXdLSW1iQXYyR1FlcWtYb1VJeXZqdUlaQ3Y1TTM4YmdKbmRsWk90eWlaREV2?=
 =?utf-8?B?cWF0ZFlHT2NSeTgzcDgrMWZQOXZmZ1U0WlR5ZkxtYzlyeUFxQXdpbmxTVWJR?=
 =?utf-8?B?ZTV2M2JYMndHK0cvN1ByUU91Q1h1SStIcU5COGhvRlE2NWxCbERjbTBSdUlv?=
 =?utf-8?B?M0tPMEJxUzc2SkVrTmJlUFl1ZUh0TjY2T1F6dURXN245M3lwbEdPZG1mc2g2?=
 =?utf-8?B?Y0F5MnFCbURNVDRXbENSazY1Z0ZaZjYrendxbU9aSEo3a2M1R0U5Vk5tZDZw?=
 =?utf-8?B?T3RhNW8vMDMyTTg3RkJVVmJ2VGRyUnV5RktTNnEvNVdHWWsrR0hpbkxqSXkx?=
 =?utf-8?B?RisxcWs2VXR0Y25sTUhhZ3FadXl1eUJua0N1QTJtNkRSMzV4c0xDek5yenlu?=
 =?utf-8?B?eVltbWc5OE1Ca01kUGF0UFlOUEpVSDNWanNDb2U0RWcrQXQvN1hZZFJFWSto?=
 =?utf-8?B?aXZOcWR6cUVPODJJUkRsMWdIak84NkpQSUcwZWdMLzRDeWxRWXJxazY4V2Zy?=
 =?utf-8?B?R1dlK0pRcmxtbnFkeG1MMUlrSHV4UDdtQ0VBczV5OU1KTzZqL2Yzdzg5UFFi?=
 =?utf-8?B?L0VBUG9nUHFsMDV0eGw5NVp5R0lVTXQ4M2xTR3ducU5QWFh1RW55SUJFS2hi?=
 =?utf-8?B?UzRvVVNSYXgwZER3bzdadTJKT25PbnRPc2ZzMGNPd0s1MmJISlpyUUN5TDJZ?=
 =?utf-8?B?NTlGaDJaTTgrZ21aZHJ0M2Ywc0xoa3duNXhKZVd0NmlmaDhUbHlPRm5aRWJI?=
 =?utf-8?B?VU1LUDN1MUtTNlUzZEhOMmlpalhtaHJFZ0NnMklrWUo5TkNoVUcvY1UvRjdu?=
 =?utf-8?B?UmQzWUttaVJiWFJYMy9EVXVucjQ4UkRxNGF3NXVxVzJMVkxXWmd2UlZkcnBQ?=
 =?utf-8?B?RVpSS1hubG5IRU53cUJEMXJCcndRc3FyWENJMXljRU9Helo2Vy9GWEp0eEtq?=
 =?utf-8?B?RjBTVUhzdVY4RnNZck1WRmtNNzZKVkNpcktEWHlqb1ZMYzROOTRSdUxtYjF5?=
 =?utf-8?B?NlZWVHRWMlQzQ05rOTJQTkVvNzUwTnhRTEdBMklEd3lMWXVEbHJuV2sybER1?=
 =?utf-8?B?eUtoOTd1V1huSjM0ZFJIVytZR2J5dnZmeW9MZkJQVU94eVdMQ21TcWZHSDRp?=
 =?utf-8?B?YlJqYjBMZDY4QzExTjM0aFpKblltcGV2N0htZFhkUEgweFN2cU1mUjZ4Njk4?=
 =?utf-8?B?enJnc1pkYVBUaFB2TTZFUjhYWi9VajBHakpKbGhKODBkL3J3VFFUcEloM0Fo?=
 =?utf-8?B?K09yVFVmRHMyRnZkbjQvK0hHZEFVMC9CZkRPZ000VUFBeUhnNlp1MjlLM04x?=
 =?utf-8?B?TjZ6MnEyTkJjWG9XTVMxeitpS25xdkpteDFjdENMYWNTVmdtY0NGNkptNW80?=
 =?utf-8?B?eDlMQ0dZWUJvcGtIUG5JQm9UZVhINVRMd0FNOFdqYU80eXVEWUtTNktMZmwv?=
 =?utf-8?B?ZlZib0NpSFRjRTBDT1hUbTJMUTlrVFdOSnFIMm1mVVh0V0tGU05RUEh6QzhI?=
 =?utf-8?B?ZnB4L1NJQkUvcEwzS1ZBaWwyQ2lBSnlmMEEzMDg5cGVxRlVoRkdnKzd0VTA0?=
 =?utf-8?B?NnNtb05vRXU0ejdDeis1M3ZoZlhuRGhaeUxFbEVTOExQOUF6Qkkyc2ZueEQ2?=
 =?utf-8?Q?ogSevF7DbWw4fGVUAWJggbBsA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ded1066-e76b-45ac-921a-08db505a6fc5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 06:55:55.8875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7X3wvg0v3rMiWBm7sydUc1NlXEpFMz8ycVmgkvsmfU5vpMI40U1qdOmVVy2wJPvayufQ4ulJ90NmFhw1Q8149w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6268
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Liam,

On 5/6/23 14:20, kernel test robot wrote:
> Hello,
> 
> kernel test robot noticed a -10.8% regression of aim9.page_test.ops_per_sec on:
> 
> commit: 28c5609fb236807910ca347ad3e26c4567998526 ("mm/mmap: preallocate maple nodes for brk vma expansion")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> testcase: aim9
> test machine: 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz (Ivy Bridge-EP) with 112G memory
> parameters:
> 
> 	testtime: 5s
> 	test: all
> 	cpufreq_governor: performance
> 
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <yujie.liu@intel.com>
> | Link: https://lore.kernel.org/oe-lkp/202305061457.ac15990c-yujie.liu@intel.com
> 

Some finding related:
   eBPF funclatency tool says the latency of function do_brk_flags() doubles
   with the patch 28c5609fb2.

   With the patch 28c5609fb2, the mas_alloc_nodes() is called much more than
   without the patch.

   In my local debugging env, I can see around 17009999 times call to 
   mas_alloc_nodes(). The number is zero without the patch 28c5609fb2.
So we are kind of sure the regression is connected to the patch.


The page_test of AIM9 is doing following work with single thread:
        newbrk = sbrk(1024 * 1024);     /* move up 1 megabyte */                
        while (true) {                   /* while not done */                    
                newbrk = sbrk(-4096 * 16);      /* deallocate some space */     
                for (i = 0; i < 16; i++) {      /* now get it back in pieces */
                        newbrk = sbrk(4096);    /* Get pointer to new space */ 
		}
	}

Is it possible that the sbrk pattern triggers the corner case? Thanks.


Regards
Yin, Fengwei