Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fdea3d7d-b8a8-620c-6cfb-aee3600fa5a8@linaro.org>
Date:   Tue, 9 May 2023 09:04:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCHv2 6/6] arm64: dts: socfpga: add hwmon properties
Content-Language: en-US
To:     dinh.nguyen@linux.intel.com, linux-hwmon@vger.kernel.org
Cc:     dinguyen@kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-kernel@vger.kernel.org, jdelvare@suse.com, linux@roeck-us.net
References: <20230508212852.8413-1-dinh.nguyen@linux.intel.com>
 <20230508212852.8413-6-dinh.nguyen@linux.intel.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230508212852.8413-6-dinh.nguyen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/05/2023 23:28, dinh.nguyen@linux.intel.com wrote:
> From: Dinh Nguyen <dinh.nguyen@linux.intel.com>
> 
> Add the hardware monitoring properties for Stratix10 and Agilex.
> 
> Signed-off-by: Dinh Nguyen <dinh.nguyen@linux.intel.com>
> ---
> v2: add platform specific platforms to DTS files
> ---
>  .../boot/dts/altera/socfpga_stratix10.dtsi    |  4 ++
>  .../dts/altera/socfpga_stratix10_socdk.dts    | 31 +++++++++
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi |  4 ++
>  .../boot/dts/intel/socfpga_agilex_n6000.dts   | 66 +++++++++++++++++++
>  .../boot/dts/intel/socfpga_agilex_socdk.dts   | 66 +++++++++++++++++++
>  .../dts/intel/socfpga_agilex_socdk_nand.dts   | 66 +++++++++++++++++++
>  .../boot/dts/intel/socfpga_n5x_socdk.dts      | 47 +++++++++++++
>  7 files changed, 284 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index 41c9eb51d0ee..2526afa687d6 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -633,6 +633,10 @@ svc {
>  				fpga_mgr: fpga-mgr {
>  					compatible = "intel,stratix10-soc-fpga-mgr";
>  				};
> +
> +				hwmon: temp-volt {

Node names should be generic, so maybe just hwmon.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +					compatible = "intel,socfpga-stratix10-hwmon", "intel,socfpga-hwmon";

Test your bindings. Your bindings or this part do not match at all.
Driver does not match it either.

Best regards,
Krzysztof