Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 09:46:51 +0200
From:   Cyril Brulebois <kibi@debian.org>
To:     Jim Quinlan <jim2101024@gmail.com>
Cc:     linux-pci@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Phil Elwell <phil@raspberrypi.com>,
        bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ#
 mode
Message-ID: <20230509074651.ixcqhhmazjngxur6@mraw.org>
Organization: Debian
References: <20230508220126.16241-1-jim2101024@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5ogfywygslxit6od"
Content-Disposition: inline
In-Reply-To: <20230508220126.16241-1-jim2101024@gmail.com>
Precedence: bulk


--5ogfywygslxit6od
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jim,

Jim Quinlan <jim2101024@gmail.com> (2023-05-08):
> v5 -- Remove DT property "brcm,completion-timeout-us" from	=20
>       "DT bindings" commit.  Although this error may be reported	=20
>       as a completion timeout, its cause was traced to an	=20
>       internal bus timeout which may occur even when there is	=20
>       no PCIe access being processed.  We set a timeout of four	=20
>       seconds only if we are operating in "L1SS CLKREQ#" mode.
>    -- Correct CEM 2.0 reference provided by HW engineer,
>       s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
>    -- Add newline to dev_info() string (Stefan)
>    -- Change variable rval to unsigned (Stefan)
>    -- s/implementaion/implementation/ (Bjorn)
>    -- s/superpowersave/powersupersave/ (Bjorn)
>    -- Slightly modify message on "PERST#" commit.
>    -- Rebase to torvalds master

Same results as with v4: looks good to me!

Using an official CM4 IO Board, I've successfully tested the same 9
setups as before, combining each:
 - CM4 Lite Rev 1.0
 - CM4 8/32 Rev 1.0
 - CM4 4/32 Rev 1.1

with each off-the-shelf PCIe/USB adapter at my disposal:
 - SupaHub PCE6U1C-R02, VER 006
 - SupaHub PCE6U1C-R02, VER 006S
 - Waveshare based on VIA VL805/806

Each system boots successfully, exposes the Kingston memory stick
plugged onto the PCIe/USB adapter, and happily reads data from it.

Note: I only tested each CM4 with the upgraded EEPROM (2023-01-11),
and without tweaking the DTB (i.e. without adding brcm,enable-l1ss).


Tested-By: Cyril Brulebois <cyril@debamax.com>


Cheers,
--=20
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

--5ogfywygslxit6od
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmRZ+mgACgkQ/5FK8MKz
VSCWQA/8C/o/6Lqq9PIxjWkSNDHEMmI/V+x09sfj0zDIX+56AVJmlYW9PbUrRM+b
yXjmElnr++pl2ECeXyGgocO3YIfxKqNH+06/2xplScb9PlIfXwiyf5p6uxhiFoTn
ROH6QqM17MUl3Fv1zYZfvB/AQqAfhi5Fx4kepc3I2wLxZREl6f627+xJ5R7p9bfe
e4UnFTpQht4CVZj7HJ9KXsTibpeqzR79CnjX9iyFmYcDWSqHQ0jiM9glG6/HgbHp
wMRHyswZp7sLsDTSkk31pL+VXSRFF5ABGeITw52LJnjNh+i8TYZbxpuYlPP4MlUo
HzegbF2DdJDFssNkxXeBNRe7L5a82B2Bx5SW+DHNB5dmtaCQrM+2FzV5mBubba/L
gEsbNLYngQZCoS3jV09mqc56dSpp7B+EC2IoDuJkhFqCB3UjLvimzM9CGDdM5Jm7
NbQeeo9RUbdEOv9GLQwimp+h7S7N38XMnpTqDol0XQyYOMBRl5Ploi7JJwbGt6N7
VvyTh5tGVtXycIDJ/+Gwy1RUIokMqHns+FPbJSig7oMdttz6GDk0Hr1QctFtN9CL
3F61fVxJ+8QsXyrUtcnEPM6F9AmRJAtekOl4EjhJWlWlmXUkYwbcoKquzOUhJd1X
OYLCHVj4DIA4NlXtump3gi68cW+SxUl/H2o0lBF27vLWGPKBlMU=
=m9/Z
-----END PGP SIGNATURE-----

--5ogfywygslxit6od--