Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] LoongArch: Select HAVE_DEBUG_KMEMLEAK to support kmemleak
To:     Youling Tang <tangyouling@loongson.cn>,
        Catalin Marinas <catalin.marinas@arm.com>
References: <1683614971-10744-1-git-send-email-yangtiezhu@loongson.cn>
 <68984bbb-4ccc-51f8-7d4b-b1ae08a43c52@loongson.cn>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <d1256c93-1c70-c3ff-de71-42405d336cac@loongson.cn>
Date:   Tue, 9 May 2023 15:43:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <68984bbb-4ccc-51f8-7d4b-b1ae08a43c52@loongson.cn>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Cc: Jonathan Corbet <corbet@lwn.net>
     linux-doc@vger.kernel.org

On 05/09/2023 03:13 PM, Youling Tang wrote:
> Hi, Tiezhu
>
> On 05/09/2023 02:49 PM, Tiezhu Yang wrote:
>> We can see that DEBUG_KMEMLEAK depends on HAVE_DEBUG_KMEMLEAK after
>> commit b69ec42b1b19 ("Kconfig: clean up the long arch list for the
>> DEBUG_KMEMLEAK config option"), just select HAVE_DEBUG_KMEMLEAK to
>> support kmemleak on LoongArch.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>>
>> This is based on 6.4-rc1
>>
>>  arch/loongarch/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
>> index d38b066..1e64edd 100644
>> --- a/arch/loongarch/Kconfig
>> +++ b/arch/loongarch/Kconfig
>> @@ -90,6 +90,7 @@ config LOONGARCH
>>      select HAVE_ASM_MODVERSIONS
>>      select HAVE_CONTEXT_TRACKING_USER
>>      select HAVE_C_RECORDMCOUNT
>> +    select HAVE_DEBUG_KMEMLEAK
>>      select HAVE_DEBUG_STACKOVERFLOW
>>      select HAVE_DMA_CONTIGUOUS
>>      select HAVE_DYNAMIC_FTRACE
>>
>
> At the same time, you need to modify the loongarch in arch-support.txt
> to ok.
>
> BTW, we can submit a separate patch to modify the features already
> supported by LoongArch.
>
> The following features are already supported in LoongArch.
>
> diff --git
> a/Documentation/features/debug/kprobes-on-ftrace/arch-support.txt
> b/Documentation/features/debug/kprobes-on-ftrace/arch-support.txt
...
> diff --git a/Documentation/features/debug/kprobes/arch-support.txt
> b/Documentation/features/debug/kprobes/arch-support.txt
> index 8a77d62a42c5..aad83b57587a 100644
> --- a/Documentation/features/debug/kprobes/arch-support.txt
> +++ b/Documentation/features/debug/kprobes/arch-support.txt
...
> diff --git a/Documentation/features/debug/kretprobes/arch-support.txt
> b/Documentation/features/debug/kretprobes/arch-support.txt
> index cf4723c5ac55..61380010a4a7 100644
> --- a/Documentation/features/debug/kretprobes/arch-support.txt
> +++ b/Documentation/features/debug/kretprobes/arch-support.txt
...
> diff --git
> a/Documentation/features/debug/stackprotector/arch-support.txt
> b/Documentation/features/debug/stackprotector/arch-support.txt
> index 71cd4ba18f7d..4c64c5d596f7 100644
> --- a/Documentation/features/debug/stackprotector/arch-support.txt
> +++ b/Documentation/features/debug/stackprotector/arch-support.txt

Thank you, I have already prepared a patch to update the docs,
but some more features will be added on LoongArch in the following
merge window, I am not sure what is the proper time to send the
following patch, maybe two months later, or right away, maybe
Jonathan can give some suggestions.

Documentation/features: Refresh LoongArch support files

Run the refresh script [1] to document the recent feature additions
on LoongArch.

[1] Documentation/features/scripts/features-refresh.sh

Thanks,
Tiezhu