Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230427123314.1997152-1-joychakr@google.com> <20230427123314.1997152-5-joychakr@google.com>
 <ZFj2QraXvNqBRwqM@finisterre.sirena.org.uk>
In-Reply-To: <ZFj2QraXvNqBRwqM@finisterre.sirena.org.uk>
From:   Joy Chakraborty <joychakr@google.com>
Date:   Tue, 9 May 2023 13:55:41 +0530
Message-ID: <CAOSNQF1PAh-Z=smRrqscpdPdEjyE-3Qd9iXVWNBZ2NkPv4M9Wg@mail.gmail.com>
Subject: Re: [PATCH v9 4/5] spi: dw: Add DMA address widths capability check
To:     Mark Brown <broonie@kernel.org>
Cc:     Serge Semin <fancer.lancer@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        manugautam@google.com, rohitner@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 8, 2023 at 6:46=E2=80=AFPM Mark Brown <broonie@kernel.org> wrot=
e:
>
> On Thu, Apr 27, 2023 at 12:33:13PM +0000, Joy Chakraborty wrote:
> > Store address width capabilities of DMA controller during init and chec=
k
> > the same per transfer to make sure the bits/word requirement can be met=
.
> >
> > Current DW DMA driver requires both tx and rx channel to be configured
> > and functional hence a subset of both tx and rx channel address width
> > capability is checked with the width requirement(n_bytes) for a
> > transfer.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/spi/spi-dw-dma.c: In function =E2=80=98dw_spi_=
dma_caps_init=E2=80=99:
> /build/stage/linux/drivers/spi/spi-dw-dma.c:100:1: error: control reaches=
 end of non-void function [-Werror=3Dreturn-type]
>   100 | }
>       | ^
> cc1: some warnings being treated as errors

Moving "return 0" at the end of dw_spi_dma_caps_init() from patch
[4/5] to patch [3/5] to solve this and sending a V10 Patch.

Thanks
Joy