Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f15c555-a33d-9be1-2889-78627d37bedf@6wind.com>
Date:   Tue, 9 May 2023 10:17:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Reply-To: nicolas.dichtel@6wind.com
Subject: Re: [PATCH v11 8/8] vhost: use vhost_tasks for worker threads
Content-Language: en-US
From:   Nicolas Dichtel <nicolas.dichtel@6wind.com>
To:     Mike Christie <michael.christie@oracle.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Christian Brauner <brauner@kernel.org>
Cc:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, ebiederm@xmission.com,
        konrad.wilk@oracle.com, linux-kernel@vger.kernel.org
References: <20230202232517.8695-1-michael.christie@oracle.com>
 <20230202232517.8695-9-michael.christie@oracle.com>
 <aba6cca4-e66c-768f-375c-b38c8ba5e8a8@6wind.com>
 <CAHk-=wgadfsCnKHLON7op=Qs5t3w3PVz5ZDbvbKsfb=yBg=yjQ@mail.gmail.com>
 <78c5e150-26cf-7724-74ee-4a0b16b944b1@oracle.com>
 <172df925-48ae-bc25-81fc-a2d6b39b8739@6wind.com>
Organization: 6WIND
In-Reply-To: <172df925-48ae-bc25-81fc-a2d6b39b8739@6wind.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 09/05/2023 à 10:09, Nicolas Dichtel a écrit :
> Le 06/05/2023 à 00:37, Mike Christie a écrit :
> [snip]
>> (Nicolas, I confirmed it fixes the 'ps a' case, but couldn't replicate the 'ps'
>> case. If you could test the ps only case or give me info on what /usr/bin/example
>> was doing I can replicate and test here):
> With you patch:
> $ ps a
>   PID TTY      STAT   TIME COMMAND
>   191 ttyS0    Ss     0:00 /bin/sh -li
>  1255 ttyS0    SLl    0:53 /usr/bin/example
>  1742 ttyS0    R+     0:00 ps a
> $ ps
>   PID TTY          TIME CMD
>   191 ttyS0    00:00:00 sh
>  1743 ttyS0    00:00:00 ps
Sorry, this is wrong, here is the right screenshot:
$ ps
    PID TTY          TIME CMD
    538 ttyS0    00:00:00 login
    573 ttyS0    00:00:00 bash
   8282 ttyS0    00:00:04 example:2
   8825 ttyS0    00:00:00 ps
$ ps a
    PID TTY      STAT   TIME COMMAND
    538 ttyS0    Ss     0:00 /bin/login -p --
    540 tty1     Ss+    0:00 /sbin/agetty -o -p -- \u --noclear tty1 linux
    573 ttyS0    S      0:00 /bin/bash -li
   8282 ttyS0    RLl    0:05 /usr/bin/example
   8829 ttyS0    R+     0:00 ps a

It fixes the issue.


Thank you,
Nicolas