Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5508164rwr; Tue, 9 May 2023 02:26:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6OonWa2eMEp3F0wrswvUVr3vf8Q4x6jaJPp84I7RIWXIxx8ArjAuCctmHzy3tAG2lrDlYB X-Received: by 2002:a05:6a21:6da3:b0:101:438d:2567 with SMTP id wl35-20020a056a216da300b00101438d2567mr2158476pzb.31.1683624390758; Tue, 09 May 2023 02:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683624390; cv=none; d=google.com; s=arc-20160816; b=SCl7vSxrSSoF/e/mXdJg4LvuKgn7xQlsMikvb8QFVCtpMzynRPft9JCmCJZIdzPXoA uQGBmVYwLIbYZsRwRz9K+v85PqAelmchhzLFXpNnAkC1q/+aIv//ciHH0I6VHmMN1kJR tbJo+TdEDQOeKUjnxre+KviX/R5Z2TAJkNbE/ddANSWqRYxTnIW94Oud21Pjvylm0FR0 RkEcSGEorEv8CXgQGqkYUifSKRpo/JhVL8QHMGMqcopWPB06htBpBT+ODX4mbhUs7ZB/ ylF9Ph4lEt+MNcEq9yPOPN3XGOyImBcYuRkGoHhAe7cDhLX6F9B5/mppi+vUseeefzdi O+bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=IraX+oUBLwvjqiInA0j8uPl6x32yOtC/TKYx6LHl7NM=; b=ii6CzkfB8KsQzSuixnJukOvQXgvADt8KmynKsRloEYPTpa53U/C8SYeQGBLuECb1Zs +VG89fGQtUtRz6Lihn9d+khBJ52ykJ957ZsLRojNxERgdKt1XZbRBL0F8pkQJO/mreg0 5fB+Rz6m+8912rB7QT2pcXegd89qG+SsyTxJdTpeeeHnG6EzYowgbGwqtrOtWGrEd1kz mXL/ddufEud2Qher47CuzEBWG5VjDIWTLB45L3nL0qg2ybiphsPPq6XsOBHYugdPQTO1 5CC/UmJd4AgDCJl2ewNdk/O332lTQulInkG2V56wDuT92eFgzfDeVJLq3PjTNxibaFTy IWlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=BLgnfB+P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l187-20020a6391c4000000b005130f15c5b1si1124141pge.363.2023.05.09.02.26.13; Tue, 09 May 2023 02:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=BLgnfB+P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234483AbjEIIvY (ORCPT + 99 others); Tue, 9 May 2023 04:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233820AbjEIIvU (ORCPT ); Tue, 9 May 2023 04:51:20 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64E5A2D78 for ; Tue, 9 May 2023 01:51:18 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-3f38a9918d1so82981cf.1 for ; Tue, 09 May 2023 01:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683622277; x=1686214277; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IraX+oUBLwvjqiInA0j8uPl6x32yOtC/TKYx6LHl7NM=; b=BLgnfB+PuGcbYmgEOPPmpjUx2YJHLULGn7h+bbr4+wdFwvgdYKdJkIZnX/xWFvmk4+ acrXlWH6YS3jtuWkMhYWrOpI+JTot/uZ8ywxUXtxGnfzvMYlscQzw3ZjN5yxpMdOHpJF 4t1Q/s6kedVAlxQPil8ZnhgWDWB6z1k0HuFpisZLHj+7c2u17bkb64u6UOimgJ5lqpd4 9KCJrtHdxVY6ggT2DVru491nXjhjH2+zvUuKCN+3ezyImS/FPrnDqqg0NkNcbCISFIJw Iu1frp3INjfXlgCX1stSwSActYiO4ZiPmx6m1NrglJKAdNm3YYUpAzQ0MxXft4fviDcZ vXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683622277; x=1686214277; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IraX+oUBLwvjqiInA0j8uPl6x32yOtC/TKYx6LHl7NM=; b=O7VcJKRPhQmwJDJW65Md9G38qWIqDxBVtxjDui2247Jd3tJcdHfysZmB82NjxeEBDq oFZKCjE8lWD8vTn6jgToUfGbeTYCw0z0wfKcf+DGAKCZKn5M1F7UrVqPLE5drwN4J7JG egnekUkNKefV7U5U0q8gq6mk5SAGs4iP32GnuBq/TsW6d8tH6C4rBCBhjaKlrhfOh8Ab YP6Z1fM2ml5CWVachjaLJz8+7oyZn9umQVM/QwvN46VYBDq5ncO1ndKIj/ut/uuuMm6l dh0wuxIQvFmVyse7FXm/gtCuZgs0gC9a9mNHUtPEIEyBUq2eW1B5KKf9m7ZCoj5CGS6e zlRQ== X-Gm-Message-State: AC+VfDyHvw+q4bX72QjmzCUdvC2E8jyys2j8HBdo6/ABW5giaLlDIk3l 4I+fcWoQQ9irrwbLwJHZ/ZkCH8scBud7MEbtkad0Aw== X-Received: by 2002:a05:622a:130e:b0:3ed:86f6:6eab with SMTP id v14-20020a05622a130e00b003ed86f66eabmr338833qtk.14.1683622277300; Tue, 09 May 2023 01:51:17 -0700 (PDT) MIME-Version: 1.0 References: <20230509071207.28942-1-lukas.bulwahn@gmail.com> In-Reply-To: <20230509071207.28942-1-lukas.bulwahn@gmail.com> From: Eric Dumazet Date: Tue, 9 May 2023 10:51:06 +0200 Message-ID: Subject: Re: [PATCH] net: skbuff: remove special handling for SLOB To: Lukas Bulwahn Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Vlastimil Babka , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 9, 2023 at 9:12=E2=80=AFAM Lukas Bulwahn wrote: > > Commit c9929f0e344a ("mm/slob: remove CONFIG_SLOB") removes CONFIG_SLOB. > Now, we can also remove special handling for socket buffers with the SLOB > allocator. The code with HAVE_SKB_SMALL_HEAD_CACHE=3D1 is now the default > behavior for all allocators. > > Remove an unnecessary distinction between SLOB and SLAB/SLUB allocator > after the SLOB allocator is gone. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Eric Dumazet